[TASK] Remove leftover FormEngine TSconfig values

Several infos in TSconfig / FormEngine are never used,
the field "storage_pid" does not even exist anymore in v8
(was moved to compatibility6 for v7).

Resolves: #73612
Releases: master
Change-Id: Iec578faa6dc591ad39eddcfbb8c6d06910e13950
Reviewed-on: https://review.typo3.org/46822
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>

diff --git a/typo3/sysext/backend/Classes/Utility/BackendUtility.php b/typo3/sysext/backend/Classes/Utility/BackendUtility.php
index 6df390a..9ecba2a 100755 (executable)
--- a/typo3/sysext/backend/Classes/Utility/BackendUtility.php
+++ b/typo3/sysext/backend/Classes/Utility/BackendUtility.php
@@ -3355,12 +3355,12 @@ class BackendUtility
     {
         self::fixVersioningPid($table, $row);
         $res = array();
-        $typeVal = self::getTCAtypeValue($table, $row);
         // Get main config for the table
         list($TScID, $cPid) = self::getTSCpid($table, $row['uid'], $row['pid']);
         if ($TScID >= 0) {
             $tempConf = static::getBackendUserAuthentication()->getTSConfig('TCEFORM.' . $table, self::getPagesTSconfig($TScID));
             if (is_array($tempConf['properties'])) {
+                $typeVal = self::getTCAtypeValue($table, $row);
                 foreach ($tempConf['properties'] as $key => $val) {
                     if (is_array($val)) {
                         $fieldN = substr($key, 0, -1);
@@ -3377,15 +3377,6 @@ class BackendUtility
         $res['_THIS_UID'] = $row['uid'];
         // So the row will be passed to foreign_table_where_query()
         $res['_THIS_ROW'] = $row;
-        $rootLine = self::BEgetRootLine($TScID, '', true);
-        foreach ($rootLine as $rC) {
-            if (!$res['_STORAGE_PID']) {
-                $res['_STORAGE_PID'] = (int)$rC['storage_pid'];
-            }
-            if (!$res['_SITEROOT']) {
-                $res['_SITEROOT'] = $rC['is_siteroot'] ? (int)$rC['uid'] : 0;
-            }
-        }
         return $res;
     }