[TASK] Make CommandLineBackendTest notice free 09/56309/2
authorSascha Löffler <lsascha@gmail.com>
Sat, 17 Mar 2018 14:12:32 +0000 (15:12 +0100)
committerChristian Kuhn <lolli@schwarzbu.ch>
Sat, 17 Mar 2018 16:14:10 +0000 (17:14 +0100)
Resolves: #84435
Releases: master
Change-Id: I031a41c5b22f3d30b0fe0bf55e0ed85f7fa05b7b
Reviewed-on: https://review.typo3.org/56309
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
typo3/sysext/core/Classes/Utility/CommandUtility.php
typo3/sysext/rsaauth/Tests/Unit/Backend/CommandLineBackendTest.php

index a1a894c..731ede0 100644 (file)
@@ -159,7 +159,7 @@ class CommandUtility
             return -1;
         }
         // Already checked and valid
-        if (self::$applications[$cmd]['valid']) {
+        if (self::$applications[$cmd]['valid'] ?? false) {
             return true;
         }
         // Is set but was (above) not TRUE
index e1bad6f..0101a0e 100644 (file)
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types = 1);
 namespace TYPO3\CMS\Rsaauth\Tests\Unit\Backend;
 
 /*
@@ -15,18 +16,14 @@ namespace TYPO3\CMS\Rsaauth\Tests\Unit\Backend;
  */
 
 use TYPO3\CMS\Rsaauth\Backend\CommandLineBackend;
+use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
 
 /**
  * Test case.
  */
-class CommandLineBackendTest extends \TYPO3\TestingFramework\Core\Unit\UnitTestCase
+class CommandLineBackendTest extends UnitTestCase
 {
     /**
-     * Subject is not notice free, disable E_NOTICES
-     */
-    protected static $suppressNotices = true;
-
-    /**
      * @var CommandLineBackend
      */
     protected $subject = null;