[BUGFIX] Disable some not finished functions in EM
authorHelmut Hummel <helmut.hummel@typo3.org>
Tue, 27 Nov 2012 00:45:30 +0000 (01:45 +0100)
committerHelmut Hummel <helmut.hummel@typo3.org>
Tue, 27 Nov 2012 01:09:34 +0000 (02:09 +0100)
The Extension Manager uses jQuery DataTables, but the
current implementation is not streamlined and causes
more trouble than it helps. Same goes for the tooltips
which are not properly styled.

As discussed with the UI/UX team we disable this
functionality and properly implement it in later
versions as bugfixes.

Fixes: #43319
Releases: 6.0

Change-Id: I432a15bce3c3933efa33f65304b01e2720b051a5
Reviewed-on: http://review.typo3.org/16770
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
typo3/sysext/extensionmanager/Classes/Controller/UpdateFromTerController.php
typo3/sysext/extensionmanager/Resources/Private/Partials/List/TerSingleLine.html
typo3/sysext/extensionmanager/Resources/Public/JavaScript/main.js
typo3/sysext/extensionmanager/Resources/Public/JavaScript/ter.js

index 8a29c9e..00b755b 100644 (file)
@@ -102,14 +102,16 @@ class UpdateFromTerController extends \TYPO3\CMS\Extensionmanager\Controller\Abs
                $errorMessage = '';
                /** @var $repository \TYPO3\CMS\Extensionmanager\Domain\Model\Repository */
                $repository = $this->repositoryRepository->findOneByUid((int)$this->settings['repositoryUid']);
-               if ($repository->getLastUpdate()->getTimestamp() < $GLOBALS['EXEC_TIME'] - 24 * 60 * 60 || $forceUpdateCheck) {
+               if ($repository->getExtensionCount() === 0 || $forceUpdateCheck) {
                        try {
                                $updated = $this->repositoryHelper->updateExtList();
                        } catch (\TYPO3\CMS\Extensionmanager\Exception\ExtensionManagerException $e) {
                                $errorMessage = $e->getMessage();
                        }
                }
-               $this->view->assign('updated', $updated)->assign('repository', $repository)->assign('errorMessage', $errorMessage);
+               $this->view->assign('updated', $updated)
+                               ->assign('repository', $repository)
+                               ->assign('errorMessage', $errorMessage);
        }
 }
 ?>
\ No newline at end of file
index 656e982..18b85fa 100644 (file)
@@ -13,8 +13,8 @@
        {extension.version}
        <em:showExtensionVersions extension="{extension}" />
 </td>
-<td>
-       {extension.description}
+<td title="{extension.description}">
+       <f:format.crop maxCharacters="50" respectWordBoundaries="true" respectHtml="false">{extension.description}</f:format.crop>
 
        <div class="author">
                <div class="author-name">{extension.authorName}</div>
index 98c8de2..7b285bd 100644 (file)
@@ -3,8 +3,6 @@
 
        $(document).ready(function() {
                manageExtensionListing();
-               $('th[title]').tooltip({offset: [-10, -30], position: 'bottom right', tipClass: 'headerTooltip'});
-               $('td[title]').tooltip({offset: [-10, -60], position: 'bottom right'});
                $("#typo3-extension-configuration-forms ul").tabs("div.category");
 
                $('#resetSearch').live('click', function (e) {
@@ -27,7 +25,7 @@
 
        function manageExtensionListing() {
                datatable = $('#typo3-extension-list').dataTable({
-                       "sPaginationType":"full_numbers",
+                       "bPaginate": false,
                        "bJQueryUI":true,
                        "bLengthChange":false,
                        'iDisplayLength':15,
@@ -44,7 +42,6 @@
        }
 
        function bindActions() {
-               $('td[title], tr[title]').tooltip({offset: [-10, -60], position: 'bottom right'});
                $('.removeExtension').not('.transformed').each(function() {
                        $(this).data('href', $(this).attr('href'));
                        $(this).attr('href', '#');
index 760a0d0..64ac68d 100644 (file)
@@ -10,6 +10,7 @@
                        "bInfo": false,
                        "bPaginate": false,
                        "bFilter": false,
+                       "bSort": false,
                        "fnDrawCallback": bindDownload
                });
 
                        "bInfo":false,
                        "bPaginate":false,
                        "bFilter":false,
-                       "aaSorting":[[0, 'desc']],
+                       "bSort": false,
                        "fnDrawCallback":bindDownload
                });
 
                $('#terSearchTable').dataTable({
-                       "sPaginationType":"full_numbers",
+                       "bPaginate": false,
                        "bJQueryUI":true,
                        "bLengthChange": false,
                        'iDisplayLength': 15,
                        "bStateSave": false,
+                       "bFilter": false,
                        "oLanguage": {
                                "sSearch": "Filter results:"
                        },
-                       "aaSorting": [],
+                       "bSort": false,
                        "fnDrawCallback": bindDownload
                });
                bindDownload();