[TASK] Add labels to log in info module
authorGeorg Ringer <mail@ringerge.org>
Fri, 17 Aug 2012 04:42:10 +0000 (06:42 +0200)
committerGeorg Ringer <georg.ringer@gmail.com>
Tue, 11 Sep 2012 11:01:56 +0000 (13:01 +0200)
Labels improve the usuability, so add them

Change-Id: I7d06f26959eb46cab449a2870942df02917023b0
Resolves: #39874
Releases: 6.0
Reviewed-on: http://review.typo3.org/13831
Reviewed-by: Stefan Neufeind
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Christian Kuhn
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
typo3/sysext/belog/Resources/Private/Partials/Content/Filter.html

index 0f64025..82f3840 100644 (file)
                <tbody>
                        <tr>
                                <th>
-                                       <f:translate key="users" />
+                                       <label for="belog-users"><f:translate key="users" /></label>
                                </th>
                                <td>
                                        <f:form.select
                                                property="userOrGroup"
                                                options="{userGroups}"
                                                additionalAttributes="{onchange : 'submit()'}"
+                                               id="belog-users"
                                        />
                                </td>
 
                                <th>
-                                       <f:translate key="max" />
+                                       <label for="belog-max"><f:translate key="max" /></label>
                                </th>
                                <td>
                                        <belog:form.translateLabelSelect
@@ -45,6 +46,7 @@
                                                options="{settings.selectableNumberOfLogEntries}"
                                                optionLabelPrefix="LLL:EXT:belog/Resources/Private/Language/locallang.xlf:"
                                                additionalAttributes="{onchange : 'submit()'}"
+                                               id="belog-max"
                                        />
                                </td>
 
                                                <f:if condition="{showWorkspaceSelector}">
                                                        <f:then>
                                                                <th>
-                                                                       <f:translate key="workspace" />
+                                                                       <label for="belog-workspaces"><f:translate key="workspace" /></label>
                                                                </th>
                                                                <td>
                                                                        <f:form.select
                                                                                property="workspaceUid"
                                                                                options="{workspaces}"
                                                                                additionalAttributes="{onchange : 'submit()'}"
+                                                                               id="belog-workspaces"
                                                                        />
                                                                </td>
                                                        </f:then>
                                <f:if condition="{constraint.isInPageContext}">
                                        <f:then>
                                                <th>
-                                                       <f:translate key="chLog_menuDepth" />
+                                                       <label for="belog-depth"><f:translate key="chLog_menuDepth" /></label>
                                                </th>
                                                <td>
                                                        <f:form.select
                                                                property="depth"
                                                                options="{pageDepths}"
                                                                additionalAttributes="{onchange : 'submit()'}"
+                                                               id="belog-depth"
                                                        />
                                                </td>
                                        </f:then>
@@ -94,7 +98,7 @@
 
                        <tr>
                                <th>
-                                       <f:translate key="time" />
+                                       <label for="belog-time"><f:translate key="time" /></label>
                                </th>
                                <td>
                                        <belog:form.translateLabelSelect
                                                options="{settings.selectableTimeFrames}"
                                                optionLabelPrefix="LLL:EXT:belog/Resources/Private/Language/locallang.xlf:"
                                                additionalAttributes="{onchange : 'submit()'}"
+                                               id="belog-time"
                                        />
 
                                        <f:comment>
                                        <f:if condition="{constraint.timeFrame} == 30">
                                                <br />
 
-                                               <f:translate key="LLL:EXT:lang/locallang_common.xml:from" />&nbsp;
+                                               <label for="tceforms-datetimefield-manualDateStart"><f:translate key="LLL:EXT:lang/locallang_common.xml:from" /></label>&nbsp;
                                                <f:form.textfield
                                                        property="manualDateStart"
                                                        value="{constraint.manualDateStart -> f:format.date(format:'{settings.dateFormat} {settings.timeFormat}')}"
                                                        &nbsp;
                                                </span>
 
-                                               <f:translate key="LLL:EXT:lang/locallang_common.xml:to" />&nbsp;
+                                               <label for="tceforms-datetimefield-manualDateStop"><f:translate key="LLL:EXT:lang/locallang_common.xml:to" /></label>&nbsp;
                                                <f:form.textfield
                                                        property="manualDateStop"
                                                        value="{constraint.manualDateStop -> f:format.date(format:'{settings.dateFormat} {settings.timeFormat}')}"
                                </td>
 
                                <th>
-                                       <f:translate key="action" />
+                                       <label for="belog-action"><f:translate key="action" /></label>
                                </th>
                                <td>
                                        <belog:form.translateLabelSelect
                                                options="{settings.selectableActions}"
                                                optionLabelPrefix="LLL:EXT:belog/Resources/Private/Language/locallang.xlf:"
                                                additionalAttributes="{onchange : 'submit()'}"
+                                               id="belog-action"
                                        />
                                </td>
 
                                <th>
-                                       <f:translate key="groupByPage" />
+                                       <label for="belog-group"><f:translate key="groupByPage" /></label>
                                </th>
                                <td>
                                        <f:form.checkbox
                                                property="groupByPage"
                                                value="1"
                                                additionalAttributes="{onchange : 'submit()'}"
+                                               id="belog-group"
                                        />
                                </td>