[TASK] Correct QuerySettingsInterface RespectSysLanguage comments 95/56295/2
authorTymoteusz Motylewski <t.motylewski@gmail.com>
Sat, 17 Mar 2018 11:20:44 +0000 (12:20 +0100)
committerChristian Kuhn <lolli@schwarzbu.ch>
Sat, 17 Mar 2018 12:36:17 +0000 (13:36 +0100)
The setRespectSysLanguage and getRespectSysLanguage methods
are not ifluencing the overlay process, just whether to take
record language into account in db query.

Releases: master, 8.7
Resolves: #84419
Change-Id: I976210663b24ad99080daedea300c4e42ff59224
Reviewed-on: https://review.typo3.org/56295
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
typo3/sysext/extbase/Classes/Persistence/Generic/QuerySettingsInterface.php
typo3/sysext/extbase/Classes/Persistence/Generic/Typo3QuerySettings.php

index 641abb7..4d938a4 100644 (file)
@@ -52,18 +52,19 @@ interface QuerySettingsInterface
     public function getStoragePageIds();
 
     /**
-     * Sets the flag if a translation is chosen and language overlay should be performed.
+     * Sets the flag if record language should be respected when querying.
+     * Other settings defines whether overlay should happen or not.
      *
-     * @param bool $respectSysLanguage TRUE if a translation is chosen and language overlay should be performed.
+     * @param bool $respectSysLanguage TRUE if only record language should be respected when querying
      * @return \TYPO3\CMS\Extbase\Persistence\Generic\QuerySettingsInterface instance of $this to allow method chaining
      * @api
      */
     public function setRespectSysLanguage($respectSysLanguage);
 
     /**
-     * Returns the state, if a language overlay should be performed when a translation is active.
+     * Returns the state, if record language should be checked when querying
      *
-     * @return bool TRUE, if a language overlay should be performed when a translation is active; otherwise FALSE.
+     * @return bool if TRUE record language is checked.
      */
     public function getRespectSysLanguage();
 
index 489f078..31b6eae 100644 (file)
@@ -86,7 +86,7 @@ class Typo3QuerySettings implements QuerySettingsInterface
     protected $languageMode = null;
 
     /**
-     * Represensting sys_language_uid only valid for current context
+     * Representing sys_language_uid only valid for current context
      *
      * @var int
      */