[TASK] Clean up uses of fe_adminLib properties 67/26567/3
authorFrancois Suter <francois@typo3.org>
Fri, 27 Dec 2013 16:28:56 +0000 (17:28 +0100)
committerFrancois Suter <francois@typo3.org>
Tue, 7 Jan 2014 21:18:19 +0000 (22:18 +0100)
Two Core tables (fe_users and index_config) still use the
"fe_admin_fieldList" property, which has no effect on the
Core since the fe_adminLib.inc was moved out of it
(into the statictemplates extension).

Additionally a deprecation message is logged in method
ExtensionManagementUtility::addTCAcolumns() when the $addTofeInterface
argument is set to TRUE.

Resolves: #54613
Releases: 6.2
Change-Id: I7c9961c5e92411a78bd355519a0493eb695177e7
Reviewed-on: https://review.typo3.org/26567
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Francois Suter
Tested-by: Francois Suter
typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php
typo3/sysext/frontend/Configuration/TCA/fe_users.php
typo3/sysext/indexed_search/Configuration/TCA/index_config.php

index 9b2de5e..54b9c72 100644 (file)
@@ -215,15 +215,17 @@ class ExtensionManagementUtility {
         *
         * @param string $table The table name of a table already present in $GLOBALS['TCA'] with a columns section
         * @param array $columnArray The array with the additional columns (typical some fields an extension wants to add)
-        * @param boolean $addTofeInterface If $addTofeInterface is TRUE the list of fields are also added to the fe_admin_fieldList.
+        * @param boolean $addTofeInterface DEPRECATED: Usage of feInterface is no longer part of the TYPO3 CMS Core. Please check EXT:statictemplates.
         * @return void
         */
-       static public function addTCAcolumns($table, $columnArray, $addTofeInterface = 0) {
+       static public function addTCAcolumns($table, $columnArray, $addTofeInterface = FALSE) {
                if (is_array($columnArray) && is_array($GLOBALS['TCA'][$table]) && is_array($GLOBALS['TCA'][$table]['columns'])) {
                        // Candidate for array_merge() if integer-keys will some day make trouble...
                        $GLOBALS['TCA'][$table]['columns'] = array_merge($GLOBALS['TCA'][$table]['columns'], $columnArray);
                        if ($addTofeInterface) {
-                               $GLOBALS['TCA'][$table]['feInterface']['fe_admin_fieldList'] .= ',' . implode(',', array_keys($columnArray));
+                               GeneralUtility::deprecationLog(
+                                       'Usage of feInterface is no longer part of the TYPO3 CMS Core. Please check EXT:statictemplates.'
+                               );
                        }
                }
        }
index 1d911a7..645c4c6 100644 (file)
@@ -21,9 +21,6 @@ return array(
                'dividers2tabs' => 1,
                'searchFields' => 'username,name,first_name,last_name,middle_name,address,telephone,fax,email,title,zip,city,country,company'
        ),
-       'feInterface' => array(
-               'fe_admin_fieldList' => 'username,password,usergroup,name,address,telephone,fax,email,title,zip,city,country,www,company'
-       ),
        'interface' => array(
                'showRecordFieldList' => 'username,password,usergroup,lockToDomain,name,first_name,middle_name,last_name,title,company,address,zip,city,country,email,www,telephone,fax,disable,starttime,endtime,lastlogin'
        ),
index fc19b88..6202343 100644 (file)
@@ -14,9 +14,6 @@ return array(
                ),
                'iconfile' => 'default.gif'
        ),
-       'feInterface' => array(
-               'fe_admin_fieldList' => 'hidden, starttime, title, description, type, depth, table2index, alternative_source_pid, get_params, chashcalc, filepath, extensions'
-       ),
        'interface' => array(
                'showRecordFieldList' => 'hidden,starttime,title,description,type,depth,table2index,alternative_source_pid,get_params,chashcalc,filepath,extensions'
        ),