[BUGFIX] Last CGL violation against property visibility
authorChristian Kuhn <lolli@schwarzbu.ch>
Fri, 21 Sep 2012 22:23:32 +0000 (00:23 +0200)
committerGeorg Ringer <georg.ringer@gmail.com>
Sat, 22 Sep 2012 00:14:18 +0000 (02:14 +0200)
The $messages property should have been protected in the first
place, since there is already a shiny API around it.

Change-Id: Ia493dceb9d2fbbbf9232a0abd043b69f9d556473
Resolves: #41227
Releases: 6.0
Reviewed-on: http://review.typo3.org/14894
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
typo3/sysext/core/Classes/Messaging/FlashMessageQueue.php
typo3/sysext/core/Tests/Unit/FormProtection/BackendFormProtectionTest.php

index 0b3b3bc..31ea6b5 100644 (file)
@@ -35,7 +35,7 @@ namespace TYPO3\CMS\Core\Messaging;
  */
 class FlashMessageQueue {
 
-       static $messages = array();
+       static protected $messages = array();
 
        /**
         * Static class, no instances allowed.
index a8fbebf..314b8a5 100644 (file)
@@ -257,7 +257,7 @@ class BackendFormProtectionTest extends \tx_phpunit_testcase {
                $GLOBALS['TYPO3_AJAX'] = TRUE;
                $this->fixture->createValidationErrorMessage();
 
-               $messages = \TYPO3\CMS\Core\Messaging\FlashMessageQueue::$messages;
+               $messages = \TYPO3\CMS\Core\Messaging\FlashMessageQueue::getAllMessages();
 
                $this->assertNotEmpty($messages);
                $this->assertContains(