[FOLLOWUP][TASK] Remove leftover unzipping core functionality 40/45740/3
authorMorton Jonuschat <m.jonuschat@mojocode.de>
Fri, 8 Jan 2016 21:23:05 +0000 (22:23 +0100)
committerAnja Leichsenring <aleichsenring@ab-softlab.de>
Fri, 8 Jan 2016 22:10:18 +0000 (23:10 +0100)
Remove unzipFile permission from BackendUserAuthenticationTest.

Resolves: #72611
Related: #72602
Releases: master
Change-Id: Ieb9d13f95404875ce68170ef721bc37619619ec0
Reviewed-on: https://review.typo3.org/45740
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php
typo3/sysext/core/Documentation/Changelog/master/Breaking-72602-RemovedUnzipFunctionality.rst
typo3/sysext/core/Tests/Unit/Authentication/BackendUserAuthenticationTest.php

index f43e167..46f6bd0 100644 (file)
@@ -69,15 +69,6 @@ use TYPO3\CMS\Lang\LanguageService;
 class ExtendedFileUtility extends BasicFileUtility
 {
     /**
-     * External static variables:
-     * Notice; some of these are overridden in the start() method with values from $GLOBALS['TYPO3_CONF_VARS']['BE']
-     * Path to unzip-program (with trailing '/')
-     *
-     * @var string
-     */
-    public $unzipPath = '';
-
-    /**
      * Defines behaviour when uploading files with names that already exist; possible values are
      * the values of the \TYPO3\CMS\Core\Resource\DuplicationBehavior enumeration
      *
index f641e12..f32d3ee 100644 (file)
@@ -7,7 +7,7 @@ Description
 
 The legacy functionality to unzip files from outside the document root was removed.
 
-Additionally, the corresponding option ``$TYPO3_CONF_VARS[BE][unzip_path]`` was removed as well.
+Additionally, the corresponding option ``$TYPO3_CONF_VARS[BE][unzip_path]`` and the class member ``ExtendedFileUtility::$unzipPath`` were removed as well.
 
 Legacy methods from the Extbase domain model BackendUser named ``isFileUnzipAllowed``
 and ``setFileUnzipAllowed`` were removed.
@@ -24,4 +24,4 @@ Using the Extbase domain model methods will result in a fatal PHP error.
 Migration
 =========
 
-Use a third-party extension to integrate unzip functionality into TYPO3.
\ No newline at end of file
+Use a third-party extension to integrate unzip functionality into TYPO3.
index 5f21a9c..7f34b2a 100644 (file)
@@ -30,7 +30,6 @@ class BackendUserAuthenticationTest extends \TYPO3\CMS\Core\Tests\UnitTestCase
         'copyFile' => false,
         'moveFile' => false,
         'renameFile' => false,
-        'unzipFile' => false,
         'deleteFile' => false,
         // Folder permissions
         'addFolder' => false,
@@ -255,7 +254,6 @@ class BackendUserAuthenticationTest extends \TYPO3\CMS\Core\Tests\UnitTestCase
                     'copyFile' => 0,
                     'moveFile' => 0,
                     'renameFile' => 0,
-                    'unzipFile' => 0,
                     'deleteFile' => 0,
                     'addFolder' => 0,
                     'readFolder' => 1,
@@ -275,7 +273,6 @@ class BackendUserAuthenticationTest extends \TYPO3\CMS\Core\Tests\UnitTestCase
                     'copyFile' => 1,
                     'moveFile' => 1,
                     'renameFile' => 1,
-                    'unzipFile' => 0,
                     'deleteFile' => 1,
                     'addFolder' => 0,
                     'readFolder' => 1,
@@ -340,7 +337,6 @@ class BackendUserAuthenticationTest extends \TYPO3\CMS\Core\Tests\UnitTestCase
             'copyFile' => true,
             'moveFile' => true,
             'renameFile' => true,
-            'unzipFile' => true,
             'deleteFile' => true,
             'addFolder' => true,
             'readFolder' => true,
@@ -367,7 +363,6 @@ class BackendUserAuthenticationTest extends \TYPO3\CMS\Core\Tests\UnitTestCase
                     'copyFile' => 1,
                     'moveFile' => 1,
                     'renameFile' => 1,
-                    'unzipFile' => 1,
                     'deleteFile' => 1,
                     'addFolder' => 1,
                     'readFolder' => 1,
@@ -393,7 +388,6 @@ class BackendUserAuthenticationTest extends \TYPO3\CMS\Core\Tests\UnitTestCase
                     'copyFile' => true,
                     'moveFile' => true,
                     'renameFile' => true,
-                    'unzipFile' => true,
                     'deleteFile' => true,
                     'addFolder' => true,
                     'readFolder' => true,
@@ -416,7 +410,6 @@ class BackendUserAuthenticationTest extends \TYPO3\CMS\Core\Tests\UnitTestCase
                     'copyFile' => true,
                     'moveFile' => true,
                     'renameFile' => true,
-                    'unzipFile' => true,
                     'deleteFile' => true,
                     'addFolder' => true,
                     'readFolder' => true,
@@ -519,7 +512,6 @@ class BackendUserAuthenticationTest extends \TYPO3\CMS\Core\Tests\UnitTestCase
                     'copyFile' => false,
                     'moveFile' => false,
                     'renameFile' => false,
-                    'unzipFile' => false,
                     'deleteFile' => false,
                     'addFolder' => false,
                     'readFolder' => false,
@@ -540,7 +532,6 @@ class BackendUserAuthenticationTest extends \TYPO3\CMS\Core\Tests\UnitTestCase
                     'copyFile' => true,
                     'moveFile' => true,
                     'renameFile' => true,
-                    'unzipFile' => false,
                     'deleteFile' => true,
                     'addFolder' => false,
                     'readFolder' => false,
@@ -552,27 +543,6 @@ class BackendUserAuthenticationTest extends \TYPO3\CMS\Core\Tests\UnitTestCase
                     'recursivedeleteFolder' => false
                 )
             ),
-            'Unzip allowed' => array(
-                'readFile,unzipFile',
-                array(
-                    'addFile' => false,
-                    'readFile' => true,
-                    'writeFile' => false,
-                    'copyFile' => false,
-                    'moveFile' => false,
-                    'renameFile' => false,
-                    'unzipFile' => true,
-                    'deleteFile' => false,
-                    'addFolder' => false,
-                    'readFolder' => false,
-                    'writeFolder' => false,
-                    'copyFolder' => false,
-                    'moveFolder' => false,
-                    'renameFolder' => false,
-                    'deleteFolder' => false,
-                    'recursivedeleteFolder' => false
-                )
-            ),
             'Standard folder permissions' => array(
                 'addFolder,readFolder,moveFolder,renameFolder,writeFolder,deleteFolder',
                 array(
@@ -582,7 +552,6 @@ class BackendUserAuthenticationTest extends \TYPO3\CMS\Core\Tests\UnitTestCase
                     'copyFile' => false,
                     'moveFile' => false,
                     'renameFile' => false,
-                    'unzipFile' => false,
                     'deleteFile' => false,
                     'addFolder' => true,
                     'readFolder' => true,
@@ -603,7 +572,6 @@ class BackendUserAuthenticationTest extends \TYPO3\CMS\Core\Tests\UnitTestCase
                     'copyFile' => false,
                     'moveFile' => false,
                     'renameFile' => false,
-                    'unzipFile' => false,
                     'deleteFile' => false,
                     'addFolder' => false,
                     'readFolder' => true,
@@ -624,7 +592,6 @@ class BackendUserAuthenticationTest extends \TYPO3\CMS\Core\Tests\UnitTestCase
                     'copyFile' => false,
                     'moveFile' => false,
                     'renameFile' => false,
-                    'unzipFile' => false,
                     'deleteFile' => false,
                     'addFolder' => false,
                     'readFolder' => true,
@@ -676,7 +643,6 @@ class BackendUserAuthenticationTest extends \TYPO3\CMS\Core\Tests\UnitTestCase
             'copyFile' => true,
             'moveFile' => true,
             'renameFile' => true,
-            'unzipFile' => true,
             'deleteFile' => true,
             'addFolder' => true,
             'readFolder' => true,