[TASK] Improve layout of service reports 82/57782/6
authorGeorg Ringer <georg.ringer@gmail.com>
Thu, 2 Aug 2018 15:52:08 +0000 (17:52 +0200)
committerTymoteusz Motylewski <t.motylewski@gmail.com>
Sun, 5 Aug 2018 08:02:32 +0000 (10:02 +0200)
Improve the following issues in the reports module regarding services:

- Use th instead of td
- Use correct labels
- Improved layout
- Add label for description

Resolves: #85734
Releases: master
Change-Id: Ied52773319706661d01d49682ef52829f924e555
Reviewed-on: https://review.typo3.org/57782
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: PaweĊ‚ Rogowicz <rogowicz.pawel@gmail.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
typo3/sysext/reports/Resources/Private/Language/locallang_servicereport.xlf
typo3/sysext/reports/Resources/Private/Templates/ServicesListReport.html

index 0dd4b56..fcb6eea 100644 (file)
@@ -21,6 +21,9 @@
                        <trans-unit id="service">
                                <source>Service</source>
                        </trans-unit>
+                       <trans-unit id="description">
+                               <source>Description</source>
+                       </trans-unit>
                        <trans-unit id="priority">
                                <source>Priority</source>
                        </trans-unit>
index dcb9331..741f457 100644 (file)
         <table class="table table-striped table-hover tx_sv_reportlist">
             <thead>
                 <tr>
-                    <td><f:translate key="LLL:EXT:reports/Resources/Private/Language/locallang_servicereport.xlf:path" /></td>
-                    <td><f:translate key="LLL:EXT:reports/Resources/Private/Language/locallang_servicereport.xlf:valid" /></td>
+                    <th><f:translate key="LLL:EXT:reports/Resources/Private/Language/locallang_servicereport.xlf:path" /></th>
+                    <th><f:translate key="LLL:EXT:reports/Resources/Private/Language/locallang_servicereport.xlf:valid" /></th>
                 </tr>
             </thead>
             <tbody>
                 <f:for each="{searchPaths}" as="searchPath">
                     <tr class="{searchPath.class}">
                         <td class="first-cell">{searchPath.path}</td>
-                        <td class="last-cell"><f:translate key="LLL:EXT:reports/Resources/Private/Language/locallang_servicereport.xlf:{searchPath.accessible}" /></td>
+                        <td class="last-cell"><f:translate key="{searchPath.accessible}" /></td>
                     </tr>
                 </f:for>
             </tbody>
     <table class="table table-striped table-hover tx_sv_reportlist">
         <thead>
             <tr>
-                <td style="width: 35%"><f:translate key="service" /></td>
-                <td><f:translate key="LLL:EXT:reports/Resources/Private/Language/locallang_servicereport.xlf:priority" /></td>
-                <td><f:translate key="LLL:EXT:reports/Resources/Private/Language/locallang_servicereport.xlf:quality" /></td>
-                <td style="width: 35%"><f:translate key="LLL:EXT:reports/Resources/Private/Language/locallang_servicereport.xlf:subtypes" /></td>
-                <td><f:translate key="LLL:EXT:reports/Resources/Private/Language/locallang_servicereport.xlf:os" /></td>
-                <td><f:translate key="LLL:EXT:reports/Resources/Private/Language/locallang_servicereport.xlf:externals" /></td>
-                <td><f:translate key="LLL:EXT:reports/Resources/Private/Language/locallang_servicereport.xlf:available" /></td>
+                <th><f:translate key="LLL:EXT:reports/Resources/Private/Language/locallang_servicereport.xlf:service" /></th>
+                <th><f:translate key="LLL:EXT:reports/Resources/Private/Language/locallang_servicereport.xlf:description" /></th>
+                <th><f:translate key="LLL:EXT:reports/Resources/Private/Language/locallang_servicereport.xlf:priority" /></th>
+                <th><f:translate key="LLL:EXT:reports/Resources/Private/Language/locallang_servicereport.xlf:quality" /></th>
+                <th style="width: 35%"><f:translate key="LLL:EXT:reports/Resources/Private/Language/locallang_servicereport.xlf:subtypes" /></th>
+                <th><f:translate key="LLL:EXT:reports/Resources/Private/Language/locallang_servicereport.xlf:os" /></th>
+                <th><f:translate key="LLL:EXT:reports/Resources/Private/Language/locallang_servicereport.xlf:externals" /></th>
+                <th><f:translate key="LLL:EXT:reports/Resources/Private/Language/locallang_servicereport.xlf:available" /></th>
             </tr>
         </thead>
         <tbody>
 
 <f:section name="ServiceRow">
     <tr class="service {service.AvailabilityClass}">
+        <td>{service.Information.title} ({service.Information.extKey})</td>
         <td class="first-cell">{service.Description}
-            <p class="service-header">
-                <span class="service-title">{service.Information.title}</span> ({service.Information.extKey}: {service.Key})
-            </p>
             <f:if condition="{service.Information.description}">
                 <p class="service-description">{service.Information.description}</p>
             </f:if>
+            <code>{service.Key}</code>
         </td>
         <td class="cell">{service.Information.priority}</td>
         <td class="cell">{service.Information.quality}</td>