[TASK] Remove unnecessary RTE default configuration 13/51913/3
authorBenni Mack <benni@typo3.org>
Wed, 1 Mar 2017 10:52:12 +0000 (11:52 +0100)
committerBenni Mack <benni@typo3.org>
Wed, 1 Mar 2017 11:04:14 +0000 (12:04 +0100)
As the default preset is now always fetched,
the base RTE configuration in FormEngine can be
reduced again, and everything is fetched from the
Yaml/pageTS configuration.

Resolves: #80074
Releases: master
Change-Id: I21b1d4ded26e1b563d60c97b11e1de4eaa65fb19
Reviewed-on: https://review.typo3.org/51913
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
typo3/sysext/rte_ckeditor/Classes/Form/Element/RichTextElement.php

index 4906b4e..52650ed 100644 (file)
@@ -52,13 +52,6 @@ class RichTextElement extends AbstractFormElement
     protected $rteConfiguration = [];
 
     /**
-     * The path to EXT:rte_ckeditor/Resources/Public/ where all assets etc. are stored.
-     *
-     * @var string
-     */
-    protected $defaultResourcesPath;
-
-    /**
      * Renders the ckeditor element
      *
      * @return array
@@ -69,7 +62,6 @@ class RichTextElement extends AbstractFormElement
         $resultArray = $this->initializeResultArray();
         $parameterArray = $this->data['parameterArray'];
         $config = $parameterArray['fieldConf']['config'];
-        $this->defaultResourcesPath = $this->resolveUrlPath('EXT:rte_ckeditor/Resources/Public/');
 
         $fieldId = $this->sanitizeFieldId($parameterArray['itemFormElName']);
         $itemFormElementName = $this->data['parameterArray']['itemFormElName'];
@@ -262,14 +254,10 @@ class RichTextElement extends AbstractFormElement
      */
     protected function prepareConfigurationForEditor(): array
     {
-        // Set some good defaults
+        // Ensure custom config is empty so nothing additional is loaded
+        // Of course this can be overriden by the editor configuration below
         $configuration = [
-            'contentsCss' => $this->defaultResourcesPath . 'Css/contents.css',
-            'customConfig' => '', // do not load anything
-            'toolbar' => 'Basic',
-            'uiColor' => '#F8F8F8',
-            'stylesSet' => 'default',
-            'extraPlugins' => '',
+            'customConfig' => '',
         ];
 
         if (is_array($this->rteConfiguration['config'])) {