[BUGFIX] Respect automaticInstallation setting in extension manager 61/56361/2
authorNicole Cordes <typo3@cordes.co>
Sun, 11 Mar 2018 17:05:00 +0000 (18:05 +0100)
committerMarkus Klein <markus.klein@typo3.org>
Mon, 19 Mar 2018 09:25:32 +0000 (10:25 +0100)
Prevent the automatic installation of new extensions if the setting
was disabled.

Resolves: #84125
Releases: master, 8.7, 7.6
Change-Id: Ic554e8870543b2f15079f7adfb1ddc2517bfc2b5
Reviewed-on: https://review.typo3.org/56361
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
typo3/sysext/extensionmanager/Classes/Service/ExtensionManagementService.php

index b3b6dca..1891343 100644 (file)
@@ -226,7 +226,10 @@ class ExtensionManagementService implements \TYPO3\CMS\Core\SingletonInterface
         // Attach extension to install queue
         $this->downloadQueue->addExtensionToInstallQueue($extension);
         $installQueue += $this->downloadQueue->resetExtensionInstallStorage();
-        $installedDependencies = $this->installDependencies($installQueue);
+        $installedDependencies = [];
+        if ($this->automaticInstallationEnabled) {
+            $installedDependencies = $this->installDependencies($installQueue);
+        }
 
         return array_merge($downloadedDependencies, $updatedDependencies, $installedDependencies);
     }