[BUGFIX] Add label to page ID field in PageLinkHandler 35/54635/2
authorGeorg Ringer <georg.ringer@gmail.com>
Tue, 7 Nov 2017 07:08:42 +0000 (08:08 +0100)
committerStefan Neufeind <typo3.neufeind@speedpartner.de>
Tue, 14 Nov 2017 09:22:34 +0000 (10:22 +0100)
Add the missing label and adopt styling of the additional
field which allows to link to a page by providing the page ID.

Resolves: #82888
Releases: master, 8.7
Change-Id: I33ab92f235391add5d3da00a0251ee11eb936933
Reviewed-on: https://review.typo3.org/54635
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
typo3/sysext/lang/Resources/Private/Language/locallang_browse_links.xlf
typo3/sysext/recordlist/Classes/LinkHandler/PageLinkHandler.php

index be1868e..f7fe966 100644 (file)
                        <trans-unit id="folderSelector">
                                <source>Folder selector</source>
                        </trans-unit>
+                       <trans-unit id="page_id">
+                               <source>Page ID</source>
+                       </trans-unit>
                </body>
        </file>
 </xliff>
index 63b7da1..ce99902 100644 (file)
@@ -307,17 +307,17 @@ class PageLinkHandler extends AbstractLinkHandler implements LinkHandlerInterfac
         if (!empty($configuration['pageIdSelector.']['enabled'])) {
             $this->linkAttributes[] = 'pageIdSelector';
             $fieldDefinitions['pageIdSelector'] = '
-                               <tr>
-                                       <td>
-                                               <label>
-                                                       ' . htmlspecialchars($this->getLanguageService()->getLL('page_id')) . ':
+                               <form class="form-horizontal"><div class="form-group form-group-sm">
+                                       <label class="col-xs-4 control-label">
+                                               ' . htmlspecialchars($this->getLanguageService()->getLL('page_id')) . '
                                                </label>
-                                       </td>
-                                       <td colspan="3">
-                                               <input type="text" size="6" name="luid" id="luid" /> <input class="btn btn-default t3js-pageLink" type="submit" value="'
-            . htmlspecialchars($this->getLanguageService()->getLL('setLink')) . '" />
-                                       </td>
-                               </tr>';
+                                       <div class="col-xs-2">
+                                               <input type="number" size="6" name="luid" id="luid" class="form-control" />
+                                       </div>
+                                       <div class="col-xs-6">
+                                               <input class="btn btn-default t3js-pageLink" type="submit" value="' . htmlspecialchars($this->getLanguageService()->getLL('setLink')) . '" />
+                                       </div>
+                               </div></form>';
         }
         return $fieldDefinitions;
     }