[!!!][TASK] Remove deprecated arguments from TranslateElementErrorViewHelper 77/59377/3
authorGeorg Ringer <georg.ringer@gmail.com>
Tue, 8 Jan 2019 18:58:23 +0000 (19:58 +0100)
committerBenni Mack <benni@typo3.org>
Mon, 14 Jan 2019 05:16:12 +0000 (06:16 +0100)
Resolves: #87371
Releases: master
Change-Id: Ie7df7b29f3a82a954856d1f7c922cd726f2a43b8
Reviewed-on: https://review.typo3.org/59377
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
typo3/sysext/core/Documentation/Changelog/master/Breaking-87193-DeprecatedFunctionalityRemoved.rst
typo3/sysext/form/Classes/ViewHelpers/TranslateElementErrorViewHelper.php

index d5eb79d..ae73a39 100644 (file)
@@ -1006,6 +1006,9 @@ The following class properties have changed visibility:
 * :php:`TYPO3\CMS\Tstemplate\Controller\TypoScriptTemplateObjectBrowserModuleFunctionController->localLangFile` changed from public to protected
 * :php:`TYPO3\CMS\Tstemplate\Controller\TypoScriptTemplateObjectBrowserModuleFunctionController->pObj` changed from public to protected
 
+The following VieHelpers have changed:
+
+* :php:`TYPO3\CMS\Form\ViewHelpers\TranslateElementErrorViewHelper`: The arguments `code`, `arguments` & `defaultValue` have been removed.
 
 The following scheduler tasks have been removed:
 
index 2f60c5b..6c60dc1 100644 (file)
@@ -40,10 +40,7 @@ class TranslateElementErrorViewHelper extends AbstractViewHelper
     public function initializeArguments()
     {
         $this->registerArgument('element', RootRenderableInterface::class, 'Form Element to translate', true);
-        $this->registerArgument('error', Error::class, '', false, '');
-        $this->registerArgument('code', 'integer', 'Error code - deprecated', false, '');
-        $this->registerArgument('arguments', 'array', 'Error arguments - deprecated', false, null);
-        $this->registerArgument('defaultValue', 'string', 'The default value - deprecated', false, '');
+        $this->registerArgument('error', Error::class, 'Error', true);
     }
 
     /**
@@ -59,19 +56,10 @@ class TranslateElementErrorViewHelper extends AbstractViewHelper
         $element = $arguments['element'];
         $error = $arguments['error'];
 
-        $code = $arguments['code'];
-        $errorArguments = $arguments['arguments'];
-        $defaultValue = $arguments['defaultValue'];
-
         if ($error instanceof Error) {
             $code = $error->getCode();
             $errorArguments = $error->getArguments();
             $defaultValue = $error->__toString();
-        } else {
-            trigger_error(
-                'TranslateElementErrorViewHelper arguments "code", "arguments" and "defaultValue" will be removed in TYPO3 v10.0. Use "error" instead.',
-                E_USER_DEPRECATED
-            );
         }
 
         /** @var FormRuntime $formRuntime */