[BUGFIX] Do not overwrite inlineData in mergeResult 84/51984/3
authorHelmut Hummel <typo3@helhum.io>
Wed, 8 Mar 2017 20:54:49 +0000 (21:54 +0100)
committerChristian Kuhn <lolli@schwarzbu.ch>
Wed, 15 Mar 2017 10:09:05 +0000 (11:09 +0100)
Instead of merging different inlineData results, the
FormResultCompiler has one seemingly leftover line of code
which overwrites the inlineData, leading to the situation
that only the last inlineData is kept.

In the list module when editing multiple fields with IRRE relations,
this leads to the fact that children can only be added
to the last element.

For some reason the same code does not expose the bug to the end user,
most likely due to different handling of the context data.

Nevertheless this obviously wrong line should also be removed in 7.6.

Releases: master, 7.6
Resolves: #80181
Change-Id: I56cef1c56a36d1760a99c239130c6791869a1978
Reviewed-on: https://review.typo3.org/51984
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Volker Kemeter <volker@kemeter.de>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
typo3/sysext/backend/Classes/Form/FormResultCompiler.php

index ca98485..9299f11 100644 (file)
@@ -135,7 +135,7 @@ class FormResultCompiler
                 }
             }
         }
-        $this->inlineData = $resultArray['inlineData'];
+
         foreach ($resultArray['additionalHiddenFields'] as $element) {
             $this->hiddenFieldAccum[] = $element;
         }