Fixed bug #17653: t3editor: wrong size calculation in Chrome for the code completion...
authoretobi.de <etobi.de@709f56b5-9817-0410-a4d7-c38de5d9e867>
Tue, 22 Feb 2011 18:54:34 +0000 (18:54 +0000)
committeretobi.de <etobi.de@709f56b5-9817-0410-a4d7-c38de5d9e867>
Tue, 22 Feb 2011 18:54:34 +0000 (18:54 +0000)
git-svn-id: https://svn.typo3.org/TYPO3v4/Core/trunk@10538 709f56b5-9817-0410-a4d7-c38de5d9e867

ChangeLog
typo3/sysext/t3editor/ext_emconf.php
typo3/sysext/t3editor/res/jslib/ts_codecompletion/descriptionPlugin.js
typo3/sysext/t3editor/res/jslib/ts_codecompletion/tscodecompletion.js

index 5822389..d23c446 100755 (executable)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2011-02-22  Tobias Liebig  <mail_typo3@etobi.de>
+
+       * Fixed bug #17653: t3editor: wrong size calculation in Chrome for the code completion window (Thanks to Stephan Petzl)
+
 2011-02-22  Jigal van Hemert  <jigal@xs4all.nl>
 
        * Fixed bug #17518: Content type "mailform" no longer accepts list of addresses for "Recipient List" (also fixed function description in t3lib_mail_SwiftMailerAdapter) 
index fbb0bd0..4cc64af 100755 (executable)
@@ -33,7 +33,7 @@ $EM_CONF[$_EXTKEY] = array(
        'author_company' => '',
        'CGLcompliance' => '',
        'CGLcompliance_note' => '',
-       'version' => '1.5.0',
+       'version' => '1.5.1',
        '_md5_values_when_last_written' => 'a:29:{s:7:"LICENSE";s:4:"c17d";s:12:"ext_icon.gif";s:4:"7eb5";s:17:"ext_localconf.php";s:4:"3b52";s:14:"ext_tables.php";s:4:"7dff";s:13:"locallang.xml";s:4:"fa0e";s:29:"classes/class.tx_t3editor.php";s:4:"6573";s:44:"classes/class.tx_t3editor_hooks_fileedit.php";s:4:"ab8c";s:50:"classes/class.tx_t3editor_hooks_tstemplateinfo.php";s:4:"2d87";s:62:"classes/ts_codecompletion/class.tx_t3editor_codecompletion.php";s:4:"baa9";s:59:"classes/ts_codecompletion/class.tx_t3editor_tsrefloader.php";s:4:"94f6";s:23:"icons/loader_eeeeee.gif";s:4:"83a4";s:21:"res/css/csscolors.css";s:4:"3845";s:20:"res/css/jscolors.css";s:4:"e5a0";s:24:"res/css/sparqlcolors.css";s:4:"40ba";s:20:"res/css/t3editor.css";s:4:"454d";s:26:"res/css/t3editor_inner.css";s:4:"7b52";s:28:"res/css/typoscriptcolors.css";s:4:"e060";s:21:"res/css/xmlcolors.css";s:4:"847a";s:21:"res/jslib/fileedit.js";s:4:"e87e";s:21:"res/jslib/t3editor.js";s:4:"079a";s:45:"res/jslib/parse_typoscript/parsetyposcript.js";s:4:"c8af";s:48:"res/jslib/parse_typoscript/tokenizetyposcript.js";s:4:"dce5";s:47:"res/jslib/ts_codecompletion/completionresult.js";s:4:"ba5f";s:48:"res/jslib/ts_codecompletion/descriptionPlugin.js";s:4:"87a5";s:47:"res/jslib/ts_codecompletion/tscodecompletion.js";s:4:"8140";s:39:"res/jslib/ts_codecompletion/tsparser.js";s:4:"ab5c";s:36:"res/jslib/ts_codecompletion/tsref.js";s:4:"969e";s:27:"res/templates/t3editor.html";s:4:"4133";s:19:"res/tsref/tsref.xml";s:4:"9f7b";}',
        'constraints' => array(
                'depends' => array(
@@ -49,4 +49,4 @@ $EM_CONF[$_EXTKEY] = array(
        ),
 );
 
-?>
\ No newline at end of file
+?>
index 49027ed..dcceeed 100644 (file)
@@ -90,7 +90,12 @@ var DescriptionPlugin = function() {
                descriptionBox.scrollTop = 0;
                descriptionBox.style.overflowY = 'scroll';
                descriptionBox.addClassName('descriptionBox');
-               var leftOffset = parseInt(completionBox.getStyle('left').gsub('px','')) + parseInt(completionBox.getStyle('width').gsub('px','')) + 5;
+               
+               var addX = 5;
+               if (!Prototype.Browser.Gecko) { // not firefox
+                       addX = 18;
+               }
+               var leftOffset = parseInt(completionBox.getStyle('left').gsub('px','')) + parseInt(completionBox.getStyle('width').gsub('px','')) + addX;
                leftOffset += 'px';
                descriptionBox.setStyle({
                        top: completionBox.getStyle('top'),
index 6722658..3b51c91 100644 (file)
@@ -422,14 +422,9 @@ var TsCodeCompletion = function(codeMirror, outerdiv) {
                        codeCompleteBox.scrollTop = 0;
 
                        // init styles
-
                        codeCompleteBox.style.overflowY = 'scroll';
-                       if (Prototype.Browser.Gecko) {
-                               codeCompleteBox.style.height = (options.ccWords * ($("cc_word_0").offsetHeight)) + 'px';
-                       } else {
-                               codeCompleteBox.style.height = (options.ccWords * ($("cc_word_0").offsetHeight)) + 4 + 'px';
-                               codeCompleteBox.style.width = codeCompleteBox.offsetWidth + 20 + 'px';
-                       }
+                       codeCompleteBox.style.height = (options.ccWords * ($("cc_word_0").offsetHeight)) + 'px';
+                       
 
                        var leftpos = (Position.cumulativeOffset($$('.t3e_iframe_wrap')[index])[0] + Position.cumulativeOffset(cursorNode)[0] + cursorNode.offsetWidth) + 'px';
                        var toppos = (Position.cumulativeOffset(cursorNode)[1] + cursorNode.offsetHeight - Element.cumulativeScrollOffset(cursorNode)[1]) + 'px';