[TASK] Remove unneeded backupGlobals from Unit Tests 15/19215/2
authorWouter Wolters <typo3@wouterwolters.nl>
Sat, 23 Mar 2013 13:48:47 +0000 (14:48 +0100)
committerChristian Kuhn <lolli@schwarzbu.ch>
Sat, 23 Mar 2013 14:13:06 +0000 (15:13 +0100)
Change-Id: Ib15d118cd28a455fb5125fc51580382ad72d1d26
Resolves: #46593
Releases: 6.1
Reviewed-on: https://review.typo3.org/19215
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
29 files changed:
typo3/sysext/backend/Tests/Unit/Sprite/SpriteManagerTest.php
typo3/sysext/backend/Tests/Unit/Tree/Pagetree/DataProviderTest.php
typo3/sysext/backend/Tests/Unit/Utility/IconUtilityTest.php
typo3/sysext/core/Tests/Unit/Authentication/AbstractUserAuthenticationTest.php
typo3/sysext/core/Tests/Unit/Authentication/BackendUserAuthenticationTest.php
typo3/sysext/core/Tests/Unit/Cache/Backend/DbBackendTest.php
typo3/sysext/core/Tests/Unit/Cache/Backend/FileBackendTest.php
typo3/sysext/core/Tests/Unit/Cache/Backend/PdoBackendTest.php
typo3/sysext/core/Tests/Unit/Cache/Backend/RedisBackendTest.php
typo3/sysext/core/Tests/Unit/Category/CategoryRegistryTest.php
typo3/sysext/core/Tests/Unit/Core/SystemEnvironmentBuilderTest.php
typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php
typo3/sysext/core/Tests/Unit/FormProtection/BackendFormProtectionTest.php
typo3/sysext/core/Tests/Unit/Locking/LockerTest.php
typo3/sysext/core/Tests/Unit/Log/LogManagerTest.php
typo3/sysext/core/Tests/Unit/Page/PageRendererTest.php
typo3/sysext/core/Tests/Unit/Resource/Driver/DriverRegistryTest.php
typo3/sysext/core/Tests/Unit/Resource/Service/IndexerServiceTest.php
typo3/sysext/core/Tests/Unit/TypoScript/TemplateServiceTest.php
typo3/sysext/core/Tests/Unit/Utility/File/ExtendedFileUtilityTest.php
typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php
typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php
typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php
typo3/sysext/frontend/Tests/Unit/View/AdminPanelViewTest.php
typo3/sysext/indexed_search/Tests/Unit/IndexerTest.php
typo3/sysext/install/Tests/Unit/InstallToolTest.php
typo3/sysext/saltedpasswords/Tests/Unit/Evaluation/EvaluatorTest.php
typo3/sysext/saltedpasswords/Tests/Unit/Utility/SaltedPasswordsUtilityTest.php
typo3/sysext/scheduler/Tests/Unit/Task/CachingFrameworkGarbageCollectionTest.php

index b9212e1..42caeaa 100644 (file)
@@ -30,13 +30,6 @@ namespace TYPO3\CMS\Backend\Tests\Unit\Sprite;
  */
 class SpriteManagerTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {
 
-       /**
-        * Enable backup of global and system variables
-        *
-        * @var boolean
-        */
-       protected $backupGlobals = TRUE;
-
        //////////////////////////////////////////
        // Tests concerning addTcaTypeIcon
        //////////////////////////////////////////
index d330912..83d2e8a 100644 (file)
@@ -32,11 +32,6 @@ namespace TYPO3\CMS\Backend\Tests\Unit\Tree\Pagetree;
 class DataProviderTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {
 
        /**
-        * @var boolean
-        */
-       protected $backupGlobals = TRUE;
-
-       /**
         * @var \TYPO3\CMS\Backend\Tree\Pagetree\DataProvider|\PHPUnit_Framework_MockObject_MockObject
         */
        protected $fixture = NULL;
index e4bd916..719f9bc 100644 (file)
@@ -35,13 +35,6 @@ use TYPO3\CMS\Backend\Utility\IconUtility;
 class IconUtilityTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {
 
        /**
-        * Enable backup of global and system variables
-        *
-        * @var boolean
-        */
-       protected $backupGlobals = TRUE;
-
-       /**
         * @var array
         */
        protected $mockRecord;
index 6291c24..4cd6b4b 100644 (file)
@@ -31,13 +31,6 @@ namespace TYPO3\CMS\Core\Tests\Unit\Authentication;
 class AbstractUserAuthenticationTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {
 
        /**
-        * Enable backup of global and system variables
-        *
-        * @var boolean
-        */
-       protected $backupGlobals = TRUE;
-
-       /**
         * phpunit still needs some globals that are
         * reconstructed before $backupGlobals is handled. Those
         * important globals are handled in tearDown() directly.
index be59880..caee5c8 100644 (file)
@@ -36,13 +36,6 @@ class BackendUserAuthenticationTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {
         */
        private $fixture = NULL;
 
-       /**
-        * Enable backup of global and system variables
-        *
-        * @var boolean
-        */
-       protected $backupGlobals = TRUE;
-
        public function setUp() {
                // reset hooks
                $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS'] = array();
index c3d9c32..9bbf741 100644 (file)
@@ -32,13 +32,6 @@ namespace TYPO3\CMS\Core\Tests\Unit\Cache\Backend;
 class DbBackendTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {
 
        /**
-        * Enable backup of global and system variables
-        *
-        * @var boolean
-        */
-       protected $backupGlobals = TRUE;
-
-       /**
         * @var \TYPO3\CMS\Core\Database\DatabaseConnection Backup of original TYPO3_DB instance
         */
        protected $typo3DbBackup;
index b08abf0..5a82a47 100644 (file)
@@ -35,13 +35,6 @@ namespace TYPO3\CMS\Core\Tests\Unit\Cache\Backend;
 class FileBackendTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {
 
        /**
-        * Enable backup of global and system variables
-        *
-        * @var boolean
-        */
-       protected $backupGlobals = TRUE;
-
-       /**
         * Sets up this testcase
         *
         * @return void
index 710f15c..8be008e 100644 (file)
@@ -32,13 +32,6 @@ namespace TYPO3\CMS\Core\Tests\Unit\Cache\Backend;
 class PdoBackendTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {
 
        /**
-        * Enable backup of global and system variables
-        *
-        * @var boolean
-        */
-       protected $backupGlobals = TRUE;
-
-       /**
         * Sets up this testcase
         */
        public function setUp() {
index 5283069..4d88051 100644 (file)
@@ -42,13 +42,6 @@ namespace TYPO3\CMS\Core\Tests\Unit\Cache\Backend;
 class RedisBackendTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {
 
        /**
-        * Enable backup of global and system variables
-        *
-        * @var boolean
-        */
-       protected $backupGlobals = TRUE;
-
-       /**
         * If set, the tearDown() method will flush the cache used by this unit test.
         *
         * @var \TYPO3\CMS\Core\Cache\Backend\RedisBackend
index 52ece7a..dac5f40 100644 (file)
@@ -32,13 +32,6 @@ namespace TYPO3\CMS\Core\Tests\Unit\Category;
 class CategoryRegistryTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {
 
        /**
-        * Enable backup of global and system variables
-        *
-        * @var boolean
-        */
-       protected $backupGlobals = TRUE;
-
-       /**
         * @var \TYPO3\CMS\Core\Category\CategoryRegistry
         */
        protected $fixture;
index 660258e..b585c10 100644 (file)
@@ -34,13 +34,6 @@ namespace TYPO3\CMS\Core\Tests\Unit\Core;
 class SystemEnvironmentBuilderTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {
 
        /**
-        * Enable backup of global and system variables
-        *
-        * @var boolean
-        */
-       protected $backupGlobals = TRUE;
-
-       /**
         * @var \TYPO3\CMS\Core\Core\SystemEnvironmentBuilder|\TYPO3\CMS\Core\Tests\AccessibleObjectInterface
         */
        protected $fixture = NULL;
index 7ee42c0..a79efd4 100644 (file)
@@ -32,13 +32,6 @@ namespace TYPO3\CMS\Core\Tests\Unit\DataHandler;
 class DataHandlerTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {
 
        /**
-        * Enable backup of global and system variables
-        *
-        * @var boolean
-        */
-       protected $backupGlobals = TRUE;
-
-       /**
         * a backup of the global database
         *
         * @var \TYPO3\CMS\Core\Database\DatabaseConnection
index ce0d92f..bed28bd 100644 (file)
@@ -30,12 +30,6 @@ namespace TYPO3\CMS\Core\Tests\Unit\FormProtection;
  * @author Oliver Klee <typo3-coding@oliverklee.de>
  */
 class BackendFormProtectionTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {
-       /**
-        * Enable backup of global and system variables
-        *
-        * @var boolean
-        */
-       protected $backupGlobals = TRUE;
 
        /**
         * @var \TYPO3\CMS\Core\FormProtection\BackendFormProtection
index 20c6594..02c1f84 100644 (file)
@@ -31,13 +31,6 @@ namespace TYPO3\CMS\Core\Tests\Unit\Locking;
  */
 class LockerTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {
 
-       /**
-        * Enable backup of global and system variables
-        *
-        * @var boolean
-        */
-       protected $backupGlobals = TRUE;
-
        ///////////////////////////////
        // tests concerning __construct
        ///////////////////////////////
index d83aefc..cb4de96 100644 (file)
@@ -34,13 +34,6 @@ namespace TYPO3\CMS\Core\Tests\Unit\Log;
 class LogManagerTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {
 
        /**
-        * Enable backup of global and system variables
-        *
-        * @var boolean
-        */
-       protected $backupGlobals = TRUE;
-
-       /**
         * @var \TYPO3\CMS\Core\Log\LogManager
         */
        protected $logManagerInstance = NULL;
index 6995e00..a9ebb26 100644 (file)
@@ -31,13 +31,6 @@ namespace TYPO3\CMS\Core\Tests\Unit\Page;
 class PageRendererTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {
 
        /**
-        * Enable backup of global and system variables
-        *
-        * @var boolean
-        */
-       protected $backupGlobals = TRUE;
-
-       /**
         * @var \TYPO3\CMS\Core\Page\PageRenderer
         */
        private $fixture;
index b4bcb48..db082d0 100644 (file)
@@ -35,11 +35,6 @@ namespace TYPO3\CMS\Core\Tests\Unit\Resource\Driver;
 class DriverRegistryTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {
 
        /**
-        * @var boolean Enable backup of global and system variables
-        */
-       protected $backupGlobals = TRUE;
-
-       /**
         * @var \TYPO3\CMS\Core\Resource\Driver\DriverRegistry
         */
        private $fixture;
index 7be01bd..0fb4993 100644 (file)
@@ -35,11 +35,6 @@ namespace TYPO3\CMS\Core\Tests\Unit\Resource\Service;
 class IndexerServiceTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {
 
        /**
-        * @var boolean Backup all $GLOBALS
-        */
-       protected $backupGlobals = TRUE;
-
-       /**
         * @var Store backup of TYPO3_DB
         */
        protected $dbBackup;
index a637b29..653ff43 100644 (file)
@@ -32,13 +32,6 @@ namespace TYPO3\CMS\Core\Tests\Unit\TypoScript;
 class TemplateServiceTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {
 
        /**
-        * Enable backup of global and system variables
-        *
-        * @var boolean
-        */
-       protected $backupGlobals = TRUE;
-
-       /**
         * @test
         */
        public function versionOlCallsVersionOlOfPageSelectClassWithGivenRow() {
index 135c4fd..d61993c 100644 (file)
@@ -31,11 +31,6 @@ namespace TYPO3\CMS\Core\Tests\Unit\Utility\File;
 class ExtendedFileUtilityTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {
 
        /**
-        * @var boolean Enable backup of global and system variables
-        */
-       protected $backupGlobals = TRUE;
-
-       /**
         * @var array A backup of registered singleton instances
         */
        protected $singletonInstances = array();
index 47a0128..db7a3ec 100644 (file)
@@ -34,13 +34,6 @@ use TYPO3\CMS\Core\Utility;
 class GeneralUtilityTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {
 
        /**
-        * Enable backup of global and system variables
-        *
-        * @var boolean
-        */
-       protected $backupGlobals = TRUE;
-
-       /**
         * Absolute path to files that must be removed
         * after a test - handled in tearDown
         *
index 29213d4..d298d59 100644 (file)
@@ -1175,7 +1175,7 @@ class ContentObjectRendererTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {
         * @dataProvider stdWrap_strftimeReturnsFormattedStringDataProvider
         */
        public function stdWrap_strftimeReturnsFormattedString($content, $conf) {
-                       // Set exec_time to a hard timestamp (backed up by $this->backupGlobals = TRUE)
+                       // Set exec_time to a hard timestamp
                $GLOBALS['EXEC_TIME'] = 1346500800;
                        // Save current timezone and set to UTC to make the system unter test behave
                        // the same in all server timezone settings
index 5310bb6..50cc391 100644 (file)
@@ -31,13 +31,6 @@ namespace TYPO3\CMS\Frontend\Tests\Unit\ContentObject\Menu;
 class AbstractMenuContentObjectTest extends \TYPO3\CMS\Extbase\Tests\Unit\BaseTestCase {
 
        /**
-        * Enable backup of global and system variables
-        *
-        * @var boolean
-        */
-       protected $backupGlobals = TRUE;
-
-       /**
         * A backup of the global database
         *
         * @var \TYPO3\CMS\Core\Database\DatabaseConnection
index 8391fcd..2ea9950 100644 (file)
@@ -30,13 +30,6 @@ namespace TYPO3\CMS\Frontend\Tests\Unit\View;
  */
 class AdminPanelViewTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {
 
-       /**
-        * Enable backup of global and system variables
-        *
-        * @var boolean
-        */
-       protected $backupGlobals = TRUE;
-
        /////////////////////////////////////////////
        // Test concerning extendAdminPanel hook
        /////////////////////////////////////////////
index 1d73492..90c41cf 100644 (file)
@@ -33,13 +33,6 @@ namespace TYPO3\CMS\IndexedSearch\Tests\Unit;
 class IndexerTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {
 
        /**
-        * Enable backup of global and system variables
-        *
-        * @var boolean
-        */
-       protected $backupGlobals = TRUE;
-
-       /**
         * Indexer instance
         *
         * @var \PHPUnit_Framework_MockObject_MockObject|\TYPO3\CMS\IndexedSearch\Indexer
index c284592..9d6aaf7 100644 (file)
@@ -34,11 +34,6 @@ namespace TYPO3\CMS\Install\Tests\Unit;
 class InstallToolTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {
 
        /**
-        * @var boolean Enable backup of global and system variables
-        */
-       protected $backupGlobals = TRUE;
-
-       /**
         * @var boolean True, if a test set a different error handler
         */
        protected $customErrorHandlerUsed = FALSE;
index f3caa72..d40da36 100644 (file)
@@ -35,13 +35,6 @@ namespace TYPO3\CMS\Saltedpasswords\Tests\Unit\Evaluation;
 class EvaluatorTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {
 
        /**
-        * Enable backup of global and system variables
-        *
-        * @var boolean
-        */
-       protected $backupGlobals = TRUE;
-
-       /**
         * @var \TYPO3\CMS\Saltedpasswords\Evaluation\Evaluator
         */
        protected $fixture;
index b95867b..a51c5b8 100644 (file)
@@ -35,13 +35,6 @@ namespace TYPO3\CMS\Saltedpasswords\Tests\Unit\Utility;
 class SaltedPasswordsUtilityTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {
 
        /**
-        * Enable backup of global and system variables
-        *
-        * @var boolean
-        */
-       protected $backupGlobals = TRUE;
-
-       /**
         * @test
         */
        public function doesReturnExtConfReturnDefaultSettingsIfNoExtensionConfigurationIsFound() {
index b8e401d..f94e67c 100644 (file)
@@ -31,13 +31,6 @@ namespace TYPO3\CMS\Scheduler\Tests\Unit\Task;
 class CachingFrameworkGarbageCollectionTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {
 
        /**
-        * Enable backup of global and system variables
-        *
-        * @var boolean
-        */
-       protected $backupGlobals = TRUE;
-
-       /**
         * @test
         */
        public function executeCallsCollectGarbageOfConfiguredBackend() {