[TASK] Make some final classes non-final to allow mocking
authorOliver Klee <typo3-coding@oliverklee.de>
Sat, 28 Jul 2012 20:11:25 +0000 (22:11 +0200)
committerHelmut Hummel <helmut.hummel@typo3.org>
Sat, 28 Jul 2012 21:05:35 +0000 (23:05 +0200)
We need to be able to subclass some classes for the unit tests:

a) classes that need to be used with getMock
b) classes that we subclass to overwrite static methods

Change-Id: Ib31bb18a1d90144699bc9c30311f26a2dbb42a7b
Releases: 6.0
Resolves: #39353
Reviewed-on: http://review.typo3.org/13321
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
t3lib/class.t3lib_befunc.php
t3lib/class.t3lib_iconworks.php
t3lib/class.t3lib_timetrack.php
t3lib/class.t3lib_timetracknull.php

index ab56b48..e66c700 100644 (file)
@@ -37,7 +37,7 @@
  * @package TYPO3
  * @subpackage t3lib
  */
-final class t3lib_BEfunc {
+class t3lib_BEfunc {
 
        /*******************************************
         *
index c50cc80..5689d1a 100644 (file)
@@ -44,7 +44,7 @@
  * @package TYPO3
  * @subpackage t3lib
  */
-final class t3lib_iconWorks {
+class t3lib_iconWorks {
 
        public static $fileSpriteIconNames = array(
                'htm' => 'mimetypes-text-html',
index ebb272a..a8f9dab 100644 (file)
@@ -44,7 +44,7 @@
  * @subpackage t3lib
  * @see t3lib_tsfeBeUserAuth, tslib_fe, tslib_cObj, TSpagegen
  */
-final class t3lib_timeTrack {
+class t3lib_timeTrack {
                // Is loaded with the millisecond time when this object is created
        var $starttime = 0;
 
index ad9326d..4b4ca13 100644 (file)
@@ -31,7 +31,7 @@
  * @package TYPO3
  * @subpackage t3lib
  */
-final class t3lib_TimeTrackNull {
+class t3lib_TimeTrackNull {
        /**
         * "Constructor"
         * Sets the starting time