[TASK] Remove unit tests that do not test the subject 97/59397/2
authorChristian Kuhn <lolli@schwarzbu.ch>
Thu, 10 Jan 2019 11:27:55 +0000 (12:27 +0100)
committerWouter Wolters <typo3@wouterwolters.nl>
Thu, 10 Jan 2019 12:09:04 +0000 (13:09 +0100)
Some tests in FrontendLoginControllerTest test only
GeneralUtility::getIndpEnv(), but not the system under
test FrontendLoginController. Remove those.

Resolves: #87389
Releases: master
Change-Id: I3ea71c15ad8eda16750bfec1367ee4cc439dee2f
Reviewed-on: https://review.typo3.org/59397
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
typo3/sysext/felogin/Tests/Unit/Controller/FrontendLoginControllerTest.php

index a9e6c4b..728bcee 100644 (file)
@@ -76,44 +76,6 @@ class FrontendLoginControllerTest extends UnitTestCase
     }
 
     /**
-     * @test
-     */
-    public function typo3SitePathEqualsStubSitePath()
-    {
-        $this->assertEquals(\TYPO3\CMS\Core\Utility\GeneralUtility::getIndpEnv('TYPO3_SITE_PATH'), $this->testSitePath);
-    }
-
-    /**
-     * @test
-     */
-    public function typo3SiteUrlEqualsStubSiteUrl()
-    {
-        $this->assertEquals(\TYPO3\CMS\Core\Utility\GeneralUtility::getIndpEnv('TYPO3_SITE_URL'), ('http://' . $this->testHostName) . $this->testSitePath);
-    }
-
-    /**
-     * @test
-     */
-    public function typo3SitePathEqualsStubSitePathAfterChangingInTest()
-    {
-        $this->testHostName = 'somenewhostname.com';
-        $this->testSitePath = '/somenewpath/';
-        $this->setUpFakeSitePathAndHost();
-        $this->assertEquals(\TYPO3\CMS\Core\Utility\GeneralUtility::getIndpEnv('TYPO3_SITE_PATH'), $this->testSitePath);
-    }
-
-    /**
-     * @test
-     */
-    public function typo3SiteUrlEqualsStubSiteUrlAfterChangingInTest()
-    {
-        $this->testHostName = 'somenewhostname.com';
-        $this->testSitePath = '/somenewpath/';
-        $this->setUpFakeSitePathAndHost();
-        $this->assertEquals(\TYPO3\CMS\Core\Utility\GeneralUtility::getIndpEnv('TYPO3_SITE_URL'), ('http://' . $this->testHostName) . $this->testSitePath);
-    }
-
-    /**
      * Data provider for validateRedirectUrlClearsUrl
      *
      * @return array