[!!!][TASK] Remove unused configuration options for JavaScript 63/50463/4
authorWouter Wolters <typo3@wouterwolters.nl>
Mon, 31 Oct 2016 20:09:04 +0000 (21:09 +0100)
committerChristian Kuhn <lolli@schwarzbu.ch>
Tue, 1 Nov 2016 10:22:13 +0000 (11:22 +0100)
Remove all options that are not used anymore from TYPO3.configuration
in JavaScript context.

Resolves: #78525
Releases: master
Change-Id: I69ee333e01d75ab4dc14b35f91a172df1ab20d62
Reviewed-on: https://review.typo3.org/50463
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
typo3/sysext/backend/Classes/Controller/BackendController.php
typo3/sysext/backend/Resources/Public/JavaScript/backend.js
typo3/sysext/core/Documentation/Changelog/master/Breaking-78525-RemoveUnusedConfigurationOptionsForJavaScript.rst [new file with mode: 0644]
typo3/sysext/workspaces/Classes/Controller/PreviewController.php

index 312dd3b..070cd4a 100644 (file)
@@ -65,11 +65,6 @@ class BackendController
     protected $toolbarItems = [];
 
     /**
-     * @var int
-     */
-    protected $menuWidth = 190;
-
-    /**
      * @var bool
      */
     protected $debug;
@@ -164,9 +159,6 @@ class BackendController
         $this->css = '';
 
         $this->initializeToolbarItems();
-        if (isset($GLOBALS['TBE_STYLES']['dims']['leftMenuFrameW'])) {
-            $this->menuWidth = (int)$GLOBALS['TBE_STYLES']['dims']['leftMenuFrameW'];
-        }
         $this->executeHook('constructPostProcess');
         $this->includeLegacyBackendItems();
     }
@@ -589,8 +581,6 @@ class BackendController
             'uniqueID' => GeneralUtility::shortMD5(uniqid('', true)),
             'pageModule' => $pageModule,
             'inWorkspace' => $beUser->workspace !== 0,
-            'moduleMenuWidth' => $this->menuWidth - 1,
-            'topBarHeight' => isset($GLOBALS['TBE_STYLES']['dims']['topFrameH']) ? (int)$GLOBALS['TBE_STYLES']['dims']['topFrameH'] : 45,
             'showRefreshLoginPopup' => isset($GLOBALS['TYPO3_CONF_VARS']['BE']['showRefreshLoginPopup']) ? (int)$GLOBALS['TYPO3_CONF_VARS']['BE']['showRefreshLoginPopup'] : false,
             'debugInWindow' => $beUser->uc['debugInWindow'] ? 1 : 0,
             'ContextHelpWindows' => [
index 333cbb0..37f01ec 100644 (file)
@@ -41,12 +41,6 @@ TYPO3 = Ext.apply(TYPO3, {
 });
 
 /**
- * general backend javascript functions
- */
-
-Ext.ns('TYPO3.configuration');
-
-/**
  * jump the backend to a module
  */
 function jump(url, modName, mainModName, pageId) {
diff --git a/typo3/sysext/core/Documentation/Changelog/master/Breaking-78525-RemoveUnusedConfigurationOptionsForJavaScript.rst b/typo3/sysext/core/Documentation/Changelog/master/Breaking-78525-RemoveUnusedConfigurationOptionsForJavaScript.rst
new file mode 100644 (file)
index 0000000..7657f26
--- /dev/null
@@ -0,0 +1,35 @@
+.. include:: ../../Includes.txt
+
+=====================================================================
+Breaking: #78525 - Remove unused configuration options for JavaScript
+=====================================================================
+
+See :issue:`78525`
+
+Description
+===========
+
+Remove all options that are not used anymore from TYPO3.configuration in JavaScript context.
+
+:js:`TYPO3.configuration.moduleMenuWidth`
+:js:`TYPO3.configuration.topBarHeight`
+
+
+Impact
+======
+
+Both settings are not available anymore in JavaScript under :js:`TYPO3.configuration`.
+
+
+Affected Installations
+======================
+
+Any installation that uses one of the mentioned options.
+
+
+Migration
+=========
+
+No migration.
+
+.. index:: Backend, JavaScript
index 7ac2d78..2b36111 100644 (file)
@@ -225,7 +225,6 @@ class PreviewController extends AbstractController
             'uniqueID' => GeneralUtility::shortMD5(uniqid('', true)),
             'pageModule' => $pageModule,
             'inWorkspace' => $backendUser->workspace !== 0,
-            'topBarHeight' => isset($GLOBALS['TBE_STYLES']['dims']['topFrameH']) ? (int)$GLOBALS['TBE_STYLES']['dims']['topFrameH'] : 30,
             'showRefreshLoginPopup' => isset($GLOBALS['TYPO3_CONF_VARS']['BE']['showRefreshLoginPopup']) ? (int)$GLOBALS['TYPO3_CONF_VARS']['BE']['showRefreshLoginPopup'] : false,
             'debugInWindow' => $backendUser->uc['debugInWindow'] ? 1 : 0,
             'ContextHelpWindows' => [