[BUGFIX] Drop unused DataHandler::printLogErrorMessages() argument 78/55078/2
authorMathias Brodala <mbrodala@pagemachine.de>
Thu, 14 Dec 2017 15:33:48 +0000 (16:33 +0100)
committerMarkus Klein <markus.klein@typo3.org>
Thu, 14 Dec 2017 21:12:23 +0000 (22:12 +0100)
The argument can be safely dropped since it is not used in the
method anyways.

Resolves: #83333
Related: #82629
Releases: 8.7
Change-Id: I7ede9c58f454d887d9313163988a50c8b31d9846
Reviewed-on: https://review.typo3.org/55078
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
typo3/sysext/backend/Classes/Controller/EditDocumentController.php
typo3/sysext/backend/Classes/Controller/SimpleDataHandlerController.php
typo3/sysext/core/Classes/DataHandling/DataHandler.php
typo3/sysext/recordlist/Classes/RecordList.php

index d4a6bbd..ece077c 100644 (file)
@@ -689,7 +689,7 @@ class EditDocumentController extends AbstractModule
                 $this->previewData['table'] = $table;
                 $this->previewData['id'] = $id;
             }
-            $tce->printLogErrorMessages(isset($_POST['_saveandclosedok']) || isset($_POST['_translation_savedok']) ? $this->retUrl : $this->R_URL_parts['path'] . '?' . GeneralUtility::implodeArrayForUrl('', $this->R_URL_getvars));
+            $tce->printLogErrorMessages();
         }
         //  || count($tce->substNEWwithIDs)... If any new items has been save, the document is CLOSED
         // because if not, we just get that element re-listed as new. And we don't want that!
index 6cfb136..2bc69e0 100644 (file)
@@ -224,7 +224,7 @@ class SimpleDataHandlerController
 
         // Write errors to flash message queue
         if ($this->prErr) {
-            $this->tce->printLogErrorMessages($this->redirect);
+            $this->tce->printLogErrorMessages();
         }
         if ($this->redirect) {
             $response = $response
@@ -259,7 +259,7 @@ class SimpleDataHandlerController
         // Prints errors (= write them to the message queue)
         if ($this->prErr) {
             $content['hasErrors'] = true;
-            $this->tce->printLogErrorMessages($this->redirect);
+            $this->tce->printLogErrorMessages();
         }
 
         $messages = $flashMessageService->getMessageQueueByIdentifier()->getAllMessagesAndFlush();
index a3a8fd0..2f03162 100644 (file)
@@ -8803,10 +8803,8 @@ class DataHandler
 
     /**
      * Print log error messages from the operations of this script instance
-     *
-     * @param string $redirect Redirect URL (for creating link in message)
      */
-    public function printLogErrorMessages($redirect)
+    public function printLogErrorMessages()
     {
         $queryBuilder = GeneralUtility::makeInstance(ConnectionPool::class)->getQueryBuilderForTable('sys_log');
         $queryBuilder->getRestrictions()->removeAll();
index 7b36444..4faa823 100644 (file)
@@ -381,7 +381,7 @@ class RecordList extends AbstractModule
                     if (isset($cmd['pages'])) {
                         BackendUtility::setUpdateSignal('updatePageTree');
                     }
-                    $tce->printLogErrorMessages(GeneralUtility::getIndpEnv('REQUEST_URI'));
+                    $tce->printLogErrorMessages();
                 }
             }
             // Initialize the listing object, dblist, for rendering the list: