Fixed bug #14317: XSS in Extension Manager (thanks to Georg Ringer)

git-svn-id: https://svn.typo3.org/TYPO3v4/Core/trunk@8354 709f56b5-9817-0410-a4d7-c38de5d9e867

diff --git a/ChangeLog b/ChangeLog
index e23b9a9..0dee93c 100755 (executable)
--- a/ChangeLog
+++ b/ChangeLog
@@ -9,6 +9,7 @@
        * Fixed bug #14850: Information disclosure in t3lib_htmlmail (thanks to Georg Ringer)
        * Fixed bug #13961: XSS in impexp (thanks to Georg Ringer)
        * Fixed bug #13958: XSS in BE Log (thanks to Georg Ringer)
+       * Fixed bug #14317: XSS in Extension Manager (thanks to Georg Ringer)
 
 2010-07-27  Steffen Kamper  <steffen@typo3.org>
 

diff --git a/typo3/sysext/em/mod1/class.em_index.php b/typo3/sysext/em/mod1/class.em_index.php
index 77ca82f..a189556 100644 (file)
--- a/typo3/sysext/em/mod1/class.em_index.php
+++ b/typo3/sysext/em/mod1/class.em_index.php
@@ -2142,7 +2142,7 @@ EXTENSION KEYS:
                        // Function menu here:
                if(!$this->CMD['standAlone'] && !t3lib_div::_GP('standAlone')) {
                        $content = $GLOBALS['LANG']->getLL('ext_details_ext') . '&nbsp;<strong>' .
-                               $this->extensionTitleIconHeader($extKey, $list[$extKey]) . '</strong> (' . $extKey . ')';
+                               $this->extensionTitleIconHeader($extKey, $list[$extKey]) . '</strong> (' . htmlspecialchars($extKey) . ')';
                        $this->content.= $this->doc->section('', $content);
                }
 
@@ -3610,7 +3610,7 @@ EXTENSION KEYS:
                if (is_array($imgInfo)) {
                        $out.= '<img src="'.$GLOBALS['BACK_PATH'].$this->typeRelPaths[$extInfo['type']].$extKey.'/ext_icon.gif" '.$imgInfo[3].' align="'.$align.'" alt="" />';
                }
-               $out.= $extInfo['EM_CONF']['title'] ? htmlspecialchars(t3lib_div::fixed_lgd_cs($extInfo['EM_CONF']['title'],40)) : '<em>'.$extKey.'</em>';
+               $out.= $extInfo['EM_CONF']['title'] ? htmlspecialchars(t3lib_div::fixed_lgd_cs($extInfo['EM_CONF']['title'], 40)) : '<em>' . htmlspecialchars($extKey) . '</em>';
                return $out;
        }