[TASK] Make all classes non final
authorHelmut Hummel <helmut.hummel@typo3.org>
Sat, 22 Sep 2012 09:28:45 +0000 (11:28 +0200)
committerHelmut Hummel <helmut.hummel@typo3.org>
Sat, 22 Sep 2012 09:58:50 +0000 (11:58 +0200)
Defining a class as final does not help and only causes troubles,
especially when creating unit tests, because a final classes
cannot be mocked.

Remove the final statement for all classes to get rid of
these problems.

Change-Id: Icbf574dacd5c3b2bf1de2333a065b0eac838ea98
Resolves: #41235
Releases: 6.0
Reviewed-on: http://review.typo3.org/14905
Reviewed-by: Georg Ringer
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
typo3/sysext/extbase/Classes/Mvc/View/EmptyView.php
typo3/sysext/extbase/Classes/Persistence/Generic/PropertyType.php

index b2f570c..fa8f4b4 100644 (file)
@@ -34,7 +34,7 @@ namespace TYPO3\CMS\Extbase\Mvc\View;
  * @version $Id$
  * @license http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License, version 3 or later
  */
-final class EmptyView implements \TYPO3\CMS\Extbase\Mvc\View\ViewInterface {
+class EmptyView implements \TYPO3\CMS\Extbase\Mvc\View\ViewInterface {
 
        /**
         * Dummy method to satisfy the ViewInterface
index 03d74e5..9f88ea0 100644 (file)
@@ -47,7 +47,7 @@ namespace TYPO3\CMS\Extbase\Persistence\Generic;
  * @subpackage Persistence
  * @version $Id$
  */
-final class PropertyType {
+class PropertyType {
 
        /**
         * This constant can be used within a property definition to specify that