[TASK] Optimize Reports-Module Follow-Up 08/34008/3
authorFrank Nägler <typo3@naegler.net>
Sun, 9 Nov 2014 19:32:11 +0000 (20:32 +0100)
committerFrank Nägler <typo3@naegler.net>
Wed, 12 Nov 2014 17:05:09 +0000 (18:05 +0100)
* Remove old collapse

Resolves: #62668
Releases: master
Change-Id: I8504d93613467e97234f7ff44722f587f221ac3e
Reviewed-on: http://review.typo3.org/34008
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
typo3/sysext/reports/Classes/Report/Status/Status.php
typo3/sysext/reports/Resources/Private/Layouts/Default.html
typo3/sysext/reports/Resources/Public/styles.css [deleted file]

index adade85..98807f3 100644 (file)
@@ -14,6 +14,7 @@ namespace TYPO3\CMS\Reports\Report\Status;
  * The TYPO3 project - inspiring people to share!
  */
 
+use TYPO3\CMS\Backend\Utility\IconUtility;
 use TYPO3\CMS\Reports\ExtendedStatusProviderInterface;
 use TYPO3\CMS\Reports\ReportInterface;
 use TYPO3\CMS\Reports\StatusProviderInterface;
@@ -145,9 +146,10 @@ class Status implements ReportInterface {
                        </tr>
                ';
                $statuses = $this->sortStatusProviders($statusCollection);
+               $id = 0;
                foreach ($statuses as $provider => $providerStatus) {
                        $providerState = $this->sortStatuses($providerStatus);
-                       $id = str_replace(' ', '-', $provider);
+                       $id++;
                        $classes = array(
                                \TYPO3\CMS\Reports\Status::NOTICE => 'notice',
                                \TYPO3\CMS\Reports\Status::INFO => 'info',
@@ -166,8 +168,12 @@ class Status implements ReportInterface {
                                        '###CONTENT###' => $status->getMessage()
                                ));
                        }
-                       $table = '<table class="t3-table"><tbody>' . $messages . '</tbody></table>';
-                       $content .= $GLOBALS['TBE_TEMPLATE']->collapseableSection($provider, $table, $id, 'reports.states');
+                       $header = '<h2>' . $provider . '</h2>';
+                       $table = '<table class="t3-table">';
+                       $table .= '<tbody>' . $messages . '</tbody>';
+                       $table .= '</table>';
+
+                       $content .= $header . $table;
                }
                return $content;
        }
index d76013e..9e3b5a5 100644 (file)
@@ -1,4 +1,4 @@
-<f:be.container includeCssFiles="{0: '{f:uri.resource(path:\'styles.css\')}'}">
+<f:be.container>
        <div class="typo3-fullDoc" id="ext-reports-mod-index-php">
                <div id="typo3-docheader">
                        <div class="typo3-docheader-functions">
diff --git a/typo3/sysext/reports/Resources/Public/styles.css b/typo3/sysext/reports/Resources/Public/styles.css
deleted file mode 100644 (file)
index 14e38e5..0000000
+++ /dev/null
@@ -1,62 +0,0 @@
-body#ext-reports-mod-index-php {
-       margin: 0px;
-}
-
-/* ----- ----- ----- ----- ----- ----- ----- ----- ----- ----- ----- ----- */
-/* status report */
-
-#ext-reports-mod-index-php h2.section-header {
-       margin: 15px 0 10px 0;
-       padding: 2px 0 0 20px;
-       cursor: pointer;
-       clear: left;
-}
-#ext-reports-mod-index-php h2.collapsed {
-       background-image:url(../../../../gfx/arrowright.png);
-       background-repeat:no-repeat;
-}
-#ext-reports-mod-index-php h2.expanded {
-       background-image:url(../../../../gfx/arrowdown.png);
-       background-repeat:no-repeat;
-}
-#ext-reports-mod-index-php h2.section-header img {
-       margin-right:2px;
-       vertical-align:bottom;
-}
-
-#ext-reports-mod-index-php .message-body {
-       clear: left;
-}
-
-#ext-reports-mod-index-php .message-body p {
-       padding: 5px 0;
-}
-
-#ext-reports-mod-index-php .message-body ul {
-       padding-top: 5px;
-       list-style: disc;
-}
-
-#ext-reports-mod-index-php .message-body ol {
-       padding-top: 5px;
-       list-style: decimal;
-}
-
-#ext-reports-mod-index-php .message-left {
-       float: left;
-       width: 400px;
-}
-
-#ext-reports-mod-index-php .message-right {
-       float: left;
-}
-
-.tx_sv_reportlist .typo3-message {
-       padding: 12px !important;
-       padding-left: 36px !important;
-       border: none;
-}
-
-.tx_sv_reportlist p.service-header {
-       margin-top: 0px;
-}
\ No newline at end of file