[BUGFIX] Install tool: Warning in upgrade wizard 16/21516/2
authorChristian Kuhn <lolli@schwarzbu.ch>
Wed, 19 Jun 2013 20:48:23 +0000 (22:48 +0200)
committerChristian Kuhn <lolli@schwarzbu.ch>
Wed, 19 Jun 2013 20:54:48 +0000 (22:54 +0200)
The 'silent' cache framework table upgrade throws a warning that
explode() expects a string but an array is given in
SqlSchemaMigration getStatementArray(). The upgrade wizard uses
a wrong API call, since this method is already called within
getExpectedDatabaseSchema() of the helper class.

Change-Id: I6cdde020265e730faa07a25ebda41917672ccea7
Resolves: #49265
Related: #49162
Releases: 6.2
Reviewed-on: https://review.typo3.org/21516
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
typo3/sysext/install/Classes/Controller/Action/Tool/UpdateWizard.php

index 4bae72e..f9223e7 100644 (file)
@@ -260,14 +260,7 @@ class UpdateWizard extends Action\AbstractAction implements Action\ActionInterfa
 
                /** @var \TYPO3\CMS\Install\Service\SqlExpectedSchemaService $expectedSchemaService */
                $expectedSchemaService = $this->objectManager->get('TYPO3\\CMS\\Install\\Service\\SqlExpectedSchemaService');
-               $expectedCachingFrameworkSchema = $expectedSchemaService->getExpectedDatabaseSchema();
-
-               // Forces creation / update of caching framework tables that are needed by some update wizards
-               $cacheTablesConfiguration = implode(
-                       LF,
-                       $sqlHandler->getStatementArray($expectedCachingFrameworkSchema, 1, '^CREATE TABLE ')
-               );
-               $neededTableDefinition = $sqlHandler->getFieldDefinitions_fileContent($cacheTablesConfiguration);
+               $neededTableDefinition = $expectedSchemaService->getExpectedDatabaseSchema();
                $currentTableDefinition = $sqlHandler->getFieldDefinitions_database();
                $updateTableDefinition = $sqlHandler->getDatabaseExtra($neededTableDefinition, $currentTableDefinition);
                $updateStatements = $sqlHandler->getUpdateSuggestions($updateTableDefinition);