[TASK] Turn todos into @todo to find them easier, Part 2 30/35130/5
authorStefan Neufeind <typo3.neufeind@speedpartner.de>
Mon, 8 Dec 2014 23:11:22 +0000 (00:11 +0100)
committerWouter Wolters <typo3@wouterwolters.nl>
Fri, 12 Dec 2014 20:09:30 +0000 (21:09 +0100)
Change-Id: Iedee934b91eb22f9263de60e0f26c34af61222ec
Resolves: #63619
Releases: master
Reviewed-on: http://review.typo3.org/35130
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
46 files changed:
typo3/sysext/backend/Classes/Form/Element/InlineElement.php
typo3/sysext/backend/Classes/Form/Element/SuggestElement.php
typo3/sysext/backend/Classes/View/ThumbnailView.php
typo3/sysext/core/Build/UnitTestsBootstrap.php
typo3/sysext/core/Classes/Collection/AbstractRecordCollection.php
typo3/sysext/core/Classes/Database/DatabaseConnection.php
typo3/sysext/core/Classes/Html/RteHtmlParser.php
typo3/sysext/core/Classes/Package/Package.php
typo3/sysext/core/Classes/Resource/FileReference.php
typo3/sysext/core/Classes/Resource/Processing/ImageCropScaleMaskTask.php
typo3/sysext/core/Classes/Resource/Processing/ImagePreviewTask.php
typo3/sysext/core/Classes/TypoScript/TemplateService.php
typo3/sysext/core/Classes/Utility/CommandUtility.php
typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php
typo3/sysext/core/Classes/Utility/GeneralUtility.php
typo3/sysext/core/Classes/Utility/PathUtility.php
typo3/sysext/core/Tests/UnitTestCase.php
typo3/sysext/dbal/Classes/Database/AdodbPreparedStatement.php
typo3/sysext/dbal/Classes/Database/DatabaseConnection.php
typo3/sysext/extbase/Classes/Mvc/Controller/Argument.php
typo3/sysext/extbase/Classes/Utility/ExtensionUtility.php
typo3/sysext/extbase/Classes/Validation/Validator/GenericObjectValidator.php
typo3/sysext/extensionmanager/Classes/Utility/Parser/XmlParserFactory.php
typo3/sysext/fluid/Classes/Core/Compiler/TemplateCompiler.php
typo3/sysext/fluid/Classes/Core/Parser/TemplateParser.php
typo3/sysext/fluid/Classes/Core/Widget/WidgetContext.php
typo3/sysext/fluid/Classes/Core/Widget/WidgetRequestBuilder.php
typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormFieldViewHelper.php
typo3/sysext/fluid/Classes/ViewHelpers/Form/SelectViewHelper.php
typo3/sysext/form/Classes/Domain/Factory/JsonToTypoScript.php
typo3/sysext/form/Classes/Domain/Model/Attribute/AcceptAttribute.php
typo3/sysext/form/Classes/Domain/Model/Attribute/AcceptCharsetAttribute.php
typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php
typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php
typo3/sysext/indexed_search/Classes/FileContentParser.php
typo3/sysext/install/Classes/Service/SqlSchemaMigrationService.php
typo3/sysext/linkvalidator/Classes/LinkAnalyzer.php
typo3/sysext/linkvalidator/Classes/Linktype/InternalLinktype.php
typo3/sysext/lowlevel/Classes/LostFilesCommand.php
typo3/sysext/saltedpasswords/Classes/Utility/ExtensionManagerConfigurationUtility.php
typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php
typo3/sysext/scheduler/Classes/Scheduler.php
typo3/sysext/t3skin/Classes/Slot/IconStyleModifier.php
typo3/sysext/version/Classes/Hook/DataHandlerHook.php
typo3/sysext/version/Classes/Task/AutoPublishTask.php
typo3/sysext/workspaces/Classes/Task/AutoPublishTask.php

index 196dcf3..96a499f 100644 (file)
@@ -196,7 +196,7 @@ class InlineElement {
                // We need that pid for ajax calls, so that they would know where the action takes place on the page structure
                if (!isset($this->inlineFirstPid)) {
                        // If this record is not new, try to fetch the inlineView states
-                       // @TODO: Add checking/cleaning for unused tables, records, etc. to save space in uc-field
+                       // @todo Add checking/cleaning for unused tables, records, etc. to save space in uc-field
                        if (MathUtility::canBeInterpretedAsInteger($row['uid'])) {
                                $inlineView = unserialize($GLOBALS['BE_USER']->uc['inlineView']);
                                $this->inlineView = $inlineView[$table][$row['uid']];
@@ -823,7 +823,7 @@ class InlineElement {
                // Using "form_type" locally in this script
                $PA['fieldTSConfig'] = $this->fObj->setTSconfig($foreign_table, array(), $foreign_selector);
                $config = $PA['fieldConf']['config'];
-               //TODO: $disabled is not present - should be read from config?
+               // @todo $disabled is not present - should be read from config?
                $disabled = FALSE;
                if (!$disabled) {
                        // Create option tags:
index 34c54d7..bb9a30b 100644 (file)
@@ -199,7 +199,7 @@ class SuggestElement {
                if (isset($fieldConfig['allowed'])) {
                        if ($fieldConfig['allowed'] === '*') {
                                foreach ($GLOBALS['TCA'] as $tableName => $tableConfig) {
-                                       // TODO: Refactor function to BackendUtility
+                                       // @todo Refactor function to BackendUtility
                                        if (empty($tableConfig['ctrl']['hideTable'])
                                                && ($GLOBALS['BE_USER']->isAdmin()
                                                        || (empty($tableConfig['ctrl']['adminOnly'])
index 1a94032..c5dcf6e 100644 (file)
@@ -106,7 +106,7 @@ class ThumbnailView {
                        /** @var File $filePathOrCombinedFileIdentifier */
                        $fileObject = ResourceFactory::getInstance()->getFileObject($filePathOrCombinedFileIdentifier);
                } elseif (count($parts) <= 1 || !MathUtility::canBeInterpretedAsInteger($parts[0])) {
-                       // TODO: Historically, the input parameter could also be an absolute path. This should be supported again to stay compatible.
+                       // @todo Historically, the input parameter could also be an absolute path. This should be supported again to stay compatible.
                        // We assume the FilePath to be a relative file path (as in backwards compatibility mode)
                        $relativeFilePath = $filePathOrCombinedFileIdentifier;
                        // The incoming relative path is relative to the typo3/ directory, but we need it relative to PATH_site. This is corrected here:
index 8ace966..91a0324 100644 (file)
@@ -69,7 +69,7 @@ unset($webRoot);
 
 /**
  * We need to fake the current script to be the cli dispatcher to satisfy some GeneralUtility::getIndpEnv tests
- * TODO: properly mock these tests
+ * @todo properly mock these tests
  */
 define('PATH_thisScript', PATH_site . 'typo3/cli_dispatch.phpsh');
 $_SERVER['SCRIPT_NAME'] = PATH_thisScript;
@@ -90,7 +90,7 @@ $configurationManager = new \TYPO3\CMS\Core\Configuration\ConfigurationManager()
 $GLOBALS['TYPO3_CONF_VARS'] = $configurationManager->getDefaultConfiguration();
 
 // Avoid failing tests that rely on HTTP_HOST retrieval
-// TODO: Check if we could do better mocking in these tests
+// @todo Check if we could do better mocking in these tests
 $GLOBALS['TYPO3_CONF_VARS']['SYS']['trustedHostsPattern'] = '.*';
 
 \TYPO3\CMS\Core\Core\Bootstrap::getInstance()
index a0bd185..32ddb36 100644 (file)
@@ -257,7 +257,7 @@ abstract class AbstractRecordCollection implements RecordCollectionInterface, Pe
         * @return void
         */
        public function usort($callbackFunction) {
-               // TODO: Implement usort() method with TCEforms in mind
+               // @todo Implement usort() method with TCEforms in mind
                throw new \RuntimeException('This method is not yet supported.', 1322545589);
        }
 
@@ -272,7 +272,7 @@ abstract class AbstractRecordCollection implements RecordCollectionInterface, Pe
         * @return void
         */
        public function moveItemAt($currentPosition, $newPosition = 0) {
-               // TODO: Implement usort() method with TCEforms in mind
+               // @todo Implement usort() method with TCEforms in mind
                throw new \RuntimeException('This method is not yet supported.', 1322545626);
        }
 
index 72c9275..660b2a6 100644 (file)
@@ -1211,7 +1211,7 @@ class DatabaseConnection {
                        $this->setSqlMode();
                        $this->checkConnectionCharset();
                } else {
-                       // @TODO: This should raise an exception. Would be useful especially to work during installation.
+                       // @todo This should raise an exception. Would be useful especially to work during installation.
                        $error_msg = $this->link->connect_error;
                        $this->link = NULL;
                        GeneralUtility::sysLog(
@@ -1771,7 +1771,7 @@ class DatabaseConnection {
         * If $this->explainOutput is set, SELECT queries will be explained here. Only queries with more than one possible result row will be displayed.
         * The output is either printed as raw HTML output or embedded into the TS admin panel (checkbox must be enabled!)
         *
-        * TODO: Feature is not DBAL-compliant
+        * @todo Feature is not DBAL-compliant
         *
         * @param string $query SQL query
         * @param string $from_table Table(s) from which to select. This is what comes right after "FROM ...". Required value.
index d561437..75ff83d 100644 (file)
@@ -468,7 +468,7 @@ class RteHtmlParser extends \TYPO3\CMS\Core\Html\HtmlParser {
                                                                if ($fileOrFolderObject instanceof Resource\FileInterface) {
                                                                        $fileIdentifier = $fileOrFolderObject->getIdentifier();
                                                                        $fileObject = $fileOrFolderObject->getStorage()->getFile($fileIdentifier);
-                                                                       // TODO: if the retrieved file is a processed file, get the original file...
+                                                                       // @todo if the retrieved file is a processed file, get the original file...
                                                                        $attribArray['data-htmlarea-file-uid'] = $fileObject->getUid();
                                                                }
                                                        } catch (Resource\Exception\ResourceDoesNotExistException $resourceDoesNotExistException) {
index 00096e7..5715f27 100644 (file)
@@ -166,7 +166,7 @@ class Package extends \TYPO3\Flow\Package\Package implements PackageInterface {
                                        if (!empty($requiredPackageKey)) {
                                                $composerManifest->require->$requiredPackageKey = $requiredPackageVersion;
                                        } else {
-                                               // TODO: throw meaningful exception or fail silently?
+                                               // @todo throw meaningful exception or fail silently?
                                        }
                                }
                        }
@@ -176,7 +176,7 @@ class Package extends \TYPO3\Flow\Package\Package implements PackageInterface {
                                        if (!empty($conflictingPackageKey)) {
                                                $composerManifest->conflict->$conflictingPackageKey = $conflictingPackageVersion;
                                        } else {
-                                               // TODO: throw meaningful exception or fail silently?
+                                               // @todo throw meaningful exception or fail silently?
                                        }
                                }
                        }
@@ -186,7 +186,7 @@ class Package extends \TYPO3\Flow\Package\Package implements PackageInterface {
                                        if (!empty($suggestedPackageKey)) {
                                                $composerManifest->suggest->$suggestedPackageKey = $suggestedPackageVersion;
                                        } else {
-                                               // TODO: throw meaningful exception or fail silently?
+                                               // @todo throw meaningful exception or fail silently?
                                        }
                                }
                        }
index 367187e..02c915a 100644 (file)
@@ -191,7 +191,7 @@ class FileReference implements FileInterface {
        /**
         * Returns the title text to this image
         *
-        * TODO: Possibly move this to the image domain object instead
+        * @todo Possibly move this to the image domain object instead
         *
         * @return string
         */
@@ -202,7 +202,7 @@ class FileReference implements FileInterface {
        /**
         * Returns the alternative text to this image
         *
-        * TODO: Possibly move this to the image domain object instead
+        * @todo Possibly move this to the image domain object instead
         *
         * @return string
         */
@@ -213,7 +213,7 @@ class FileReference implements FileInterface {
        /**
         * Returns the description text to this file
         *
-        * TODO: Possibly move this to the image domain object instead
+        * @todo Possibly move this to the image domain object instead
         *
         * @return string
         */
@@ -224,7 +224,7 @@ class FileReference implements FileInterface {
        /**
         * Returns the link that should be active when clicking on this image
         *
-        * TODO: Move this to the image domain object instead
+        * @todo Move this to the image domain object instead
         *
         * @return string
         */
@@ -382,7 +382,7 @@ class FileReference implements FileInterface {
         * @return bool TRUE if deletion succeeded
         */
        public function delete() {
-               // TODO: Implement this function. This should only delete the
+               // @todo Implement this function. This should only delete the
                // FileReference (sys_file_reference) record, not the file itself.
                throw new \BadMethodCallException('Function not implemented FileReference::delete().', 1333754461);
                //return $this->fileRepository->removeUsageRecord($this);
@@ -392,12 +392,11 @@ class FileReference implements FileInterface {
         * Renames the fileName in this particular usage.
         *
         * @param string $newName The new name
-        *
         * @throws \BadMethodCallException
         * @return FileReference
         */
        public function rename($newName) {
-               // TODO: Implement this function. This should only rename the
+               // @todo Implement this function. This should only rename the
                // FileReference (sys_file_reference) record, not the file itself.
                throw new \BadMethodCallException('Function not implemented FileReference::rename().', 1333754473);
                //return $this->fileRepository->renameUsageRecord($this, $newName);
index d27bf5c..16c06b5 100644 (file)
@@ -46,10 +46,10 @@ class ImageCropScaleMaskTask extends AbstractGraphicalTask {
         * @return bool
         */
        protected function isValidConfiguration(array $configuration) {
-               // TODO: Implement isValidConfiguration() method.
+               // @todo Implement isValidConfiguration() method.
        }
 
        public function fileNeedsProcessing() {
-               // TODO: Implement fileNeedsProcessing() method.
+               // @todo Implement fileNeedsProcessing() method.
        }
 }
index 10d34c2..8ca7f36 100644 (file)
@@ -58,12 +58,13 @@ class ImagePreviewTask extends AbstractGraphicalTask {
         * Returns TRUE if the file has to be processed at all, such as e.g. the original file does.
         *
         * Note: This does not indicate if the concrete ProcessedFile attached to this task has to be (re)processed.
-        * This check is done in ProcessedFile::isOutdated(). @todo isOutdated()/needsReprocessing()?
+        * This check is done in ProcessedFile::isOutdated().
+        * @todo isOutdated()/needsReprocessing()?
         *
         * @return bool
         */
        public function fileNeedsProcessing() {
-               // TODO: Implement fileNeedsProcessing() method.
+               // @todo Implement fileNeedsProcessing() method.
 
                /**
                 * Checks to perform:
index 924d191..8c29cda 100644 (file)
@@ -462,7 +462,7 @@ class TemplateService {
                        if (is_array($cc)) {
                                // If currentPageData was actually there, we match the result (if this wasn't done already in $TSFE->getFromCache()...)
                                if (!$cc['match']) {
-                                       // TODO: check if this can ever be the case - otherwise remove
+                                       // @todo check if this can ever be the case - otherwise remove
                                        $cc = $this->matching($cc);
                                        ksort($cc);
                                }
@@ -821,7 +821,7 @@ class TemplateService {
        public function addExtensionStatics($idList, $templateID, $pid, $row) {
                $this->extensionStaticsProcessed = TRUE;
 
-               // @TODO: Change to use new API
+               // @todo Change to use new API
                foreach ($GLOBALS['TYPO3_LOADED_EXT'] as $extKey => $files) {
                        if ((is_array($files) || $files instanceof \ArrayAccess) && ($files['ext_typoscript_constants.txt'] || $files['ext_typoscript_setup.txt'])) {
                                $mExtKey = str_replace('_', '', $extKey);
index 01e06e5..252e512 100644 (file)
@@ -389,7 +389,7 @@ class CommandUtility {
                }
 
                        // Add path from environment
-                       // TODO: how does this work for WIN
+                       // @todo how does this work for WIN
                if ($GLOBALS['_SERVER']['PATH']) {
                        $sep = (TYPO3_OS == 'WIN' ? ';' : ':');
                        $envPath = GeneralUtility::trimExplode($sep, $GLOBALS['_SERVER']['PATH'], TRUE);
index 089103a..964fe0a 100644 (file)
@@ -39,7 +39,7 @@ class ExtensionManagementUtility {
         * the access to the cache file to read the single ext_tables.php if it was
         * already read from cache
         *
-        * @TODO : See if we can get rid of the 'load multiple times' scenario in fe
+        * @todo See if we can get rid of the 'load multiple times' scenario in fe
         * @var bool
         */
        static protected $extTablesWasReadFromCacheOnce = FALSE;
@@ -794,7 +794,7 @@ class ExtensionManagementUtility {
                        list($extensionKey, $relativePath) = explode('/', substr($iconPathAndFilename, 4), 2);
                        $iconPathAndFilename = self::extPath($extensionKey) . $relativePath;
                }
-               // TODO: skin support
+               // @todo skin support
                $moduleLabels = array(
                        'tabs_images' => array(
                                'tab' => $iconPathAndFilename
index 67f8f6e..d740eae 100755 (executable)
@@ -1115,8 +1115,8 @@ class GeneralUtility {
         * errors. This function will return TRUE if current mail sending method has
         * problem with recipient name in recipient/sender argument for mail().
         *
-        * TODO: 4.3 should have additional configuration variable, which is combined
-        * by || with the rest in this function.
+        * @todo 4.3 should have additional configuration variable, which is combined
+        *   by || with the rest in this function.
         *
         * @return bool TRUE if mail() does not accept recipient name
         */
@@ -4279,7 +4279,7 @@ Connection: close
         * Just prefix the function call with "&": "$objRef = &\TYPO3\CMS\Core\Utility\GeneralUtility::getUserObj('EXT:myext/class.tx_myext_myclass.php:&tx_myext_myclass');".
         * This will work ONLY if you prefix the class name with "&" as well. See description of function arguments.
         *
-        * @TODO : Deprecate the whole method in several steps:
+        * @todo Deprecate the whole method in several steps:
         *      1. Deprecated singleton pattern,
         *      2. Deprecate file prefix/ require file,
         *      3. Deprecate usage without valid class name.
index c0d3bfa..335ce54 100644 (file)
@@ -244,7 +244,7 @@ class PathUtility {
                // Replace backslashes with slashes to work with Windows paths if given
                $path = trim(str_replace('\\', '/', $path));
 
-               // TODO: do we really need this? Probably only in testing context for vfs?
+               // @todo do we really need this? Probably only in testing context for vfs?
                $protocol = '';
                if (strpos($path, '://') !== FALSE) {
                        list($protocol, $path) = explode('://', $path);
index b0c2abe..26f933c 100644 (file)
@@ -29,7 +29,7 @@ use TYPO3\CMS\Core\Utility\StringUtility;
 abstract class UnitTestCase extends BaseTestCase {
 
        /**
-        * TODO: make LoadedExtensionsArray serializable instead
+        * @todo make LoadedExtensionsArray serializable instead
         *
         * @var array
         */
index 566b942..47c4e1e 100644 (file)
@@ -71,7 +71,7 @@ class AdodbPreparedStatement extends \TYPO3\CMS\Dbal\Database\DatabaseConnection
         * @return bool TRUE on success or FALSE on failure
         */
        public function prepare() {
-               // TODO: actually prepare the query with ADOdb, if supported by the underlying DBMS
+               // @todo actually prepare the query with ADOdb, if supported by the underlying DBMS
                // see: http://phplens.com/lens/adodb/docs-adodb.htm#prepare
                return TRUE;
        }
index 683803b..8a29b98 100644 (file)
@@ -3056,8 +3056,6 @@ class DatabaseConnection extends \TYPO3\CMS\Core\Database\DatabaseConnection {
                                                $this->checkConnectionCharset();
                                        }
 
-                                       // TODO:
-
                                        $output = TRUE;
                                } else {
                                        GeneralUtility::sysLog('Could not connect to MySQL server ' . $cfgArray['config']['host'] . ' with user ' . $cfgArray['config']['username'] . '.', 'Core', 4);
index 1d259a7..c74a165 100644 (file)
@@ -240,7 +240,7 @@ class Argument {
                $this->value = $this->propertyMapper->convert($rawValue, $this->dataType, $this->propertyMappingConfiguration);
                $this->validationResults = $this->propertyMapper->getMessages();
                if ($this->validator !== NULL) {
-                       // TODO: Validation API has also changed!!!
+                       // @todo Validation API has also changed!!!
                        $validationMessages = $this->validator->validate($this->value);
                        $this->validationResults->merge($validationMessages);
                }
index 8c0fa62..b4e9758 100644 (file)
@@ -157,7 +157,7 @@ tt_content.' . $pluginSignature . ' {
                        list($extensionKey, $relativePath) = explode('/', substr($iconPathAndFilename, 4), 2);
                        $iconPathAndFilename = \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::extPath($extensionKey) . $relativePath;
                }
-               // TODO: skin support
+               // @todo skin support
                $moduleLabels = array(
                        'tabs_images' => array(
                                'tab' => $iconPathAndFilename
index 6a98d0a..1f76211 100644 (file)
@@ -56,7 +56,7 @@ class GenericObjectValidator extends AbstractValidator implements ObjectValidato
         * @return mixed
         */
        protected function getPropertyValue($object, $propertyName) {
-               // TODO: add support for lazy loading proxies, if needed
+               // @todo add support for lazy loading proxies, if needed
                if (ObjectAccess::isPropertyGettable($object, $propertyName)) {
                        return ObjectAccess::getProperty($object, $propertyName);
                } else {
index c6f1e90..f4b0f0f 100644 (file)
@@ -33,10 +33,8 @@ class XmlParserFactory {
        /**
         * Keeps array of all available parsers.
         *
-        * TODO: This would better be moved to
-        * a global configuration array like
-        * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS'].
-        * (might require EM to be moved in a sysext)
+        * @todo This would better be moved to a global configuration array like
+        * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']. (might require EM to be moved in a sysext)
         *
         * @var array
         */
index 90708a8..90c9d59 100644 (file)
@@ -73,7 +73,7 @@ class TemplateCompiler implements \TYPO3\CMS\Core\SingletonInterface {
 
                if ($parsingState->getVariableContainer()->exists('sections')) {
                        $sections = $parsingState->getVariableContainer()->get('sections');
-                       // TODO: refactor to $parsedTemplate->getSections()
+                       // @todo refactor to $parsedTemplate->getSections()
                        foreach ($sections as $sectionName => $sectionRootNode) {
                                $generatedRenderFunctions .= $this->generateCodeForSection($this->convertListOfSubNodes($sectionRootNode), 'section_' . sha1($sectionName), 'section ' . $sectionName);
                        }
index 285038e..7bf7b8f 100644 (file)
@@ -689,7 +689,7 @@ class TemplateParser {
                        // $this->configuration is UNSET inside the arguments of a ViewHelper.
                        // That's why the interceptors are only called if the object accesor is not inside a ViewHelper Argument
                        // This could be a problem if We have a ViewHelper as an argument to another ViewHelper, and an ObjectAccessor nested inside there.
-                       // TODO: Clean up this.
+                       // @todo Clean up this.
                        $interceptors = $this->configuration->getInterceptors($interceptionPoint);
                        if (count($interceptors) > 0) {
                                foreach ($interceptors as $interceptor) {
index b7136b2..37108f6 100644 (file)
@@ -74,7 +74,7 @@ class WidgetContext {
        /**
         * The rendering context of the ViewHelperChildNodes.
         * Only available inside non-AJAX requests.
-        * TODO: rename to something more meaningful.
+        * @todo rename to something more meaningful.
         *
         * @var \TYPO3\CMS\Fluid\Core\Rendering\RenderingContextInterface
         * @transient
index 66761f2..4869db1 100644 (file)
@@ -54,7 +54,7 @@ class WidgetRequestBuilder extends \TYPO3\CMS\Extbase\Mvc\Web\RequestBuilder {
                        $request->setArguments(\TYPO3\CMS\Core\Utility\GeneralUtility::_GET());
                }
                $rawGetArguments = \TYPO3\CMS\Core\Utility\GeneralUtility::_GET();
-               // TODO: rename to @action, to be consistent with normal naming?
+               // @todo rename to @action, to be consistent with normal naming?
                if (isset($rawGetArguments['action'])) {
                        $request->setControllerActionName($rawGetArguments['action']);
                }
index af42432..72b5fd9 100644 (file)
@@ -95,7 +95,7 @@ abstract class AbstractFormFieldViewHelper extends AbstractFormViewHelper {
                        $name = $this->arguments['name'];
                }
                if ($this->hasArgument('value') && is_object($this->arguments['value'])) {
-                       // TODO: Use  $this->persistenceManager->isNewObject() once it is implemented
+                       // @todo Use  $this->persistenceManager->isNewObject() once it is implemented
                        if (NULL !== $this->persistenceManager->getIdentifierByObject($this->arguments['value'])) {
                                $name .= '[__identity]';
                        }
index 6ff7c2a..5879edd 100644 (file)
@@ -165,7 +165,7 @@ class SelectViewHelper extends \TYPO3\CMS\Fluid\ViewHelpers\Form\AbstractFormFie
                                                        throw new \TYPO3\CMS\Fluid\Core\ViewHelper\Exception('Identifying value for object of class "' . get_class($value) . '" was an object.', 1247827428);
                                                }
                                        }
-                               // TODO: use $this->persistenceManager->isNewObject() once it is implemented
+                               // @todo use $this->persistenceManager->isNewObject() once it is implemented
                                } elseif ($this->persistenceManager->getIdentifierByObject($value) !== NULL) {
                                        $key = $this->persistenceManager->getIdentifierByObject($value);
                                } elseif (method_exists($value, '__toString')) {
@@ -184,7 +184,7 @@ class SelectViewHelper extends \TYPO3\CMS\Fluid\ViewHelpers\Form\AbstractFormFie
                                        }
                                } elseif (method_exists($value, '__toString')) {
                                        $value = (string)$value;
-                               // TODO: use $this->persistenceManager->isNewObject() once it is implemented
+                               // @todo use $this->persistenceManager->isNewObject() once it is implemented
                                } elseif ($this->persistenceManager->getIdentifierByObject($value) !== NULL) {
                                        $value = $this->persistenceManager->getIdentifierByObject($value);
                                }
@@ -246,7 +246,7 @@ class SelectViewHelper extends \TYPO3\CMS\Fluid\ViewHelpers\Form\AbstractFormFie
                        if ($this->hasArgument('optionValueField')) {
                                return \TYPO3\CMS\Extbase\Reflection\ObjectAccess::getPropertyPath($valueElement, $this->arguments['optionValueField']);
                        } else {
-                               // TODO: use $this->persistenceManager->isNewObject() once it is implemented
+                               // @todo use $this->persistenceManager->isNewObject() once it is implemented
                                if ($this->persistenceManager->getIdentifierByObject($valueElement) !== NULL) {
                                        return $this->persistenceManager->getIdentifierByObject($valueElement);
                                } else {
index 037451f..eb8d0ec 100644 (file)
@@ -164,7 +164,7 @@ class JsonToTypoScript {
         * @return void
         */
        protected function getForm(array $element, array &$parent, $elementCounter) {
-               // TODO: Put at the top of the form
+               // @todo Put at the top of the form
                if (!empty($this->validationRules)) {
                        $parent[$elementCounter . '.']['rules'] = $this->validationRules;
                }
index 5e74eb4..3090c4b 100644 (file)
@@ -32,7 +32,7 @@ class AcceptAttribute extends \TYPO3\CMS\Form\Domain\Model\Attribute\AbstractAtt
         * when prompting a user to select files to be sent to the server (cf. the INPUT element when type="file").
         * RFC2045: For a complete list, see http://www.iana.org/assignments/media-types/
         *
-        * TODO: Perhaps we once can add a list of all content-types to TYPO3
+        * @todo Perhaps we once can add a list of all content-types to TYPO3
         *
         * @return string Attribute value
         */
index ff80795..6019568 100644 (file)
@@ -38,7 +38,7 @@ class AcceptCharsetAttribute extends \TYPO3\CMS\Form\Domain\Model\Attribute\Abst
         *
         * RFC2045: For a complete list, see http://www.iana.org/assignments/character-sets/
         *
-        * TODO: Perhaps we once can add a list of all character-sets to TYPO3
+        * @todo Perhaps we once can add a list of all character-sets to TYPO3
         *
         * @return string Attribute value
         */
index 6b4f46c..1efa535 100644 (file)
@@ -5647,7 +5647,7 @@ class ContentObjectRenderer {
                                        return $fileObject->getProperty($requestedFileInformationKey);
                        }
                } else {
-                       // TODO: fail silently as is common in tslib_content
+                       // @todo fail silently as is common in tslib_content
                        return 'Error: no file object';
                }
        }
@@ -7125,7 +7125,7 @@ class ContentObjectRenderer {
         * @param array $config TypoScript configuration (naturally of a USER or COA cObject)
         * @return bool Whether the class is available
         * @link http://forge.typo3.org/issues/19510
-        * @TODO This method was introduced in TYPO3 4.3 and can be removed if the autoload was integrated
+        * @todo This method was introduced in TYPO3 4.3 and can be removed if the autoload was integrated
         */
        protected function isClassAvailable($className, array $config = NULL) {
                if (class_exists($className)) {
index cb81428..5c9a4c5 100644 (file)
@@ -1125,9 +1125,9 @@ class TypoScriptFrontendController {
                if ($_COOKIE[\TYPO3\CMS\Core\Authentication\BackendUserAuthentication::getCookieName()]) {
                        $GLOBALS['TYPO3_MISC']['microtime_BE_USER_start'] = microtime(TRUE);
                        $GLOBALS['TT']->push('Back End user initialized', '');
-                       // TODO: validate the comment below: is this necessary? if so,
-                       // formfield_status should be set to "" in \TYPO3\CMS\Backend\FrontendBackendUserAuthentication
-                       // which is a subclass of \TYPO3\CMS\Core\Authentication\BackendUserAuthentication
+                       // @todo validate the comment below: is this necessary? if so,
+                       //   formfield_status should be set to "" in \TYPO3\CMS\Backend\FrontendBackendUserAuthentication
+                       //   which is a subclass of \TYPO3\CMS\Core\Authentication\BackendUserAuthentication
                        // ----
                        // the value this->formfield_status is set to empty in order to
                        // disable login-attempts to the backend account through this script
index 6c7139a..e80e03c 100644 (file)
@@ -558,7 +558,7 @@ class FileContentParser {
                                $this->setLocaleForServerFileSystem();
                                // Raw text
                                $content = \TYPO3\CMS\Core\Utility\GeneralUtility::getUrl($absFile);
-                               // TODO: Implement auto detection of charset (currently assuming utf-8)
+                               // @todo Implement auto detection of charset (currently assuming utf-8)
                                $contentCharset = 'utf-8';
                                $content = $this->pObj->convertHTMLToUtf8($content, $contentCharset);
                                $contentArr = $this->pObj->splitRegularContent($content);
index 536b15f..19044c1 100644 (file)
@@ -260,7 +260,7 @@ class SqlSchemaMigrationService {
                                                                foreach ($info[$theKey] as $fieldN => $fieldC) {
                                                                        $fieldN = str_replace('`', '', $fieldN);
                                                                        if ($fieldN == 'COLLATE') {
-                                                                               // TODO: collation support is currently disabled (needs more testing)
+                                                                               // @todo collation support is currently disabled (needs more testing)
                                                                                continue;
                                                                        }
                                                                        if (!isset($FDcomp[$table][$theKey][$fieldN])) {
@@ -449,7 +449,8 @@ class SqlSchemaMigrationService {
                                                        if ($info['extra']) {
                                                                foreach ($info['extra'] as $k => $v) {
                                                                        if ($k == 'COLLATE' || $k == 'CLEAR') {
-                                                                               // Skip these special statements. TODO: collation support is currently disabled (needs more testing)
+                                                                               // Skip these special statements.
+                                                                               // @todo collation support is currently disabled (needs more testing)
                                                                                continue;
                                                                        }
                                                                        // Add extra attributes like ENGINE, CHARSET, etc.
index ad43531..2ac36ee 100644 (file)
@@ -157,7 +157,7 @@ class LinkAnalyzer {
                                // Re-init selectFields for table
                                $selectFields = 'uid, pid';
                                $selectFields .= ', ' . $GLOBALS['TCA'][$table]['ctrl']['label'] . ', ' . implode(', ', $fields);
-                               // TODO: only select rows that have content in at least one of the relevant fields (via OR)
+                               // @todo only select rows that have content in at least one of the relevant fields (via OR)
                                $res = $GLOBALS['TYPO3_DB']->exec_SELECTquery($selectFields, $table, $where);
                                // Get record rows of table
                                while (($row = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($res)) !== FALSE) {
index f692d2b..f6ab96c 100644 (file)
@@ -78,7 +78,7 @@ class InternalLinktype extends \TYPO3\CMS\Linkvalidator\Linktype\AbstractLinktyp
                unset($this->errorParams);
                // Ignore FAL file references
                if (substr($url, 0, 5) === 'file:') {
-                       // TODO: validate this resource file
+                       // @todo validate this resource file
                        return TRUE;
                }
                // Defines the linked page and anchor (if any).
index 8ead0a5..51de9f2 100644 (file)
@@ -59,9 +59,9 @@ Will report lost files.';
         * Find lost files in uploads/ folder
         * FIX METHOD: Simply delete the file...
         *
-        * TODO: Add parameter to exclude filepath
-        * TODO: Add parameter to list more file names/patterns to ignore
-        * TODO: Add parameter to include RTEmagic images
+        * @todo Add parameter to exclude filepath
+        * @todo Add parameter to list more file names/patterns to ignore
+        * @todo Add parameter to include RTEmagic images
         *
         * @return array
         */
index 5185a5b..3774c4e 100644 (file)
@@ -80,7 +80,7 @@ class ExtensionManagerConfigurationUtility {
                                }
                                break;
                        case 'ok':
-                               // TODO: Remove INFO condition as it has lower importance
+                               // @todo Remove INFO condition as it has lower importance
                                if ($this->errorType < FlashMessage::WARNING && $this->errorType != FlashMessage::INFO) {
                                        $this->errorType = FlashMessage::OK;
                                        $this->header = 'No errors were found';
@@ -442,14 +442,14 @@ class ExtensionManagerConfigurationUtility {
         */
        protected function processPostData(array $postArray = array()) {
                foreach ($postArray as $key => $value) {
-                       // TODO: Explain
+                       // @todo Explain
                        $parts = explode('.', $key, 2);
                        if (count($parts) == 2) {
-                               // TODO: Explain
+                               // @todo Explain
                                $value = $this->processPostData(array($parts[1] => $value));
                                $postArray[$parts[0] . '.'] = array_merge((array)$postArray[($parts[0] . '.')], $value);
                        } else {
-                               // TODO: Explain
+                               // @todo Explain
                                $postArray[$parts[0]] = $value;
                        }
                }
index a04fe0b..61d9c80 100644 (file)
@@ -239,7 +239,7 @@ class SchedulerModuleController extends \TYPO3\CMS\Backend\Module\BaseScriptClas
 
                        // Setup check screen
                        case 'check':
-                               // TODO: move check to the report module
+                               // @todo move check to the report module
                                $content .= $this->checkScreenAction();
                                break;
 
@@ -476,7 +476,7 @@ class SchedulerModuleController extends \TYPO3\CMS\Backend\Module\BaseScriptClas
         * Clears the registered running executions from the task
         * Note that this doesn't actually stop the running script. It just unmarks
         * all executions.
-        * TODO: find a way to really kill the running task
+        * @todo find a way to really kill the running task
         *
         * @return void
         */
index ac63708..e161e09 100644 (file)
@@ -78,7 +78,7 @@ class Scheduler implements \TYPO3\CMS\Core\SingletonInterface {
 
        /**
         * Cleans the execution lists of the scheduled tasks, executions older than 24h are removed
-        * TODO: find a way to actually kill the job
+        * @todo find a way to actually kill the job
         *
         * @return void
         */
@@ -186,7 +186,7 @@ class Scheduler implements \TYPO3\CMS\Core\SingletonInterface {
 
        /**
         * Removes a task completely from the system.
-        * TODO: find a way to actually kill the existing jobs
+        * @todo find a way to actually kill the existing jobs
         *
         * @param \TYPO3\CMS\Scheduler\Task\AbstractTask $task The object representing the task to delete
         * @return bool TRUE if task was successfully deleted, FALSE otherwise
index 85fc65d..2652b64 100644 (file)
@@ -50,14 +50,14 @@ class IconStyleModifier {
                't3-icon t3-icon-actions t3-icon-actions-edit t3-icon-edit-unhide' => 'fa-toggle-off warning',
                't3-icon t3-icon-actions t3-icon-actions-edit t3-icon-edit-upload' => 'fa-upload',
                't3-icon t3-icon-actions t3-icon-actions-input t3-icon-input-clear' => 'fa-times-circle',
-               // TODO: t3-btn-* is still used in FormEngine.js refactor to use data attributes in HTML
+               // @todo t3-btn-* is still used in FormEngine.js refactor to use data attributes in HTML
                't3-icon t3-icon-actions t3-icon-actions-move t3-icon-move-down t3-btn t3-btn-moveoption-down' => 'fa-angle-down t3-btn t3-btn-moveoption-down',
                't3-icon t3-icon-actions t3-icon-actions-move t3-icon-move-to-bottom t3-btn t3-btn-moveoption-bottom' => 'fa-angle-double-down t3-btn t3-btn-moveoption-bottom',
                't3-icon t3-icon-actions t3-icon-actions-move t3-icon-move-to-bottom' => 'fa-angle-double-down',
                't3-icon t3-icon-actions t3-icon-actions-move t3-icon-move-down' => 'fa-angle-down',
                't3-icon t3-icon-actions t3-icon-actions-move t3-icon-move-left' => 'fa-angle-left',
                't3-icon t3-icon-actions t3-icon-actions-move t3-icon-move-right' => 'fa-angle-right',
-               // TODO: t3-btn-* is still used in FormEngine.js refactor to use data attributes in HTML
+               // @todo t3-btn-* is still used in FormEngine.js refactor to use data attributes in HTML
                't3-icon t3-icon-actions t3-icon-actions-move t3-icon-move-to-top' => 'fa-angle-double-up',
                't3-icon t3-icon-actions t3-icon-actions-move t3-icon-move-to-top t3-btn t3-btn-moveoption-top' => 'fa-angle-double-up t3-btn t3-btn-moveoption-top',
                't3-icon t3-icon-actions t3-icon-actions-move t3-icon-move-up t3-btn t3-btn-moveoption-up' => 'fa-angle-up t3-btn t3-btn-moveoption-up',
@@ -65,7 +65,7 @@ class IconStyleModifier {
                't3-icon t3-icon-actions t3-icon-actions-page t3-icon-page-move' => 'fa-arrows',
                't3-icon t3-icon-actions t3-icon-actions-page t3-icon-page-new' => 'fa-plus-square',
                't3-icon t3-icon-actions t3-icon-actions-page t3-icon-page-open' => 'fa-pencil',
-               // TODO: t3-btn-* is still used in FormEngine.js refactor to use data attributes in HTML
+               // @todo t3-btn-* is still used in FormEngine.js refactor to use data attributes in HTML
                't3-icon t3-icon-actions t3-icon-actions-selection t3-icon-selection-delete t3-btn t3-btn-removeoption' => 'fa-times t3-btn t3-btn-removeoption',
                't3-icon t3-icon-actions t3-icon-actions-selection t3-icon-selection-delete' => 'fa-remove',
                't3-icon t3-icon-actions t3-icon-actions-system t3-icon-system-backend-user-emulate' => 'fa-sign-in',
index a2a3e9b..247c87e 100644 (file)
@@ -424,8 +424,8 @@ class DataHandlerHook {
                                $stageService = GeneralUtility::makeInstance(\TYPO3\CMS\Workspaces\Service\StagesService::class);
                                $newStage = $stageService->getStageTitle((int)$stageId);
                        } else {
-                               // TODO: CONSTANTS SHOULD BE USED - tx_service_workspace_workspaces
-                               // TODO: use localized labels
+                               // @todo CONSTANTS SHOULD BE USED - tx_service_workspace_workspaces
+                               // @todo use localized labels
                                // Compile label:
                                switch ((int)$stageId) {
                                        case 1:
index ede2a22..8cf9aaa 100644 (file)
@@ -36,7 +36,7 @@ class AutoPublishTask extends \TYPO3\CMS\Scheduler\Task\AbstractTask {
                $autopubObj->autoPublishWorkspaces();
                // There's no feedback from the publishing process,
                // so there can't be any failure.
-               // TODO: This could certainly be improved.
+               // @todo This could certainly be improved.
                return TRUE;
        }
 
index 31b4f7f..aadec52 100644 (file)
@@ -35,7 +35,7 @@ class AutoPublishTask extends \TYPO3\CMS\Scheduler\Task\AbstractTask {
                $autopubObj->autoPublishWorkspaces();
                // There's no feedback from the publishing process,
                // so there can't be any failure.
-               // TODO: This could certainly be improved.
+               // @todo This could certainly be improved.
                return TRUE;
        }