[TASK] Folder not writeable should be an "Error" not a "Warning" 80/24180/3
authorErnesto Baschny <ernst@cron-it.de>
Mon, 30 Sep 2013 18:19:11 +0000 (20:19 +0200)
committerWouter Wolters <typo3@wouterwolters.nl>
Mon, 30 Sep 2013 21:01:45 +0000 (23:01 +0200)
The Install Tool checks for permissions in it's folder structure.  A
folder (typo3temp, uploads, fileadmin) not being writeable now is an
Error and not only a Warning thus displaying a red badge in the Install
Tool main menu.

Resolves: #52407
Releases: 6.2
Change-Id: I6de5f2eace4ecdf089848efbf063a82302aea093
Reviewed-on: https://review.typo3.org/24180
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
typo3/sysext/install/Classes/FolderStructure/DirectoryNode.php
typo3/sysext/install/Tests/Unit/FolderStructure/DirectoryNodeTest.php

index b405721..d453fe1 100644 (file)
@@ -193,7 +193,7 @@ class DirectoryNode extends AbstractNode implements NodeInterface {
                        );
                        $result = $status;
                } elseif (!$this->isWritable()) {
-                       $status = new Status\WarningStatus();
+                       $status = new Status\ErrorStatus();
                        $status->setTitle($this->getRelativePathBelowSiteRoot() . ' is not writable');
                        $status->setMessage(
                                'Path ' . $this->getAbsolutePath() . ' exists, but no file below' .
index c8311f2..019824a 100644 (file)
@@ -209,7 +209,7 @@ class DirectoryNodeTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {
        /**
         * @test
         */
-       public function getStatusReturnsArrayWithWarningStatusIfDirectoryExistsButIsNotWritable() {
+       public function getStatusReturnsArrayWithErrorStatusIfDirectoryExistsButIsNotWritable() {
                /** @var $node \TYPO3\CMS\Install\FolderStructure\DirectoryNode|\TYPO3\CMS\Core\Tests\AccessibleObjectInterface|\PHPUnit_Framework_MockObject_MockObject */
                $node = $this->getAccessibleMock(
                        'TYPO3\\CMS\\Install\\FolderStructure\\DirectoryNode',
@@ -229,7 +229,7 @@ class DirectoryNodeTest extends \TYPO3\CMS\Core\Tests\UnitTestCase {
                $statusArray = $node->getStatus();
                /** @var $status \TYPO3\CMS\Install\Status\StatusInterface */
                $status = $statusArray[0];
-               $this->assertInstanceOf('\TYPO3\CMS\Install\Status\WarningStatus', $status);
+               $this->assertInstanceOf('\TYPO3\CMS\Install\Status\ErrorStatus', $status);
        }
 
        /**