[TASK] Remove misleading icon from buttons in install tool 68/23368/2
authorStefan Rotsch <stefan.rotsch@aoemedia.de>
Tue, 27 Aug 2013 15:53:14 +0000 (17:53 +0200)
committerChristian Kuhn <lolli@schwarzbu.ch>
Tue, 27 Aug 2013 18:02:27 +0000 (20:02 +0200)
Nearly all buttons in the install tool currently show a green checkmark
icon. This is misleading, as in most cases nothing has been checked.
The button simply leads to the next step or executes the desired action.

With removing the icon, it will be more clearer that clicking a button
will just perform the intended action, without any check being
performed beforehand that this action will actually succeed.

Change-Id: If00d4ccde24a201f552ead6b9d8991c8e58b473f
Resolves: #51407
Releases: 6.2
Reviewed-on: https://review.typo3.org/23368
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
typo3/sysext/install/Resources/Private/Partials/Action/Common/SubmitButton.html
typo3/sysext/install/Resources/Private/Partials/Action/Step/DatabaseConnect/ConnectDetails.html
typo3/sysext/install/Resources/Private/Partials/Action/Step/DatabaseConnect/UnloadDbal.html
typo3/sysext/install/Resources/Private/Templates/Action/Step/DatabaseData.html
typo3/sysext/install/Resources/Private/Templates/Action/Step/DatabaseSelect.html
typo3/sysext/install/Resources/Private/Templates/Action/Step/DefaultConfiguration.html
typo3/sysext/install/Resources/Private/Templates/Action/Step/EnvironmentAndFolders.html
typo3/sysext/install/Resources/Private/Templates/BackendModule/ShowEnableInstallToolButton.html
typo3/sysext/install/Resources/Public/Stylesheets/Action/Common/Install.css
typo3/sysext/install/Resources/Public/Stylesheets/Action/Step/General.css
typo3/sysext/install/Resources/Public/Stylesheets/BackendModule/ShowEnableInstallToolButton.css

index f1b7cba..6719ff7 100644 (file)
@@ -6,7 +6,6 @@
                                        name="install[set][{name}]"
                                        >
                                {text}
-                               <span class="t3-install-form-button-icon-positive">&nbsp;</span>
                        </button>
                </li>
        </ol>
index 83a2224..1eab824 100644 (file)
@@ -74,7 +74,6 @@
 
        <button type="submit">
                Continue
-               <span class="t3-install-form-button-icon-positive">&nbsp;</span>
        </button>
 </form>
 <hr />
\ No newline at end of file
index bc1690c..ee54da8 100644 (file)
@@ -4,6 +4,5 @@
        <input type="hidden" value="1" name="install[values][unloadDbal]" />
        <button type="submit">
                I use native mysql
-               <span class="t3-install-form-button-icon-positive">&nbsp;</span>
        </button>
 </form>
\ No newline at end of file
index dd7e9cc..625db33 100644 (file)
@@ -70,7 +70,6 @@
 
                <button type="submit">
                        Continue
-                       <span class="t3-install-form-button-icon-positive">&nbsp;</span>
                </button>
        </form>
-</f:section>
\ No newline at end of file
+</f:section>
index cc3a4f3..8e7c369 100644 (file)
 
                <button type="submit">
                        Continue
-                       <span class="t3-install-form-button-icon-positive">&nbsp;</span>
                </button>
        </form>
-</f:section>
\ No newline at end of file
+</f:section>
index 4a688df..45208b1 100644 (file)
@@ -17,7 +17,6 @@
 
                <button type="submit">
                        Continue
-                       <span class="t3-install-form-button-icon-positive">&nbsp;</span>
                </button>
        </form>
 </f:section>
\ No newline at end of file
index 27dec64..ce3e1a5 100644 (file)
@@ -18,7 +18,6 @@
                        <form method="post">
                                <button type="submit">
                                        Fixed. Check again!
-                                       <span class="t3-install-form-button-icon-positive">&nbsp;</span>
                                </button>
                        </form>
 
@@ -37,7 +36,6 @@
                                <input type="hidden" value="execute" name="install[set]" />
                                <button type="submit">
                                        System looks good. Continue!
-                                       <span class="t3-install-form-button-icon-positive">&nbsp;</span>
                                </button>
                        </form>
                </f:else>
index 2527c28..a8661fe 100644 (file)
@@ -19,7 +19,6 @@
                                        <f:translate
                                                key="LLL:EXT:install/Resources/Private/Language/BackendModule.xlf:confirmUnlockInstallToolButton"
                                        />
-                                       <span class="t3-install-form-button-icon-positive">&nbsp;</span>
                                </button>
                        </div>
                </div>
index 63dc18e..4e650e8 100755 (executable)
@@ -243,10 +243,6 @@ button span.t3-install-form-button-icon-negative {
        background-image: url('../../../Images/Icon/Error.png');
 }
 
-button span.t3-install-form-button-icon-positive {
-       background-image: url('../../../Images/Icon/Ok.png');
-}
-
 .t3-install-hidden {
        display: none;
 }
index f18854f..4f57615 100644 (file)
@@ -250,10 +250,6 @@ button span.t3-install-form-button-icon-negative {
        background-image: url('../../../Images/Icon/Error.png');
 }
 
-button span.t3-install-form-button-icon-positive {
-       background-image: url('../../../Images/Icon/Ok.png');
-}
-
 .t3-install-strong {
        font-weight: bold;
 }
@@ -418,4 +414,4 @@ h3 {
 
 #stepInstaller-databaseSelect ul li input.radio {
        vertical-align: top;
-}
\ No newline at end of file
+}
index 36ce454..963ddec 100644 (file)
@@ -9,15 +9,6 @@
        font-size: 16px;
 }
 
-span.t3-install-form-button-icon-positive {
-       background: url("../../Images/Icon/Ok.png") no-repeat scroll 0 0 transparent;
-       display: inline-block;
-       float: none;
-       height: 16px;
-       margin-left: 0.6em;
-       width: 16px;
-}
-
 form#t3-install-form-unlock button {
        background: url("../../Images/Background/Button.jpg") repeat-x scroll left bottom #F6F6F6;
        border: 1px solid #7C7C7C;