[!!!][TASK] Remove deprecated disable_autocreate feature of workspaces 11/35411/4
authorWouter Wolters <typo3@wouterwolters.nl>
Sun, 14 Dec 2014 13:38:24 +0000 (14:38 +0100)
committerAlexander Opitz <opitz.alexander@googlemail.com>
Sun, 14 Dec 2014 16:34:32 +0000 (17:34 +0100)
Resolves: #62415
Releases: master
Change-Id: I2c51f66c13f10ed4b442f52b20899820f92a5248
Reviewed-on: http://review.typo3.org/35411
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php
typo3/sysext/core/Documentation/Changelog/master/Breaking-62415-DisableAutoCreateRemoved.rst [new file with mode: 0644]
typo3/sysext/workspaces/Configuration/TCA/sys_workspace.php
typo3/sysext/workspaces/Tests/Functional/DataHandling/FAL/DataSet/LiveDefaultElements.csv
typo3/sysext/workspaces/Tests/Functional/DataHandling/Group/DataSet/LiveDefaultElements.csv
typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/DataSet/LiveDefaultElements.csv
typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/DataSet/LiveDefaultElements.csv
typo3/sysext/workspaces/Tests/Functional/DataHandling/ManyToMany/DataSet/LiveDefaultElements.csv
typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/DataSet/LiveDefaultElements.csv
typo3/sysext/workspaces/Tests/Functional/DataHandling/Select/DataSet/LiveDefaultElements.csv
typo3/sysext/workspaces/ext_tables.sql

index 6225a9a..d370b5e 100644 (file)
@@ -1023,14 +1023,12 @@ class BackendUserAuthentication extends \TYPO3\CMS\Core\Authentication\AbstractU
                // enabled and look for workspace version of input record.
                // If there is no versionized record found we will create one and save to that.
                if (
-                       $this->workspace !== 0 && !$this->workspaceRec['disable_autocreate']
+                       $this->workspace !== 0
                        && $GLOBALS['TCA'][$table]['ctrl']['versioningWS'] && $recpid >= 0
                        && !BackendUtility::getWorkspaceVersionOfRecord($this->workspace, $table, $id, 'uid')
                ) {
                        // There must be no existing version of this record in workspace.
                        return TRUE;
-               } elseif ($this->workspaceRec['disable_autocreate']) {
-                       GeneralUtility::deprecationLog('Usage of disable_autocreate feature is deprecated since 4.5.');
                }
                return FALSE;
        }
diff --git a/typo3/sysext/core/Documentation/Changelog/master/Breaking-62415-DisableAutoCreateRemoved.rst b/typo3/sysext/core/Documentation/Changelog/master/Breaking-62415-DisableAutoCreateRemoved.rst
new file mode 100644 (file)
index 0000000..2f7a9a9
--- /dev/null
@@ -0,0 +1,24 @@
+===========================================================================
+Breaking: #62415 - Remove deprecated disable_autocreate field in workspaces
+===========================================================================
+
+Description
+===========
+
+The field "disable_autocreate" from ext:workspaces is removed.
+
+Impact
+======
+
+If a 3rd party extension relies on the removed field an SQL error will be thrown.
+
+
+Affected installations
+======================
+
+An installation is affected if a 3rd party extension relies on the removed field in the database.
+
+Migration
+=========
+
+Remove any usage of the removed field in 3rd party extensions.
\ No newline at end of file
index 63fb7a7..54f1ac6 100644 (file)
@@ -137,13 +137,6 @@ return array(
                                'default' => '0'
                        )
                ),
-               'disable_autocreate' => array(
-                       'label' => 'LLL:EXT:lang/locallang_tca.xlf:sys_workspace.disable_autocreate',
-                       'config' => array(
-                               'type' => 'check',
-                               'default' => '0'
-                       )
-               ),
                'swap_modes' => array(
                        'label' => 'LLL:EXT:lang/locallang_tca.xlf:sys_workspace.swap_modes',
                        'config' => array(
@@ -271,6 +264,6 @@ return array(
                        --div--;LLL:EXT:lang/locallang_tca.xlf:sys_filemounts.tabs.mountpoints,db_mountpoints,file_mountpoints,
                        --div--;LLL:EXT:lang/locallang_tca.xlf:sys_filemounts.tabs.publishing,publish_time,unpublish_time,
                        --div--;LLL:EXT:workspaces/Resources/Private/Language/locallang_db.xlf:sys_filemounts.tabs.staging,custom_stages,
-                       --div--;LLL:EXT:lang/locallang_tca.xlf:sys_filemounts.tabs.other,freeze,live_edit,disable_autocreate,swap_modes,publish_access')
+                       --div--;LLL:EXT:lang/locallang_tca.xlf:sys_filemounts.tabs.other,freeze,live_edit,swap_modes,publish_access')
        )
 );
index b089a13..74940eb 100644 (file)
@@ -1,5 +1,5 @@
 "sys_workspace"
-,"uid","pid","deleted","title","adminusers","members","reviewers","db_mountpoints","file_mountpoints","freeze","live_edit","vtypes","disable_autocreate","swap_modes","publish_access","custom_stages","stagechg_notification","edit_notification_mode","edit_notification_defaults","edit_allow_notificaton_settings","publish_notification_mode","publish_notification_defaults","publish_allow_notificaton_settings"
+,"uid","pid","deleted","title","adminusers","members","reviewers","db_mountpoints","file_mountpoints","freeze","live_edit","vtypes","swap_modes","publish_access","custom_stages","stagechg_notification","edit_notification_mode","edit_notification_defaults","edit_allow_notificaton_settings","publish_notification_mode","publish_notification_defaults","publish_allow_notificaton_settings"
 ,1,0,0,"Workspace #1",,,,,,0,0,0,0,0,0,0,0,0,,0,0,,0
 ,2,0,0,"Workspace #2",,,,,,0,0,0,0,0,0,0,0,0,,0,0,,0
 "sys_workspace_stage"
index 0ed240c..19d16c1 100644 (file)
@@ -1,5 +1,5 @@
 "sys_workspace"
-,"uid","pid","deleted","title","adminusers","members","reviewers","db_mountpoints","file_mountpoints","freeze","live_edit","vtypes","disable_autocreate","swap_modes","publish_access","custom_stages","stagechg_notification","edit_notification_mode","edit_notification_defaults","edit_allow_notificaton_settings","publish_notification_mode","publish_notification_defaults","publish_allow_notificaton_settings"
+,"uid","pid","deleted","title","adminusers","members","reviewers","db_mountpoints","file_mountpoints","freeze","live_edit","vtypes","swap_modes","publish_access","custom_stages","stagechg_notification","edit_notification_mode","edit_notification_defaults","edit_allow_notificaton_settings","publish_notification_mode","publish_notification_defaults","publish_allow_notificaton_settings"
 ,1,0,0,"Workspace #1",,,,,,0,0,0,0,0,0,0,0,0,,0,0,,0
 ,2,0,0,"Workspace #2",,,,,,0,0,0,0,0,0,0,0,0,,0,0,,0
 "sys_workspace_stage"
index 3bfb765..5d3e9c9 100644 (file)
@@ -1,5 +1,5 @@
 sys_workspace
-,uid,pid,deleted,title,adminusers,members,reviewers,db_mountpoints,file_mountpoints,freeze,live_edit,vtypes,disable_autocreate,swap_modes,publish_access,custom_stages,stagechg_notification,edit_notification_mode,edit_notification_defaults,edit_allow_notificaton_settings,publish_notification_mode,publish_notification_defaults,publish_allow_notificaton_settings
+,uid,pid,deleted,title,adminusers,members,reviewers,db_mountpoints,file_mountpoints,freeze,live_edit,vtypes,swap_modes,publish_access,custom_stages,stagechg_notification,edit_notification_mode,edit_notification_defaults,edit_allow_notificaton_settings,publish_notification_mode,publish_notification_defaults,publish_allow_notificaton_settings
 ,1,0,0,"Workspace #1",,,,,,0,0,0,0,0,0,0,0,0,,0,0,,0
 ,2,0,0,"Workspace #2",,,,,,0,0,0,0,0,0,0,0,0,,0,0,,0
 sys_workspace_stage
index 5c63550..4f44601 100644 (file)
@@ -1,5 +1,5 @@
 "sys_workspace"
-,"uid","pid","deleted","title","adminusers","members","reviewers","db_mountpoints","file_mountpoints","freeze","live_edit","vtypes","disable_autocreate","swap_modes","publish_access","custom_stages","stagechg_notification","edit_notification_mode","edit_notification_defaults","edit_allow_notificaton_settings","publish_notification_mode","publish_notification_defaults","publish_allow_notificaton_settings"
+,"uid","pid","deleted","title","adminusers","members","reviewers","db_mountpoints","file_mountpoints","freeze","live_edit","vtypes","swap_modes","publish_access","custom_stages","stagechg_notification","edit_notification_mode","edit_notification_defaults","edit_allow_notificaton_settings","publish_notification_mode","publish_notification_defaults","publish_allow_notificaton_settings"
 ,1,0,0,"Workspace #1",,,,,,0,0,0,0,0,0,0,0,0,,0,0,,0
 ,2,0,0,"Workspace #2",,,,,,0,0,0,0,0,0,0,0,0,,0,0,,0
 "sys_workspace_stage"
index 7f883a5..5c40568 100644 (file)
@@ -1,5 +1,5 @@
 sys_workspace
-,uid,pid,deleted,title,adminusers,members,reviewers,db_mountpoints,file_mountpoints,freeze,live_edit,vtypes,disable_autocreate,swap_modes,publish_access,custom_stages,stagechg_notification,edit_notification_mode,edit_notification_defaults,edit_allow_notificaton_settings,publish_notification_mode,publish_notification_defaults,publish_allow_notificaton_settings
+,uid,pid,deleted,title,adminusers,members,reviewers,db_mountpoints,file_mountpoints,freeze,live_edit,vtypes,swap_modes,publish_access,custom_stages,stagechg_notification,edit_notification_mode,edit_notification_defaults,edit_allow_notificaton_settings,publish_notification_mode,publish_notification_defaults,publish_allow_notificaton_settings
 ,1,0,0,"Workspace #1",,,,,,0,0,0,0,0,0,0,0,0,,0,0,,0
 ,2,0,0,"Workspace #2",,,,,,0,0,0,0,0,0,0,0,0,,0,0,,0
 sys_workspace_stage
index 8a153dc..4ff5fb6 100644 (file)
@@ -1,5 +1,5 @@
 sys_workspace
-,uid,pid,deleted,title,adminusers,members,reviewers,db_mountpoints,file_mountpoints,freeze,live_edit,vtypes,disable_autocreate,swap_modes,publish_access,custom_stages,stagechg_notification,edit_notification_mode,edit_notification_defaults,edit_allow_notificaton_settings,publish_notification_mode,publish_notification_defaults,publish_allow_notificaton_settings
+,uid,pid,deleted,title,adminusers,members,reviewers,db_mountpoints,file_mountpoints,freeze,live_edit,vtypes,swap_modes,publish_access,custom_stages,stagechg_notification,edit_notification_mode,edit_notification_defaults,edit_allow_notificaton_settings,publish_notification_mode,publish_notification_defaults,publish_allow_notificaton_settings
 ,1,0,0,"Workspace #1",,,,,,0,0,0,0,0,0,0,0,0,,0,0,,0
 ,2,0,0,"Workspace #2",,,,,,0,0,0,0,0,0,0,0,0,,0,0,,0
 sys_workspace_stage
index 4f5bb94..d35c59c 100644 (file)
@@ -1,5 +1,5 @@
 "sys_workspace"
-,"uid","pid","deleted","title","adminusers","members","reviewers","db_mountpoints","file_mountpoints","freeze","live_edit","vtypes","disable_autocreate","swap_modes","publish_access","custom_stages","stagechg_notification","edit_notification_mode","edit_notification_defaults","edit_allow_notificaton_settings","publish_notification_mode","publish_notification_defaults","publish_allow_notificaton_settings"
+,"uid","pid","deleted","title","adminusers","members","reviewers","db_mountpoints","file_mountpoints","freeze","live_edit","vtypes","swap_modes","publish_access","custom_stages","stagechg_notification","edit_notification_mode","edit_notification_defaults","edit_allow_notificaton_settings","publish_notification_mode","publish_notification_defaults","publish_allow_notificaton_settings"
 ,1,0,0,"Workspace #1",,,,,,0,0,0,0,0,0,0,0,0,,0,0,,0
 ,2,0,0,"Workspace #2",,,,,,0,0,0,0,0,0,0,0,0,,0,0,,0
 "sys_workspace_stage"
index 1f7709e..c97bf90 100644 (file)
@@ -18,7 +18,6 @@ CREATE TABLE sys_workspace (
        freeze tinyint(3) DEFAULT '0' NOT NULL,
        live_edit tinyint(3) DEFAULT '0' NOT NULL,
        vtypes tinyint(3) DEFAULT '0' NOT NULL,
-       disable_autocreate tinyint(1) DEFAULT '0' NOT NULL,
        swap_modes tinyint(3) DEFAULT '0' NOT NULL,
        publish_access tinyint(3) DEFAULT '0' NOT NULL,
        custom_stages int(11) DEFAULT '0' NOT NULL,