[TASK] Fail acceptance tests on JavaScript errors in browser console 96/56196/13
authorTymoteusz Motylewski <t.motylewski@gmail.com>
Fri, 16 Mar 2018 20:58:22 +0000 (21:58 +0100)
committerTymoteusz Motylewski <t.motylewski@gmail.com>
Fri, 16 Mar 2018 21:33:03 +0000 (22:33 +0100)
Raise typo3/testing-framework to 3.3.0

composer update typo3/testing-framework

Acceptance tests are configured to fail if JavaScript
errors are raised in the console.
See https://github.com/TYPO3/testing-framework/blob/master/Resources/Core/
Build/Configuration/Acceptance/Support/Helper/Acceptance.php

This commit also fixeds a bug found by the tests.
A requireJS error was thrown - timeout on loading `nprogress`
from within Loader.js.

Resolves: #84322
Releases: master
Change-Id: Iea9b6e0c435a73be6e6a4f9567d09f35880822ab
Reviewed-on: https://review.typo3.org/56196
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
composer.lock
typo3/sysext/backend/Resources/Private/TypeScript/Viewport/Loader.ts
typo3/sysext/backend/Resources/Public/JavaScript/Viewport/Loader.js

index 0a726a9..edc4866 100644 (file)
         },
         {
             "name": "typo3/testing-framework",
-            "version": "3.2.0",
+            "version": "3.3.0",
             "source": {
                 "type": "git",
                 "url": "https://github.com/TYPO3/testing-framework.git",
-                "reference": "da30d1b49d60b4e4150d4eae5b128c449f2347ea"
+                "reference": "bad054fd079e669cd3fe8271cf8ba9f418a1ff22"
             },
             "dist": {
                 "type": "zip",
-                "url": "https://api.github.com/repos/TYPO3/testing-framework/zipball/da30d1b49d60b4e4150d4eae5b128c449f2347ea",
-                "reference": "da30d1b49d60b4e4150d4eae5b128c449f2347ea",
+                "url": "https://api.github.com/repos/TYPO3/testing-framework/zipball/bad054fd079e669cd3fe8271cf8ba9f418a1ff22",
+                "reference": "bad054fd079e669cd3fe8271cf8ba9f418a1ff22",
                 "shasum": ""
             },
             "require": {
                 "tests",
                 "typo3"
             ],
-            "time": "2018-03-08T20:33:54+00:00"
+            "time": "2018-03-16T08:17:37+00:00"
         },
         {
             "name": "webmozart/assert",
index 611ef66..1e96e0b 100644 (file)
  */
 
 import {ScaffoldIdentifierEnum} from '../Enum/Viewport/ScaffoldIdentifier';
+import NProgress = require('nprogress');
 
 class Loader {
   public static start(): void {
-    require(['nprogress'], (NProgress: NProgressStatic): void => {
-      NProgress.configure({parent: ScaffoldIdentifierEnum.contentModule, showSpinner: false});
-      NProgress.start();
-    });
+    NProgress.configure({parent: ScaffoldIdentifierEnum.contentModule, showSpinner: false});
+    NProgress.start();
   }
 
   public static finish(): void {
-    require(['nprogress'], (NProgress: NProgressStatic): void => {
-      NProgress.done();
-    });
+    NProgress.done();
   }
 }
 
index d110671..2ab31c6 100644 (file)
@@ -10,4 +10,4 @@
  *
  * The TYPO3 project - inspiring people to share!
  */
-define(["require","exports","../Enum/Viewport/ScaffoldIdentifier"],function(n,t,e){"use strict";return function(){function t(){}return t.start=function(){n(["nprogress"],function(n){n.configure({parent:e.ScaffoldIdentifierEnum.contentModule,showSpinner:!1}),n.start()})},t.finish=function(){n(["nprogress"],function(n){n.done()})},t}()});
\ No newline at end of file
+define(["require","exports","../Enum/Viewport/ScaffoldIdentifier","nprogress"],function(n,e,t,r){"use strict";return function(){function n(){}return n.start=function(){r.configure({parent:t.ScaffoldIdentifierEnum.contentModule,showSpinner:!1}),r.start()},n.finish=function(){r.done()},n}()});
\ No newline at end of file