[BUGFIX] Admin panel shows wrong cache information 35/27835/3
authorDmitry Dulepov <dmitry.dulepov@gmail.com>
Tue, 25 Feb 2014 11:56:28 +0000 (15:56 +0400)
committerStefan Neufeind <typo3.neufeind@speedpartner.de>
Sun, 27 Jul 2014 13:07:07 +0000 (15:07 +0200)
When labels were extracted to translation files, a error was made
that changed the meaning of the admin panel entry. But the code
was not modified to reflect the change of the meaning. Thus the
admin panel shows that the page is cached when it is actually not
cached and vice versa. Additionally, it shows 0 and 1 for the
"Page cached" entry. This should be "yes" or "no", not numbers.

Change-Id: I2519593e7da08b71ccdd5d7dc3dd6ced7ecac3ac
Resolves: #56265
Releases: 6.3, 6.2
Reviewed-on: http://review.typo3.org/27835
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
typo3/sysext/frontend/Classes/View/AdminPanelView.php
typo3/sysext/lang/locallang_tsfe.xlf

index 83487d6..3a618e7 100644 (file)
@@ -492,7 +492,7 @@ class AdminPanelView {
                        $tableArr[] = array($this->extGetLL('info_id'), $GLOBALS['TSFE']->id);
                        $tableArr[] = array($this->extGetLL('info_type'), $GLOBALS['TSFE']->type);
                        $tableArr[] = array($this->extGetLL('info_groupList'), $GLOBALS['TSFE']->gr_list);
-                       $tableArr[] = array($this->extGetLL('info_noCache'), $GLOBALS['TSFE']->no_cache ? 1 : 0);
+                       $tableArr[] = array($this->extGetLL('info_noCache'), $this->extGetLL('info_noCache_' . ($GLOBALS['TSFE']->no_cache ? 'no' : 'yes')));
                        $tableArr[] = array($this->extGetLL('info_countUserInt'), count($GLOBALS['TSFE']->config['INTincScript']));
 
                        if (!empty($GLOBALS['TSFE']->fe_user->user['uid'])) {
index 98186ad..fe65d7f 100644 (file)
                        <trans-unit id="info_noCache" xml:space="preserve">
                                <source>Page cached</source>
                        </trans-unit>
+                       <trans-unit id="info_noCache_yes" xml:space="preserve">
+                               <source>Yes</source>
+                       </trans-unit>
+                       <trans-unit id="info_noCache_no" xml:space="preserve">
+                               <source>No</source>
+                       </trans-unit>
                        <trans-unit id="info_countUserInt" xml:space="preserve">
                                <source>Count of USER_INT objects</source>
                        </trans-unit>