[TASK] Remove mentiones of register_globals 04/49404/2
authorChristian Kuhn <lolli@schwarzbu.ch>
Fri, 5 Aug 2016 21:38:26 +0000 (23:38 +0200)
committerAnja Leichsenring <aleichsenring@ab-softlab.de>
Sat, 6 Aug 2016 08:23:20 +0000 (10:23 +0200)
PHP ini setting register_globals has been removed with
PHP version 5.4. This setting is now more than obsolete,
the last mention in Install.md and the check in system
environment check can be dropped.

Change-Id: I8f9f6b55a12aec756450c6316295b278c20e9fc9
Resolves: #77422
Releases: master
Reviewed-on: https://review.typo3.org/49404
Tested-by: Bamboo TYPO3com <info@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Tobias Adolph <mail@tobiasadolph.de>
Tested-by: Tobias Adolph <mail@tobiasadolph.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
INSTALL.md
typo3/sysext/install/Classes/SystemEnvironment/Check.php

index ac9c0c2..32fbb63 100644 (file)
@@ -59,7 +59,6 @@ It is recommended to also grant the following privileges:
 
 * memory_limit set to at least 64M
 * max_execution_time set to at least 30s (240s recommended)
-* register_globals disabled
 * AllowOverride in the Apache configuration includes "Indexes" and "FileInfo"
   (see FAQ below)
 
index 84599e7..c2dc8a1 100644 (file)
@@ -112,7 +112,6 @@ class Check
         $status[] = $this->checkGdLibJpgSupport();
         $status[] = $this->checkGdLibPngSupport();
         $status[] = $this->checkGdLibFreeTypeSupport();
-        $status[] = $this->checkRegisterGlobals();
 
         return $status;
     }
@@ -1140,35 +1139,6 @@ class Check
     }
 
     /**
-     * Check register globals
-     *
-     * @return Status\StatusInterface
-     */
-    protected function checkRegisterGlobals()
-    {
-        $registerGlobalsEnabled = filter_var(
-            ini_get('register_globals'),
-            FILTER_VALIDATE_BOOLEAN,
-            array(FILTER_REQUIRE_SCALAR, FILTER_NULL_ON_FAILURE)
-        );
-        if ($registerGlobalsEnabled === true) {
-            $status = new Status\ErrorStatus();
-            $status->setTitle('PHP register globals on');
-            $status->setMessage(
-                'register_globals=' . ini_get('register_globals') . LF .
-                'TYPO3 requires PHP setting "register_globals" set to off.' .
-                ' This ancient PHP setting is a big security problem and should' .
-                ' never be enabled:' . LF .
-                'register_globals=Off'
-            );
-        } else {
-            $status = new Status\OkStatus();
-            $status->setTitle('PHP register globals off');
-        }
-        return $status;
-    }
-
-    /**
      * Helper methods
      */