[TASK] Make frontend/Tests/Unit/Plugin notice free 98/57898/2
authorChristian Kuhn <lolli@schwarzbu.ch>
Tue, 14 Aug 2018 17:57:08 +0000 (19:57 +0200)
committerWouter Wolters <typo3@wouterwolters.nl>
Tue, 14 Aug 2018 18:07:40 +0000 (20:07 +0200)
Resolves: #85848
Releases: master
Change-Id: I215768fd8d2b43f2885654cf53dc198416216bb1
Reviewed-on: https://review.typo3.org/57898
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
typo3/sysext/frontend/Classes/Plugin/AbstractPlugin.php
typo3/sysext/frontend/Tests/Unit/Plugin/AbstractPluginTest.php

index 18dea0d..8053aec 100644 (file)
@@ -301,7 +301,7 @@ class AbstractPlugin
                 // now for stdWrap
                 foreach ($confNextLevel as $subKey => $subConfNextLevel) {
                     if (is_array($subConfNextLevel) && $subKey === 'stdWrap.') {
-                        $conf[$key] = $this->cObj->stdWrap($conf[$key], $conf[$key . '.']['stdWrap.']);
+                        $conf[$key] = $this->cObj->stdWrap($conf[$key] ?? '', $conf[$key . '.']['stdWrap.'] ?? []);
                         unset($conf[$key . '.']['stdWrap.']);
                         if (empty($conf[$key . '.'])) {
                             unset($conf[$key . '.']);
index 76c9806..42e1894 100644 (file)
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types = 1);
 namespace TYPO3\CMS\Frontend\Tests\Unit\Plugin;
 
 /*
@@ -26,11 +27,6 @@ use TYPO3\TestingFramework\Core\Unit\UnitTestCase;
 class AbstractPluginTest extends UnitTestCase
 {
     /**
-     * Subject is not notice free, disable E_NOTICES
-     */
-    protected static $suppressNotices = true;
-
-    /**
      * @var AbstractPlugin
      */
     protected $abstractPlugin;