[TASK] Remove checkbox "Include Access List" in be_groups 73/28373/2
authorGeorg Ringer <georg.ringer@gmail.com>
Fri, 14 Mar 2014 07:29:24 +0000 (08:29 +0100)
committerWouter Wolters <typo3@wouterwolters.nl>
Fri, 14 Mar 2014 07:41:33 +0000 (08:41 +0100)
The checkbox "Include Access Lists" in the be_groups just produces extra
clicks and extra reloads. If you don't need those information in the
current group, just don't look at the tab.

Change-Id: I300f711944e76e4366472cf99011e1b193224239
Resolves: #56893
Releases: 6.2
Reviewed-on: https://review.typo3.org/28373
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php
typo3/sysext/core/Configuration/TCA/be_groups.php
typo3/sysext/core/ext_tables.sql

index 26a1bb2..9bff0ca 100644 (file)
@@ -1375,16 +1375,14 @@ class BackendUserAuthentication extends \TYPO3\CMS\Core\Authentication\AbstractU
                                        $this->dataLists['filemount_list'] .= ',' . $row['file_mountpoints'];
                                }
                                // The lists are made: groupMods, tables_select, tables_modify, pagetypes_select, non_exclude_fields, explicit_allowdeny, allowed_languages, custom_options
-                               if ($row['inc_access_lists'] == 1) {
-                                       $this->dataLists['modList'] .= ',' . $row['groupMods'];
-                                       $this->dataLists['tables_select'] .= ',' . $row['tables_select'];
-                                       $this->dataLists['tables_modify'] .= ',' . $row['tables_modify'];
-                                       $this->dataLists['pagetypes_select'] .= ',' . $row['pagetypes_select'];
-                                       $this->dataLists['non_exclude_fields'] .= ',' . $row['non_exclude_fields'];
-                                       $this->dataLists['explicit_allowdeny'] .= ',' . $row['explicit_allowdeny'];
-                                       $this->dataLists['allowed_languages'] .= ',' . $row['allowed_languages'];
-                                       $this->dataLists['custom_options'] .= ',' . $row['custom_options'];
-                               }
+                               $this->dataLists['modList'] .= ',' . $row['groupMods'];
+                               $this->dataLists['tables_select'] .= ',' . $row['tables_select'];
+                               $this->dataLists['tables_modify'] .= ',' . $row['tables_modify'];
+                               $this->dataLists['pagetypes_select'] .= ',' . $row['pagetypes_select'];
+                               $this->dataLists['non_exclude_fields'] .= ',' . $row['non_exclude_fields'];
+                               $this->dataLists['explicit_allowdeny'] .= ',' . $row['explicit_allowdeny'];
+                               $this->dataLists['allowed_languages'] .= ',' . $row['allowed_languages'];
+                               $this->dataLists['custom_options'] .= ',' . $row['custom_options'];
                                $this->dataLists['file_permissions'] .= ',' . $row['file_permissions'];
                                // Setting workspace permissions:
                                $this->dataLists['workspace_perms'] |= $row['workspace_perms'];
index 4c5698b..6bd35aa 100644 (file)
@@ -10,11 +10,6 @@ return array(
                'prependAtCopy' => 'LLL:EXT:lang/locallang_general.xlf:LGL.prependAtCopy',
                'adminOnly' => 1,
                'rootLevel' => 1,
-               'type' => 'inc_access_lists',
-               'typeicon_column' => 'inc_access_lists',
-               'typeicons' => array(
-                       '1' => 'be_groups_lists.gif'
-               ),
                'typeicon_classes' => array(
                        'default' => 'status-user-group-backend'
                ),
@@ -28,7 +23,7 @@ return array(
                'searchFields' => 'title'
        ),
        'interface' => array(
-               'showRecordFieldList' => 'title, db_mountpoints, file_mountpoints, file_permissions, inc_access_lists, tables_select, tables_modify, pagetypes_select, non_exclude_fields, groupMods, lockToDomain, description'
+               'showRecordFieldList' => 'title, db_mountpoints, file_mountpoints, file_permissions, tables_select, tables_modify, pagetypes_select, non_exclude_fields, groupMods, lockToDomain, description'
        ),
        'columns' => array(
                'title' => array(
@@ -254,13 +249,6 @@ return array(
                                'iconsInOptionTags' => 1
                        )
                ),
-               'inc_access_lists' => array(
-                       'label' => 'LLL:EXT:lang/locallang_tca.xlf:be_groups.inc_access_lists',
-                       'config' => array(
-                               'type' => 'check',
-                               'default' => '0'
-                       )
-               ),
                'description' => array(
                        'label' => 'LLL:EXT:lang/locallang_general.xlf:LGL.description',
                        'config' => array(
@@ -322,14 +310,9 @@ return array(
        ),
        'types' => array(
                '0' => array('showitem' => 'hidden;;;;1-1-1, title;;;;2-2-2, description, subgroup;;;;3-3-3,
-                       --div--;LLL:EXT:lang/locallang_tca.xlf:be_groups.tabs.base_rights, inc_access_lists;;;;1-1-1,
+                       --div--;LLL:EXT:lang/locallang_tca.xlf:be_groups.tabs.base_rights;;;;1-1-1, groupMods, tables_select, tables_modify, pagetypes_select, non_exclude_fields, explicit_allowdeny , allowed_languages;;;;2-2-2, custom_options;;;;3-3-3,
                        --div--;LLL:EXT:lang/locallang_tca.xlf:be_groups.tabs.mounts_and_workspaces, workspace_perms;;;;1-1-1, db_mountpoints;;;;2-2-2, file_mountpoints;;;;3-3-3, file_permissions, category_perms,
                        --div--;LLL:EXT:lang/locallang_tca.xlf:be_groups.tabs.options, lockToDomain;;;;1-1-1, hide_in_lists;;;;2-2-2, TSconfig;;;;3-3-3,
                        --div--;LLL:EXT:lang/locallang_tca.xlf:be_groups.tabs.extended'),
-               '1' => array('showitem' => 'hidden;;;;1-1-1, title;;;;2-2-2, description, subgroup;;;;3-3-3,
-                       --div--;LLL:EXT:lang/locallang_tca.xlf:be_groups.tabs.base_rights, inc_access_lists;;;;1-1-1, groupMods, tables_select, tables_modify, pagetypes_select, non_exclude_fields, explicit_allowdeny , allowed_languages;;;;2-2-2, custom_options;;;;3-3-3,
-                       --div--;LLL:EXT:lang/locallang_tca.xlf:be_groups.tabs.mounts_and_workspaces, workspace_perms;;;;1-1-1, db_mountpoints;;;;2-2-2, file_mountpoints;;;;3-3-3, file_permissions, category_perms,
-                       --div--;LLL:EXT:lang/locallang_tca.xlf:be_groups.tabs.options, lockToDomain;;;;1-1-1, hide_in_lists;;;;2-2-2, TSconfig;;;;3-3-3,
-                       --div--;LLL:EXT:lang/locallang_tca.xlf:be_groups.tabs.extended')
        )
 );
index 87a387e..8f73c6c 100644 (file)
@@ -22,7 +22,6 @@ CREATE TABLE be_groups (
   file_mountpoints text,
   file_permissions text,
   hidden tinyint(1) unsigned DEFAULT '0' NOT NULL,
-  inc_access_lists tinyint(3) unsigned DEFAULT '0' NOT NULL,
   description text,
   lockToDomain varchar(50) DEFAULT '' NOT NULL,
   deleted tinyint(1) unsigned DEFAULT '0' NOT NULL,