[TASK] CGL fix core after php-cs-fixer 2.9.0 raise 23/55123/2
authorChristian Kuhn <lolli@schwarzbu.ch>
Sat, 16 Dec 2017 15:12:03 +0000 (16:12 +0100)
committerChristian Kuhn <lolli@schwarzbu.ch>
Sat, 16 Dec 2017 15:47:39 +0000 (16:47 +0100)
The "self_accessor" fixer is more strict with younger
php-cs-fixer releases and changes method argument type
hints to self if a class object of the same class is
expected. It also changes return type hints to self
in this case.
This fixer now may collide with the "xclass" system
of the core and is thus deactivated. We shoud decide
manually if self or class name is used.

Change-Id: I3a8c20bea1d79ac2c7bc1e9ecbc2d435c4047843
Resolves: #83360
Related: #83331
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55123
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Build/.php_cs
typo3/sysext/backend/Classes/Controller/PageLayoutController.php
typo3/sysext/extbase/Classes/Persistence/Generic/Query.php

index 024dbbd..812f396 100644 (file)
@@ -72,7 +72,6 @@ return PhpCsFixer\Config::create()
         'lowercase_cast' => true,
         'no_leading_namespace_whitespace' => true,
         'native_function_casing' => true,
-        'self_accessor' => true,
         'no_short_bool_cast' => true,
         'no_unneeded_control_parentheses' => true,
         'phpdoc_no_empty_return' => true,
index 0c7b008..11322d6 100644 (file)
@@ -155,7 +155,6 @@ class PageLayoutController
     public $pageinfo;
 
     /**
-
      * "Pseudo" Description -table name
      *
      * @var string
index 814fadd..c8cceee 100644 (file)
@@ -61,7 +61,6 @@ class Query implements QueryInterface
 
     /**
      * @var \TYPO3\CMS\Extbase\Persistence\PersistenceManagerInterface
-
      */
     protected $persistenceManager;