[BUGFIX] Adhere "suggestions" when resolving ext loading order 92/39692/4
authorMarkus Klein <markus.klein@typo3.org>
Sun, 24 May 2015 22:55:43 +0000 (00:55 +0200)
committerXavier Perseguers <xavier@typo3.org>
Mon, 25 May 2015 17:19:16 +0000 (19:19 +0200)
The issue #58701 introduced the functionality to fetch suggestions defined
in composer.json or ext_emconf.php into the Package class.
A copy and paste error causes the loading of the suggestions to
actually fail, so those never reach the DependencyResolver.

This patch fixes the tiny mistake and thus ensures that suggestions
really influence the loading order of extensions.

Resolves: #51069
Releases: master, 6.2
Change-Id: Ib12e7f91f49c0b2bda56fdb4394a604e322b741c
Reviewed-on: http://review.typo3.org/39692
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
typo3/sysext/core/Classes/Package/Package.php

index ee6400d..9c34f3d 100644 (file)
@@ -308,7 +308,7 @@ class Package implements PackageInterface {
                                        }
                                }
                        }
-                       if (isset($extensionManagerConfiguration['constraints']['suggests']) && is_array($extensionManagerConfiguration['constraints']['conflicts'])) {
+                       if (isset($extensionManagerConfiguration['constraints']['suggests']) && is_array($extensionManagerConfiguration['constraints']['suggests'])) {
                                $composerManifest->suggest = new \stdClass();
                                foreach ($extensionManagerConfiguration['constraints']['suggests'] as $suggestedPackageKey => $suggestedPackageVersion) {
                                        if (!empty($suggestedPackageKey)) {