[TASK] Add missing type for method getServicePathStatus 44/50844/5
authorWouter Wolters <typo3@wouterwolters.nl>
Thu, 1 Dec 2016 22:09:47 +0000 (23:09 +0100)
committerJan Helke <typo3@helke.de>
Fri, 2 Dec 2016 13:50:42 +0000 (14:50 +0100)
Small other code cleanups are done as well.

Resolves: #78861
Releases: master
Change-Id: I983e1f76d8ad46dd4d6c231b99b41ab8f05fe454
Reviewed-on: https://review.typo3.org/50844
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
typo3/sysext/sv/Classes/Report/ServicesListReport.php

index eb5c3b1..0b08130 100644 (file)
@@ -24,13 +24,10 @@ use TYPO3\CMS\Reports\ReportInterface;
 
 /**
  * This class provides a report displaying a list of all installed services
- * Code inspired by EXT:dam/lib/class.tx_dam_svlist.php by RenĂ© Fritz
  */
 class ServicesListReport implements ReportInterface
 {
     /**
-     * Back-reference to the calling reports module
-     *
      * @var ReportController
      */
     protected $reportsModule;
@@ -141,8 +138,7 @@ class ServicesListReport implements ReportInterface
      */
     protected function getExecutablesSearchPathList()
     {
-        $addInvalidSearchPaths = true;
-        $searchPaths = CommandUtility::getPaths($addInvalidSearchPaths);
+        $searchPaths = CommandUtility::getPaths(true);
         $result = [];
 
         foreach ($searchPaths as $path => $isValid) {
@@ -211,18 +207,8 @@ class ServicesListReport implements ReportInterface
     }
 
     /**
-     * Returns LanguageService
-     *
-     * @return \TYPO3\CMS\Lang\LanguageService
-     */
-    protected function getLanguageService()
-    {
-        return $GLOBALS['LANG'];
-    }
-
-    /**
      * Method to check if the service in path is available
-     * @param $isValid
+     * @param bool|string $isValid
      * @return array
      */
     private function getServicePathStatus($isValid): array
@@ -239,4 +225,14 @@ class ServicesListReport implements ReportInterface
             'accessible' => $accessible
         ];
     }
+
+    /**
+     * Returns LanguageService
+     *
+     * @return \TYPO3\CMS\Lang\LanguageService
+     */
+    protected function getLanguageService()
+    {
+        return $GLOBALS['LANG'];
+    }
 }