[TASK] Drop unused code in SilentConfigurationUpgradeService 95/57395/2
authorMathias Brodala <mbrodala@pagemachine.de>
Wed, 27 Jun 2018 07:27:30 +0000 (09:27 +0200)
committerMathias Brodala <mbrodala@pagemachine.de>
Wed, 27 Jun 2018 14:03:15 +0000 (16:03 +0200)
This removes unused code which is left over from the fix for #83591.

Resolves: #83591
Releases: 8.7
Change-Id: Ibdf283c973e333ec7eb6d1ecb82fe0198465b69e
Reviewed-on: https://review.typo3.org/57395
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
typo3/sysext/install/Classes/Service/SilentConfigurationUpgradeService.php
typo3/sysext/install/Tests/Unit/Service/SilentConfigurationUpgradeServiceTest.php

index a8e95d7..529a44a 100644 (file)
@@ -463,12 +463,6 @@ class SilentConfigurationUpgradeService
             $currentProcessorMaskValue = $this->configurationManager->getDefaultConfigurationValueByPath('GFX/processor_allowTemporaryMasksAsPng');
         }
 
-        try {
-            $currentProcessorEffectsValue = $this->configurationManager->getLocalConfigurationValueByPath('GFX/processor_effects');
-        } catch (\RuntimeException $e) {
-            $currentProcessorEffectsValue = $this->configurationManager->getDefaultConfigurationValueByPath('GFX/processor_effects');
-        }
-
         if ((string)$currentProcessorValue !== '') {
             if ($currentProcessorMaskValue != 0) {
                 $changedValues['GFX/processor_allowTemporaryMasksAsPng'] = 0;
index cc08103..11e4566 100644 (file)
@@ -532,7 +532,6 @@ class SilentConfigurationUpgradeServiceTest extends \TYPO3\TestingFramework\Core
         $currentLocalConfiguration = [
             ['GFX/processor', 'GraphicsMagick'],
             ['GFX/processor_allowTemporaryMasksAsPng', 1],
-            ['GFX/processor_effects', 0]
         ];
         $this->createConfigurationManagerWithMockedMethods(
             [
@@ -541,7 +540,7 @@ class SilentConfigurationUpgradeServiceTest extends \TYPO3\TestingFramework\Core
                 'setLocalConfigurationValuesByPathValuePairs',
             ]
         );
-        $this->configurationManager->expects($this->exactly(3))
+        $this->configurationManager->expects($this->exactly(2))
             ->method('getLocalConfigurationValueByPath')
             ->will($this->returnValueMap($currentLocalConfiguration));
         $this->configurationManager->expects($this->never())
@@ -576,7 +575,6 @@ class SilentConfigurationUpgradeServiceTest extends \TYPO3\TestingFramework\Core
         $currentLocalConfiguration = [
             ['GFX/processor', ''],
             ['GFX/processor_allowTemporaryMasksAsPng', 0],
-            ['GFX/processor_effects', 0]
         ];
         $this->createConfigurationManagerWithMockedMethods(
             [
@@ -585,7 +583,7 @@ class SilentConfigurationUpgradeServiceTest extends \TYPO3\TestingFramework\Core
                 'setLocalConfigurationValuesByPathValuePairs',
             ]
         );
-        $this->configurationManager->expects($this->exactly(3))
+        $this->configurationManager->expects($this->exactly(2))
             ->method('getLocalConfigurationValueByPath')
             ->will($this->returnValueMap($currentLocalConfiguration));
         $this->configurationManager->expects($this->never())