[TASK] Remove additionalClasses option from FontawesomeProvider. 45/42945/4
authorFrank Nägler <frank.naegler@typo3.org>
Mon, 31 Aug 2015 15:31:23 +0000 (17:31 +0200)
committerMarkus Klein <markus.klein@typo3.org>
Wed, 2 Sep 2015 12:12:15 +0000 (14:12 +0200)
This option was introduced with the new Icon API but is not useful
and must be removed now.

Resolves: #69441
Releases: master
Change-Id: I7d02a320e9c7eaa91e877b703c78d535ee3d45cd
Reviewed-on: http://review.typo3.org/42945
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Build/Resources/Public/Less/Component/icon.less
typo3/sysext/core/Classes/Imaging/IconProvider/FontawesomeIconProvider.php
typo3/sysext/core/Classes/Imaging/IconRegistry.php
typo3/sysext/core/Documentation/Changelog/master/Feature-68741-IntroduceNewIconFactoryAsBaseForReplaceTheIconSkinningAPI.rst
typo3/sysext/t3skin/Resources/Public/Css/backend.css

index c8c4191..cd24960 100644 (file)
 //
 // Special icons
 //
-.icon-default-not-found {
-       color: @brand-danger;
-}
-
-.icon-overlay-read-only {
+.icon-default-not-found,
+.icon-actions-edit-copy-release,
+.icon-actions-edit-cut-release,
+.icon-overlay-read-only,
+.icon-status-status-current {
        color: @brand-danger;
 }
index 0759697..f337ae6 100644 (file)
@@ -44,7 +44,6 @@ class FontawesomeIconProvider implements IconProviderInterface {
                if (preg_match('/^[a-zA-Z0-9\\-]+$/', $options['name']) !== 1) {
                        throw new \InvalidArgumentException('The option "name" must only contain characters a-z, A-Z, 0-9 or -', 1440754979);
                }
-               $additionalClasses = (!empty($options['additionalClasses'])) ? ' ' . $options['additionalClasses'] : '';
-               return '<span class="icon-unify"><i class="fa fa-' . htmlspecialchars($options['name']) . htmlspecialchars($additionalClasses) . '"></i></span>';
+               return '<span class="icon-unify"><i class="fa fa-' . htmlspecialchars($options['name']) . '"></i></span>';
        }
 }
index 20196e8..a005c32 100644 (file)
@@ -140,7 +140,6 @@ class IconRegistry implements \TYPO3\CMS\Core\SingletonInterface {
                        'provider' => FontawesomeIconProvider::class,
                        'options' => array(
                                'name' => 'copy',
-                               'additionalClasses' => 'text-danger',
                        )
                ),
                'actions-edit-cut' => array(
@@ -153,7 +152,6 @@ class IconRegistry implements \TYPO3\CMS\Core\SingletonInterface {
                        'provider' => FontawesomeIconProvider::class,
                        'options' => array(
                                'name' => 'scissors',
-                               'additionalClasses' => 'text-danger',
                        )
                ),
                'actions-edit-download' => array(
@@ -318,7 +316,6 @@ class IconRegistry implements \TYPO3\CMS\Core\SingletonInterface {
                        'provider' => FontawesomeIconProvider::class,
                        'options' => array(
                                'name' => 'caret-right',
-                               'additionalClasses' => 'text-danger',
                        )
                ),
 
index 4899f8b..8306dea 100644 (file)
@@ -26,6 +26,30 @@ The core implement three icon provider classes, which all implements the ``IconP
 Third party extensions can provide own icon provider classes, each class must implement the ``IconProviderInterface``.
 
 
+BitmapIconProvider
+------------------
+
+The ``BitmapIconProvider`` has the following options
+
+* ``source`` The path to the bitmap file, this can also contains the EXT: prefix
+
+
+FontawesomeIconProvider
+-----------------------
+
+The ``FontawesomeIconProvider`` has the following options
+
+* ``name`` The name of the icon whithout the icon prefix e.g. ``check`` instead of ``fa-check``
+
+
+SvgIconProvider
+---------------
+
+The ``SvgIconProvider`` has the following options
+
+* ``source`` The path to the svg file, this can also contains the EXT: prefix
+
+
 Register an icon
 ----------------
 
index 1cbc42b..b812a09 100644 (file)
@@ -7849,10 +7849,11 @@ button.close {
   line-height: 30px;
   font-size: 26px;
 }
-.icon-default-not-found {
-  color: #c83c3c;
-}
-.icon-overlay-read-only {
+.icon-default-not-found,
+.icon-actions-edit-copy-release,
+.icon-actions-edit-cut-release,
+.icon-overlay-read-only,
+.icon-status-status-current {
   color: #c83c3c;
 }
 .clearfix:before,