[BUGFIX] Use correct setting to display search rules 09/46009/2
authorLudwig Rafelsberger <ludwig.rafelsberger@gmx.at>
Sat, 16 Jan 2016 11:02:37 +0000 (12:02 +0100)
committerMorton Jonuschat <m.jonuschat@mojocode.de>
Sat, 16 Jan 2016 13:05:52 +0000 (14:05 +0100)
The extbase plugin (pi2) of EXT:indexed_search previously used a
different TypoScript setting to control the display of search rules
than the setting that is shipped as default TypoScript. This changes
the template to use the correct setting.

Resolves: #51099
Releases: master, 7.6
Change-Id: I893ff0c85a3bc9fde885cbb5103d9ebf54e488a2
Reviewed-on: https://review.typo3.org/46002
Reviewed-by: Bernhard Kraft <kraftb@think-open.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Bernhard Kraft <kraftb@think-open.at>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
(cherry picked from commit 01ffb0c45ae4894f74d25a39e96bdd7b0dc683da)
Reviewed-on: https://review.typo3.org/46009

typo3/sysext/core/Documentation/Changelog/master/Breaking-51099-StreamlineSettingsConditions.rst [new file with mode: 0644]
typo3/sysext/indexed_search/Resources/Private/Partials/Rules.html

diff --git a/typo3/sysext/core/Documentation/Changelog/master/Breaking-51099-StreamlineSettingsConditions.rst b/typo3/sysext/core/Documentation/Changelog/master/Breaking-51099-StreamlineSettingsConditions.rst
new file mode 100644 (file)
index 0000000..7f7f160
--- /dev/null
@@ -0,0 +1,34 @@
+=================================================
+Breaking: #51099 - Streamline settings/conditions
+=================================================
+
+Description
+===========
+
+The default TypoScript for the ``pi2`` (extbase) plugin of EXT:indexed_search sets a TypoScript
+variable ``plugin.tx_indexedsearch.settings.displayRules = 1``, while the default fluid template
+uses the TypoScript setting ``plugin.tx_indexedsearch.settings.showRules``. This change makes the
+default fluid template for the extbase plugin of EXT:indexed_search use the correct TypoScript
+setting.
+
+
+Impact
+======
+
+Instances of the extbase plugin (``pi2``) of EXT:indexed_search using the default fluid template and
+explicitly configured to *hide* the search rules deliberately using the wrong TypoScript setting
+``plugin.tx_indexedsearch.settings.showRules = 0`` *will show* the search rules after this update.
+
+
+Affected Installations
+======================
+
+Installations using the extbase plugin (``pi2``) of EXT:indexed_search with default template and relying
+on the undocumented TypoScript setting ``plugin.tx_indexedsearch.settings.showRules = 0``.
+
+
+Migration
+=========
+
+Change all occurrences of the TypoScript setting ``plugin.tx_indexedsearch.settings.showRules = 0``
+to ``plugin.tx_indexedsearch.settings.displayRules = 1``.
index b81206e..c8a6194 100644 (file)
@@ -1,4 +1,4 @@
-<f:if condition="{settings.showRules}">
+<f:if condition="{settings.displayRules}">
 <div class="tx-indexedsearch-rules">
        <h2><f:translate key="rules.headline" /></h2>
        <p><f:format.nl2br><f:translate key="rules.text" /></f:format.nl2br></p>