[TASK] Make IconViewHelperTest notice free 62/56262/3
authorSascha Löffler <lsascha@gmail.com>
Fri, 16 Mar 2018 21:38:06 +0000 (22:38 +0100)
committerJan Helke <typo3@helke.de>
Fri, 16 Mar 2018 22:03:19 +0000 (23:03 +0100)
Resolves: #84382
Releases: master
Change-Id: Ie3636104caf9ce61da3071ab738cb0e1f7a05e89
Reviewed-on: https://review.typo3.org/56262
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
typo3/sysext/core/Tests/Unit/ViewHelpers/IconViewHelperTest.php

index 265eafe..5598b98 100644 (file)
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types = 1);
 namespace TYPO3\CMS\Core\Tests\Unit\ViewHelpers;
 
 /*
@@ -28,11 +29,6 @@ use TYPO3\TestingFramework\Fluid\Unit\ViewHelpers\ViewHelperBaseTestcase;
 class IconViewHelperTest extends ViewHelperBaseTestcase
 {
     /**
-     * Subject is not notice free, disable E_NOTICES
-     */
-    protected static $suppressNotices = true;
-
-    /**
      * @var IconViewHelper
      */
     protected $viewHelper;
@@ -59,7 +55,10 @@ class IconViewHelperTest extends ViewHelperBaseTestcase
 
         $this->viewHelper->setArguments([
             'identifier' => 'myIdentifier',
-            'size' => Icon::SIZE_SMALL
+            'size' => Icon::SIZE_SMALL,
+            'overlay' => null,
+            'state' => IconState::cast(IconState::STATE_DEFAULT),
+            'alternativeMarkupIdentifier' => null
         ]);
 
         $this->assertSame('htmlFoo', $this->viewHelper->render());
@@ -79,7 +78,10 @@ class IconViewHelperTest extends ViewHelperBaseTestcase
 
         $this->viewHelper->setArguments([
             'identifier' => 'myIdentifier',
-            'size' => Icon::SIZE_LARGE
+            'size' => Icon::SIZE_LARGE,
+            'overlay' => null,
+            'state' => IconState::cast(IconState::STATE_DEFAULT),
+            'alternativeMarkupIdentifier' => null
         ]);
 
         $this->assertSame('htmlFoo', $this->viewHelper->render());
@@ -101,7 +103,8 @@ class IconViewHelperTest extends ViewHelperBaseTestcase
             'identifier' => 'myIdentifier',
             'size' => Icon::SIZE_SMALL,
             'overlay' => null,
-            'state' => IconState::cast(IconState::STATE_DISABLED)
+            'state' => IconState::cast(IconState::STATE_DISABLED),
+            'alternativeMarkupIdentifier' => null
         ]);
 
         $this->assertSame('htmlFoo', $this->viewHelper->render());
@@ -122,7 +125,9 @@ class IconViewHelperTest extends ViewHelperBaseTestcase
         $this->viewHelper->setArguments([
             'identifier' => 'myIdentifier',
             'size' => Icon::SIZE_LARGE,
-            'overlay' => 'overlayString'
+            'overlay' => 'overlayString',
+            'state' => IconState::cast(IconState::STATE_DEFAULT),
+            'alternativeMarkupIdentifier' => null
         ]);
         $this->assertSame('htmlFoo', $this->viewHelper->render());
     }