[TASK] Implement group "mysql" in functional tests 38/51438/5
authorManuel Selbach <manuel_selbach@yahoo.de>
Thu, 26 Jan 2017 20:02:11 +0000 (21:02 +0100)
committerChristian Kuhn <lolli@schwarzbu.ch>
Fri, 10 Feb 2017 00:34:49 +0000 (01:34 +0100)
Add group "mysql" to select functional tests that require a MySQL
Server as a database backend due to testing functionality that is
only available on this platform.

Resolves: #79509
Releases: master
Change-Id: Ia4d653efc56673d666274dabdc86474ffafd4756
Reviewed-on: https://review.typo3.org/51438
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
typo3/sysext/core/Tests/Functional/Cache/Backend/Typo3DatabaseBackendTest.php
typo3/sysext/core/Tests/Functional/Database/DatabaseConnectionTest.php
typo3/sysext/core/Tests/Functional/Database/PreparedStatementTest.php
typo3/sysext/install/Tests/Functional/SqlSchemaMigrationServiceTest.php

index 9c26821..09587aa 100644 (file)
@@ -400,6 +400,8 @@ class Typo3DatabaseBackendTest extends \TYPO3\Components\TestingFramework\Core\F
 
     /**
      * @test
+     *
+     * @group mysql
      */
     public function flushByTagWorksWithEmptyCacheTablesWithMysql()
     {
@@ -409,6 +411,8 @@ class Typo3DatabaseBackendTest extends \TYPO3\Components\TestingFramework\Core\F
 
     /**
      * @test
+     *
+     * @group mysql
      */
     public function flushByTagsWorksWithEmptyCacheTablesWithMysql()
     {
@@ -418,6 +422,8 @@ class Typo3DatabaseBackendTest extends \TYPO3\Components\TestingFramework\Core\F
 
     /**
      * @test
+     *
+     * @group mysql
      */
     public function flushByTagRemovesCorrectRowsFromDatabaseWithMysql()
     {
@@ -436,6 +442,8 @@ class Typo3DatabaseBackendTest extends \TYPO3\Components\TestingFramework\Core\F
 
     /**
      * @test
+     *
+     * @group mysql
      */
     public function flushByTagsRemovesCorrectRowsFromDatabaseWithMysql()
     {
@@ -508,6 +516,8 @@ class Typo3DatabaseBackendTest extends \TYPO3\Components\TestingFramework\Core\F
 
     /**
      * @test
+     *
+     * @group mysql
      */
     public function collectGarbageWorksWithEmptyTableWithMysql()
     {
@@ -517,6 +527,8 @@ class Typo3DatabaseBackendTest extends \TYPO3\Components\TestingFramework\Core\F
 
     /**
      * @test
+     *
+     * @group mysql
      */
     public function collectGarbageRemovesCacheEntryWithExpiredLifetimeWithMysql()
     {
@@ -546,6 +558,8 @@ class Typo3DatabaseBackendTest extends \TYPO3\Components\TestingFramework\Core\F
 
     /**
      * @test
+     *
+     * @group mysql
      */
     public function collectGarbageRemovesTagEntriesForCacheEntriesWithExpiredLifetimeWithMysql()
     {
@@ -575,6 +589,8 @@ class Typo3DatabaseBackendTest extends \TYPO3\Components\TestingFramework\Core\F
 
     /**
      * @test
+     *
+     * @group mysql
      */
     public function collectGarbageRemovesOrphanedTagEntriesFromTagsTableWithMysql()
     {
index e5e9206..28060e8 100644 (file)
@@ -74,6 +74,7 @@ class DatabaseConnectionTest extends \TYPO3\Components\TestingFramework\Core\Fun
     /**
      * @test
      *
+     * @group mysql
      * @return void
      */
     public function selectDbReturnsTrue()
@@ -83,6 +84,8 @@ class DatabaseConnectionTest extends \TYPO3\Components\TestingFramework\Core\Fun
 
     /**
      * @test
+     *
+     * @group mysql
      * @return void
      */
     public function selectDbReturnsFalse()
@@ -98,6 +101,7 @@ class DatabaseConnectionTest extends \TYPO3\Components\TestingFramework\Core\Fun
     /**
      * @test
      *
+     * @group mysql
      * @return void
      */
     public function sqlAffectedRowsReturnsCorrectAmountOfRows()
@@ -109,6 +113,7 @@ class DatabaseConnectionTest extends \TYPO3\Components\TestingFramework\Core\Fun
     /**
      * @test
      *
+     * @group mysql
      * @return void
      */
     public function sqlInsertIdReturnsCorrectId()
@@ -120,6 +125,7 @@ class DatabaseConnectionTest extends \TYPO3\Components\TestingFramework\Core\Fun
     /**
      * @test
      *
+     * @group mysql
      * @return void
      */
     public function noSqlError()
@@ -131,6 +137,7 @@ class DatabaseConnectionTest extends \TYPO3\Components\TestingFramework\Core\Fun
     /**
      * @test
      *
+     * @group mysql
      * @return void
      */
     public function sqlErrorWhenInsertIntoInexistentField()
@@ -142,6 +149,7 @@ class DatabaseConnectionTest extends \TYPO3\Components\TestingFramework\Core\Fun
     /**
      * @test
      *
+     * @group mysql
      * @return void
      */
     public function noSqlErrorCode()
@@ -153,6 +161,7 @@ class DatabaseConnectionTest extends \TYPO3\Components\TestingFramework\Core\Fun
     /**
      * @test
      *
+     * @group mysql
      * @return void
      */
     public function sqlErrorNoWhenInsertIntoInexistentField()
@@ -163,6 +172,8 @@ class DatabaseConnectionTest extends \TYPO3\Components\TestingFramework\Core\Fun
 
     /**
      * @test
+     *
+     * @group mysql
      */
     public function sqlPconnectReturnsInstanceOfMySqli()
     {
@@ -171,6 +182,8 @@ class DatabaseConnectionTest extends \TYPO3\Components\TestingFramework\Core\Fun
 
     /**
      * @test
+     *
+     * @group mysql
      */
     public function connectDbThrowsExeptionsWhenNoDatabaseIsGiven()
     {
@@ -185,6 +198,7 @@ class DatabaseConnectionTest extends \TYPO3\Components\TestingFramework\Core\Fun
     /**
      * @test
      *
+     * @group mysql
      * @return void
      */
     public function connectDbConnectsToDatabaseWithoutErrors()
@@ -196,6 +210,7 @@ class DatabaseConnectionTest extends \TYPO3\Components\TestingFramework\Core\Fun
     /**
      * @test
      *
+     * @group mysql
      * @return void
      */
     public function disconnectIfConnectedDisconnects()
@@ -257,6 +272,7 @@ class DatabaseConnectionTest extends \TYPO3\Components\TestingFramework\Core\Fun
      * @param string $values
      * @param string $expectedResult
      *
+     * @group mysql
      * @return void
      */
     public function fullQuoteStrReturnsQuotedString($values, $expectedResult)
@@ -383,6 +399,7 @@ class DatabaseConnectionTest extends \TYPO3\Components\TestingFramework\Core\Fun
      * @param string $values
      * @param string $expectedResult
      *
+     * @group mysql
      * @return void
      */
     public function fullQuoteArrayQuotesArray($values, $expectedResult)
@@ -431,6 +448,7 @@ class DatabaseConnectionTest extends \TYPO3\Components\TestingFramework\Core\Fun
      * @param string $string String to quote
      * @param string $expectedResult Quoted string we expect
      *
+     * @group mysql
      * @return void
      */
     public function quoteStrQuotesDoubleQuotesCorrectly($string, $expectedResult)
@@ -442,6 +460,7 @@ class DatabaseConnectionTest extends \TYPO3\Components\TestingFramework\Core\Fun
     /**
      * @test
      *
+     * @group mysql
      * @return void
      */
     public function adminQueryReturnsTrueForInsertQuery()
@@ -454,6 +473,7 @@ class DatabaseConnectionTest extends \TYPO3\Components\TestingFramework\Core\Fun
     /**
      * @test
      *
+     * @group mysql
      * @return void
      */
     public function adminQueryReturnsTrueForUpdateQuery()
@@ -470,6 +490,7 @@ class DatabaseConnectionTest extends \TYPO3\Components\TestingFramework\Core\Fun
     /**
      * @test
      *
+     * @group mysql
      * @return void
      */
     public function adminQueryReturnsTrueForDeleteQuery()
@@ -484,6 +505,7 @@ class DatabaseConnectionTest extends \TYPO3\Components\TestingFramework\Core\Fun
     /**
      * @test
      *
+     * @group mysql
      * @return void
      */
     public function adminQueryReturnsResultForSelectQuery()
@@ -500,6 +522,7 @@ class DatabaseConnectionTest extends \TYPO3\Components\TestingFramework\Core\Fun
     /**
      * @test
      *
+     * @group mysql
      * @return void
      */
     public function adminGetCharsetsReturnsArrayWithCharsets()
@@ -517,6 +540,7 @@ class DatabaseConnectionTest extends \TYPO3\Components\TestingFramework\Core\Fun
     /**
      * @test
      *
+     * @group mysql
      * @return void
      */
     public function adminGetKeysReturnIndexKeysOfTable()
@@ -528,6 +552,7 @@ class DatabaseConnectionTest extends \TYPO3\Components\TestingFramework\Core\Fun
     /**
      * @test
      *
+     * @group mysql
      * @return void
      */
     public function adminGetFieldsReturnFieldInformationsForTable()
@@ -540,6 +565,7 @@ class DatabaseConnectionTest extends \TYPO3\Components\TestingFramework\Core\Fun
     /**
      * @test
      *
+     * @group mysql
      * @return void
      */
     public function adminGetTablesReturnAllTablesFromDatabase()
@@ -552,6 +578,7 @@ class DatabaseConnectionTest extends \TYPO3\Components\TestingFramework\Core\Fun
     /**
      * @test
      *
+     * @group mysql
      * @return void
      */
     public function adminGetDbsReturnsAllDatabases()
@@ -595,6 +622,7 @@ class DatabaseConnectionTest extends \TYPO3\Components\TestingFramework\Core\Fun
      * @param string $sql
      * @param string $expectedResult
      *
+     * @group mysql
      * @return void
      */
     public function sqlNumRowsReturnsCorrectAmountOfRows($sql, $expectedResult)
@@ -613,6 +641,7 @@ class DatabaseConnectionTest extends \TYPO3\Components\TestingFramework\Core\Fun
     /**
      * @test
      *
+     * @group mysql
      * @return void
      */
     public function sqlNumRowsReturnsFalse()
@@ -654,6 +683,7 @@ class DatabaseConnectionTest extends \TYPO3\Components\TestingFramework\Core\Fun
     /**
      * @test
      *
+     * @group mysql
      * @return void
      */
     public function sqlFetchAssocReturnsAssocArray()
@@ -713,6 +743,7 @@ class DatabaseConnectionTest extends \TYPO3\Components\TestingFramework\Core\Fun
     /**
      * @test
      *
+     * @group mysql
      * @return void
      */
     public function sqlFetchRowReturnsNumericArray()
@@ -735,6 +766,7 @@ class DatabaseConnectionTest extends \TYPO3\Components\TestingFramework\Core\Fun
     /**
      * @test
      *
+     * @group mysql
      * @return void
      */
     public function sqlFreeResultReturnsFalseOnFailure()
@@ -749,6 +781,7 @@ class DatabaseConnectionTest extends \TYPO3\Components\TestingFramework\Core\Fun
     /**
      * @test
      *
+     * @group mysql
      * @return void
      */
     public function sqlFreeResultReturnsTrueOnSuccess()
index d891733..ba61e9b 100644 (file)
@@ -74,6 +74,7 @@ class PreparedStatementTest extends \TYPO3\Components\TestingFramework\Core\Func
     /**
      * @test
      *
+     * @group mysql
      * @return void
      */
     public function prepareSelectQueryCreateValidQuery()
index a2e60c6..188b489 100644 (file)
@@ -35,6 +35,8 @@ class SqlSchemaMigrationServiceTest extends \TYPO3\Components\TestingFramework\C
 
     /**
      * @test
+     *
+     * @group mysql
      */
     public function columnAndKeyDeletionDoesNotReturnAnError()
     {