[TASK] Remove implement statement if parent already implements the interface 55/55955/6
authorWouter Wolters <typo3@wouterwolters.nl>
Wed, 28 Feb 2018 20:46:37 +0000 (21:46 +0100)
committerChristian Kuhn <lolli@schwarzbu.ch>
Thu, 1 Mar 2018 13:15:30 +0000 (14:15 +0100)
Resolves: #84094
Releases: master
Change-Id: I0fff99f75287fd5a43093b5df540cea040420d21
Reviewed-on: https://review.typo3.org/55955
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
26 files changed:
typo3/sysext/backend/Classes/Http/RouteDispatcher.php
typo3/sysext/backend/Classes/Template/Components/Buttons/InputButton.php
typo3/sysext/backend/Classes/Template/Components/Buttons/LinkButton.php
typo3/sysext/backend/Classes/Template/Components/Buttons/SplitButton.php
typo3/sysext/core/Classes/Cache/Backend/FileBackend.php
typo3/sysext/extbase/Classes/Property/TypeConverter/FileConverter.php
typo3/sysext/extbase/Classes/Property/TypeConverter/FileReferenceConverter.php
typo3/sysext/extbase/Classes/Property/TypeConverter/FolderBasedFileCollectionConverter.php
typo3/sysext/extbase/Classes/Property/TypeConverter/FolderConverter.php
typo3/sysext/extbase/Classes/Property/TypeConverter/IntegerConverter.php
typo3/sysext/extbase/Classes/Property/TypeConverter/ObjectConverter.php
typo3/sysext/extbase/Classes/Property/TypeConverter/StaticFileCollectionConverter.php
typo3/sysext/extbase/Classes/Property/TypeConverter/StringConverter.php
typo3/sysext/form/Classes/Domain/Renderer/FluidFormRenderer.php
typo3/sysext/frontend/Classes/AdminPanel/CacheModule.php
typo3/sysext/frontend/Classes/AdminPanel/EditModule.php
typo3/sysext/frontend/Classes/AdminPanel/InfoModule.php
typo3/sysext/frontend/Classes/AdminPanel/PreviewModule.php
typo3/sysext/frontend/Classes/AdminPanel/TsDebugModule.php
typo3/sysext/install/Classes/Configuration/Image/GraphicsMagickPreset.php
typo3/sysext/install/Classes/Configuration/Image/ImageMagick6Preset.php
typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodArgumentDroppedMatcher.php
typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodArgumentDroppedStaticMatcher.php
typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodArgumentRequiredMatcher.php
typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodArgumentRequiredStaticMatcher.php
typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodArgumentUnusedMatcher.php

index 0702029..c63e94c 100644 (file)
@@ -22,7 +22,6 @@ use TYPO3\CMS\Backend\Routing\Router;
 use TYPO3\CMS\Backend\Utility\BackendUtility;
 use TYPO3\CMS\Core\FormProtection\FormProtectionFactory;
 use TYPO3\CMS\Core\Http\Dispatcher;
-use TYPO3\CMS\Core\Http\DispatcherInterface;
 use TYPO3\CMS\Core\Type\Bitmask\Permission;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Core\Utility\MathUtility;
@@ -30,7 +29,7 @@ use TYPO3\CMS\Core\Utility\MathUtility;
 /**
  * Dispatcher which resolves a route to call a controller and method (but also a callable)
  */
-class RouteDispatcher extends Dispatcher implements DispatcherInterface
+class RouteDispatcher extends Dispatcher
 {
     /**
      * Main method to resolve the route and checks the target of the route, and tries to call it.
index b014a1e..1703df2 100644 (file)
@@ -33,7 +33,7 @@ namespace TYPO3\CMS\Backend\Template\Components\Buttons;
  *      ->setTitle('Save');
  * $buttonBar->addButton($saveButton, ButtonBar::BUTTON_POSITION_LEFT, 1);
  */
-class InputButton extends AbstractButton implements ButtonInterface
+class InputButton extends AbstractButton
 {
     /**
      * Name Attribute of the button
index 46e9855..06c9828 100644 (file)
@@ -32,7 +32,7 @@ namespace TYPO3\CMS\Backend\Template\Components\Buttons;
  *      ->setTitle('Save');
  * $buttonBar->addButton($saveButton, ButtonBar::BUTTON_POSITION_LEFT, 1);
  */
-class LinkButton extends AbstractButton implements ButtonInterface
+class LinkButton extends AbstractButton
 {
     /**
      * HREF attribute of the link
index 71f3d8e..28310fd 100644 (file)
@@ -47,7 +47,7 @@ namespace TYPO3\CMS\Backend\Template\Components\Buttons;
  *      ->addItem($saveAndCloseButton)
  *      ->addItem($saveAndShowPageButton);
  */
-class SplitButton extends AbstractButton implements ButtonInterface
+class SplitButton extends AbstractButton
 {
     /**
      * Internal var that determines whether the split button has received any primary
index 044d7b5..60038ad 100644 (file)
@@ -24,7 +24,7 @@ use TYPO3\CMS\Core\Utility\StringUtility;
  * This file is a backport from FLOW3
  * @api
  */
-class FileBackend extends \TYPO3\CMS\Core\Cache\Backend\SimpleFileBackend implements \TYPO3\CMS\Core\Cache\Backend\PhpCapableBackendInterface, \TYPO3\CMS\Core\Cache\Backend\FreezableBackendInterface, \TYPO3\CMS\Core\Cache\Backend\TaggableBackendInterface
+class FileBackend extends \TYPO3\CMS\Core\Cache\Backend\SimpleFileBackend implements \TYPO3\CMS\Core\Cache\Backend\FreezableBackendInterface, \TYPO3\CMS\Core\Cache\Backend\TaggableBackendInterface
 {
     const SEPARATOR = '^';
     const EXPIRYTIME_FORMAT = 'YmdHis';
index 868a16c..a418dce 100644 (file)
@@ -19,7 +19,7 @@ namespace TYPO3\CMS\Extbase\Property\TypeConverter;
  *
  * @api experimental! This class is experimental and subject to change!
  */
-class FileConverter extends \TYPO3\CMS\Extbase\Property\TypeConverter\AbstractFileFolderConverter implements \TYPO3\CMS\Core\SingletonInterface
+class FileConverter extends \TYPO3\CMS\Extbase\Property\TypeConverter\AbstractFileFolderConverter
 {
     /**
      * @var array<string>
index 6439c40..67d0565 100644 (file)
@@ -19,7 +19,7 @@ namespace TYPO3\CMS\Extbase\Property\TypeConverter;
  *
  * @api experimental! This class is experimental and subject to change!
  */
-class FileReferenceConverter extends \TYPO3\CMS\Extbase\Property\TypeConverter\AbstractFileFolderConverter implements \TYPO3\CMS\Core\SingletonInterface
+class FileReferenceConverter extends \TYPO3\CMS\Extbase\Property\TypeConverter\AbstractFileFolderConverter
 {
     /**
      * @var array<string>
index 1f69ef1..9038fdd 100644 (file)
@@ -19,7 +19,7 @@ namespace TYPO3\CMS\Extbase\Property\TypeConverter;
  *
  * @api experimental! This class is experimental and subject to change!
  */
-class FolderBasedFileCollectionConverter extends \TYPO3\CMS\Extbase\Property\TypeConverter\AbstractFileCollectionConverter implements \TYPO3\CMS\Core\SingletonInterface
+class FolderBasedFileCollectionConverter extends \TYPO3\CMS\Extbase\Property\TypeConverter\AbstractFileCollectionConverter
 {
     /**
      * @var array<string>
index 71c5e60..743c9ab 100644 (file)
@@ -19,7 +19,7 @@ namespace TYPO3\CMS\Extbase\Property\TypeConverter;
  *
  * @api experimental! This class is experimental and subject to change!
  */
-class FolderConverter extends \TYPO3\CMS\Extbase\Property\TypeConverter\AbstractFileFolderConverter implements \TYPO3\CMS\Core\SingletonInterface
+class FolderConverter extends \TYPO3\CMS\Extbase\Property\TypeConverter\AbstractFileFolderConverter
 {
     /**
      * @var array<string>
index 1f2cc59..302308d 100644 (file)
@@ -25,7 +25,7 @@ namespace TYPO3\CMS\Extbase\Property\TypeConverter;
  *
  * @api
  */
-class IntegerConverter extends \TYPO3\CMS\Extbase\Property\TypeConverter\AbstractTypeConverter implements \TYPO3\CMS\Core\SingletonInterface
+class IntegerConverter extends \TYPO3\CMS\Extbase\Property\TypeConverter\AbstractTypeConverter
 {
     /**
      * @var array<string>
index badf8bc..005b39b 100644 (file)
@@ -25,7 +25,7 @@ namespace TYPO3\CMS\Extbase\Property\TypeConverter;
  *
  * @api
  */
-class ObjectConverter extends AbstractTypeConverter implements \TYPO3\CMS\Core\SingletonInterface
+class ObjectConverter extends AbstractTypeConverter
 {
     /**
      * @var int
index 3b57fd6..eadea45 100644 (file)
@@ -19,7 +19,7 @@ namespace TYPO3\CMS\Extbase\Property\TypeConverter;
  *
  * @api experimental! This class is experimental and subject to change!
  */
-class StaticFileCollectionConverter extends \TYPO3\CMS\Extbase\Property\TypeConverter\AbstractFileCollectionConverter implements \TYPO3\CMS\Core\SingletonInterface
+class StaticFileCollectionConverter extends \TYPO3\CMS\Extbase\Property\TypeConverter\AbstractFileCollectionConverter
 {
     /**
      * @var array<string>
index 49fb577..d147b13 100644 (file)
@@ -25,7 +25,7 @@ namespace TYPO3\CMS\Extbase\Property\TypeConverter;
  *
  * @api
  */
-class StringConverter extends \TYPO3\CMS\Extbase\Property\TypeConverter\AbstractTypeConverter implements \TYPO3\CMS\Core\SingletonInterface
+class StringConverter extends \TYPO3\CMS\Extbase\Property\TypeConverter\AbstractTypeConverter
 {
     /**
      * @var array<string>
index 5633fdd..3f5b7cc 100644 (file)
@@ -120,7 +120,7 @@ use TYPO3\CMS\Form\ViewHelpers\RenderRenderableViewHelper;
  * **This class is NOT meant to be sub classed by developers.**
  * @internal
  */
-class FluidFormRenderer extends AbstractElementRenderer implements RendererInterface
+class FluidFormRenderer extends AbstractElementRenderer
 {
 
     /**
index d1d1507..2e8326e 100644 (file)
@@ -3,7 +3,7 @@ declare(strict_types=1);
 
 namespace TYPO3\CMS\Frontend\AdminPanel;
 
-class CacheModule extends AbstractModule implements AdminPanelModuleInterface
+class CacheModule extends AbstractModule
 {
     /**
      * Creates the content for the "cache" section ("module") of the Admin Panel
index 343dffb..a8939a5 100644 (file)
@@ -24,7 +24,7 @@ use TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController;
 /**
  * Admin Panel Edit Module
  */
-class EditModule extends AbstractModule implements AdminPanelModuleInterface
+class EditModule extends AbstractModule
 {
     /**
      * Creates the content for the "edit" section ("module") of the Admin Panel
index 3a7f435..5fed7b4 100644 (file)
@@ -23,7 +23,7 @@ use TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController;
 /**
  * Admin Panel Info Module
  */
-class InfoModule extends AbstractModule implements AdminPanelModuleInterface
+class InfoModule extends AbstractModule
 {
     /**
      * Creates the content for the "info" section ("module") of the Admin Panel
index 15c5415..d8c1c19 100644 (file)
@@ -24,7 +24,7 @@ use TYPO3\CMS\Core\Utility\GeneralUtility;
 /**
  * Admin Panel Preview Module
  */
-class PreviewModule extends AbstractModule implements AdminPanelModuleInterface
+class PreviewModule extends AbstractModule
 {
 
     /**
index a622589..b32a0db 100644 (file)
@@ -22,7 +22,7 @@ use TYPO3\CMS\Core\Utility\GeneralUtility;
 /**
  * Admin Panel TypoScript Debug Module
  */
-class TsDebugModule extends AbstractModule implements AdminPanelModuleInterface
+class TsDebugModule extends AbstractModule
 {
 
     /**
index 6b801f1..751781c 100644 (file)
@@ -14,12 +14,10 @@ namespace TYPO3\CMS\Install\Configuration\Image;
  * The TYPO3 project - inspiring people to share!
  */
 
-use TYPO3\CMS\Install\Configuration;
-
 /**
  * Preset for GraphicsMagick
  */
-class GraphicsMagickPreset extends AbstractImagePreset implements Configuration\PresetInterface
+class GraphicsMagickPreset extends AbstractImagePreset
 {
     /**
      * @var string Name of preset
index c6338ec..2e7dfff 100644 (file)
@@ -14,12 +14,10 @@ namespace TYPO3\CMS\Install\Configuration\Image;
  * The TYPO3 project - inspiring people to share!
  */
 
-use TYPO3\CMS\Install\Configuration;
-
 /**
  * Preset for ImageMagick version 6 or higher
  */
-class ImageMagick6Preset extends AbstractImagePreset implements Configuration\PresetInterface
+class ImageMagick6Preset extends AbstractImagePreset
 {
     /**
      * @var string Name of preset
index e6157b3..0f9adb3 100644 (file)
@@ -17,7 +17,6 @@ namespace TYPO3\CMS\Install\ExtensionScanner\Php\Matcher;
 
 use PhpParser\Node;
 use PhpParser\Node\Expr\MethodCall;
-use TYPO3\CMS\Install\ExtensionScanner\CodeScannerInterface;
 
 /**
  * Find usages of method calls which changed signature and dropped arguments,
@@ -25,7 +24,7 @@ use TYPO3\CMS\Install\ExtensionScanner\CodeScannerInterface;
  * This is a "weak" match since we're just testing for method name
  * but not connected class.
  */
-class MethodArgumentDroppedMatcher extends AbstractCoreMatcher implements CodeScannerInterface
+class MethodArgumentDroppedMatcher extends AbstractCoreMatcher
 {
     /**
      * Prepare $this->flatMatcherDefinitions once and validate config
index fffbbdf..87fdc36 100644 (file)
@@ -19,13 +19,12 @@ use PhpParser\Node;
 use PhpParser\Node\Expr\StaticCall;
 use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Name\FullyQualified;
-use TYPO3\CMS\Install\ExtensionScanner\CodeScannerInterface;
 
 /**
  * Find usages of static method calls which were removed / deprecated.
  * This is a "strong" match if class name is given and "weak" if not.
  */
-class MethodArgumentDroppedStaticMatcher extends AbstractCoreMatcher implements CodeScannerInterface
+class MethodArgumentDroppedStaticMatcher extends AbstractCoreMatcher
 {
     /**
      * Prepare $this->flatMatcherDefinitions once and validate config
index 1756348..5a7aa07 100644 (file)
@@ -17,14 +17,13 @@ namespace TYPO3\CMS\Install\ExtensionScanner\Php\Matcher;
 
 use PhpParser\Node;
 use PhpParser\Node\Expr\MethodCall;
-use TYPO3\CMS\Install\ExtensionScanner\CodeScannerInterface;
 
 /**
  * Find usages of method calls which changed signature and added required arguments.
  * This is a "weak" match since we're just testing for method name
  * but not connected class.
  */
-class MethodArgumentRequiredMatcher extends AbstractCoreMatcher implements CodeScannerInterface
+class MethodArgumentRequiredMatcher extends AbstractCoreMatcher
 {
     /**
      * Prepare $this->flatMatcherDefinitions once and validate config
index 3525c41..11b3b41 100644 (file)
@@ -19,13 +19,12 @@ use PhpParser\Node;
 use PhpParser\Node\Expr\StaticCall;
 use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Name\FullyQualified;
-use TYPO3\CMS\Install\ExtensionScanner\CodeScannerInterface;
 
 /**
  * Find usages of static method calls which gained new mandatory arguments.
  * This is a "strong" match if class name is given and "weak" if not.
  */
-class MethodArgumentRequiredStaticMatcher extends AbstractCoreMatcher implements CodeScannerInterface
+class MethodArgumentRequiredStaticMatcher extends AbstractCoreMatcher
 {
     /**
      * Prepare $this->flatMatcherDefinitions once and validate config
index 7cca30b..f07fd29 100644 (file)
@@ -18,7 +18,6 @@ namespace TYPO3\CMS\Install\ExtensionScanner\Php\Matcher;
 use PhpParser\Node;
 use PhpParser\Node\Expr\ConstFetch;
 use PhpParser\Node\Expr\MethodCall;
-use TYPO3\CMS\Install\ExtensionScanner\CodeScannerInterface;
 
 /**
  * Match method usages where arguments "in between" are unused but not given as "null":
@@ -27,7 +26,7 @@ use TYPO3\CMS\Install\ExtensionScanner\CodeScannerInterface;
  * but called with:
  * ->foo('arg1', 'notNull', null, 'arg4');
  */
-class MethodArgumentUnusedMatcher extends AbstractCoreMatcher implements CodeScannerInterface
+class MethodArgumentUnusedMatcher extends AbstractCoreMatcher
 {
     /**
      * Prepare $this->flatMatcherDefinitions once and validate config