[!!!][TASK] Drop removeLoginpagesWithContentHash from Indexer.php 71/41371/5
authorWouter Wolters <typo3@wouterwolters.nl>
Wed, 15 Jul 2015 21:33:02 +0000 (23:33 +0200)
committerGeorg Ringer <georg.ringer@gmail.com>
Wed, 15 Jul 2015 22:31:04 +0000 (00:31 +0200)
Unused since at least TYPO3 CMS 6.0

Resolves: #68193
Releases: master
Change-Id: I75bf495959d33eff48aeb587aa816dc7947985ef
Reviewed-on: http://review.typo3.org/41371
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
typo3/sysext/core/Documentation/Changelog/master/Breaking-68193-DropRemoveLoginpagesWithContentHashFromIndexerphp.rst [new file with mode: 0644]
typo3/sysext/indexed_search/Classes/Indexer.php

diff --git a/typo3/sysext/core/Documentation/Changelog/master/Breaking-68193-DropRemoveLoginpagesWithContentHashFromIndexerphp.rst b/typo3/sysext/core/Documentation/Changelog/master/Breaking-68193-DropRemoveLoginpagesWithContentHashFromIndexerphp.rst
new file mode 100644 (file)
index 0000000..23d2f65
--- /dev/null
@@ -0,0 +1,26 @@
+========================================================================
+Breaking: #68193 - Drop removeLoginpagesWithContentHash from Indexer.php
+========================================================================
+
+Description
+===========
+
+The method ``\TYPO3\CMS\IndexedSearch\Indexer::removeLoginpagesWithContentHash()`` is not used within the core since 6.0 and is removed now.
+
+
+Impact
+======
+
+Calling ``\TYPO3\CMS\IndexedSearch\Indexer::removeLoginpagesWithContentHash()`` will throw a fatal error.
+
+
+Affected Installations
+======================
+
+All installations with third party code using the mentioned method.
+
+
+Migration
+=========
+
+No migration is available.
\ No newline at end of file
index d1f2d96..bb72fe3 100644 (file)
@@ -1869,27 +1869,6 @@ class Indexer {
        }
 
        /**
-        * Removes any indexed pages with userlogins which has the same contentHash
-        * NOT USED anywhere inside this class!
-        *
-        * @return void
-        */
-       public function removeLoginpagesWithContentHash() {
-               if (IndexedSearchUtility::isTableUsed('index_phash') && IndexedSearchUtility::isTableUsed('index_grlist')) {
-                       $res = $GLOBALS['TYPO3_DB']->exec_SELECTquery('A.phash', 'index_phash A,index_grlist B', '
-                                       A.phash=B.phash
-                                       AND A.phash_grouping=' . (int)$this->hash['phash_grouping'] . '
-                                       AND B.hash_gr_list<>' . IndexedSearchUtility::md5inthash($this->defaultGrList) . '
-                                       AND A.contentHash=' . (int)$this->content_md5h);
-                       while ($res && FALSE !== ($row = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($res))) {
-                               $this->log_setTSlogMessage('The currently indexed page was indexed under no user-login and apparently this page has been indexed under login conditions earlier, but with the SAME content. Therefore the old similar page with phash=\'' . $row['phash'] . '\' are now removed.', 1);
-                               $this->removeOldIndexedPages($row['phash']);
-                       }
-                       $GLOBALS['TYPO3_DB']->sql_free_result($res);
-               }
-       }
-
-       /**
         * Includes the crawler class
         *
         * @return void