[FOLLOWUP][TASK] Streamline icons for "new" actions 05/53105/2
authorDaniel Windloff <daniel.jc.windloff@googlemail.com>
Sat, 3 Jun 2017 19:59:08 +0000 (21:59 +0200)
committerChristian Kuhn <lolli@schwarzbu.ch>
Sun, 4 Jun 2017 08:39:19 +0000 (10:39 +0200)
- actions-add
Link to one new record or a wizard to select the type
of the record
- actions-page-new
Link to one new page record
- actions-document-new
Link to create multiple new records (EditDocumentController)

Resolves: #81428
Releases: master
Change-Id: Ic95a4b3b7727e96a2da818633d03cba7a1c7bde7
Reviewed-on: https://review.typo3.org/53105
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
12 files changed:
typo3/sysext/backend/Classes/ContextMenu/ItemProviders/PageProvider.php
typo3/sysext/backend/Classes/ContextMenu/ItemProviders/RecordProvider.php
typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php
typo3/sysext/backend/Classes/View/PageLayoutView.php
typo3/sysext/backend/Resources/Public/JavaScript/LayoutModule/DragDrop.js
typo3/sysext/backend/Resources/Public/JavaScript/LayoutModule/Paste.js
typo3/sysext/core/Tests/Acceptance/Backend/Formhandler/Inline1nCest.php
typo3/sysext/filelist/Classes/Controller/FileListController.php
typo3/sysext/frontend/Classes/View/AdminPanelView.php
typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php
typo3/sysext/sys_action/Classes/ActionTask.php
typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php

index 8cfd03c..73bcd6b 100644 (file)
@@ -43,7 +43,7 @@ class PageProvider extends RecordProvider
         ],
         'new' => [
             'label' => 'LLL:EXT:lang/Resources/Private/Language/locallang_core.xlf:cm.new',
-            'iconIdentifier' => 'actions-document-new',
+            'iconIdentifier' => 'actions-page-new',
             'callbackAction' => 'newRecord'
         ],
         'info' => [
index f414c08..bad7b2d 100644 (file)
@@ -63,7 +63,7 @@ class RecordProvider extends AbstractProvider
         ],
         'new' => [
             'label' => 'LLL:EXT:lang/Resources/Private/Language/locallang_core.xlf:cm.new',
-            'iconIdentifier' => 'actions-document-new',
+            'iconIdentifier' => 'actions-add',
             'callbackAction' => 'newRecord'
         ],
         'info' => [
@@ -110,7 +110,7 @@ class RecordProvider extends AbstractProvider
             'childItems' => [
                 'newWizard' => [
                     'label' => 'LLL:EXT:lang/Resources/Private/Language/locallang_misc.xlf:CM_newWizard',
-                    'iconIdentifier' => 'actions-document-new',
+                    'iconIdentifier' => 'actions-add',
                     'callbackAction' => 'newContentWizard',
                 ],
                 'openListModule' => [
index 18a9491..5992eff 100644 (file)
@@ -363,7 +363,7 @@ class InlineControlContainer extends AbstractContainer
         switch ($type) {
             case 'newRecord':
                 $title = htmlspecialchars($languageService->sL('LLL:EXT:lang/Resources/Private/Language/locallang_core.xlf:cm.createnew'));
-                $icon = 'actions-document-new';
+                $icon = 'actions-add';
                 $className = 'typo3-newRecordLink';
                 $attributes['class'] = 'btn btn-default inlineNewButton ' . $this->inlineData['config'][$nameObject]['md5'];
                 $attributes['onclick'] = 'return inline.createNewRecord(' . GeneralUtility::quoteJSvalue($objectPrefix) . ')';
@@ -594,7 +594,7 @@ class InlineControlContainer extends AbstractContainer
             $item .= '
             <span class="input-group-btn">
                 <a href="#" class="btn btn-default" onclick="' . htmlspecialchars($onChange) . '" title="' . $createNewRelationText . '">
-                    ' . $this->iconFactory->getIcon('actions-document-new', Icon::SIZE_SMALL)->render() . $createNewRelationText . '
+                    ' . $this->iconFactory->getIcon('actions-add', Icon::SIZE_SMALL)->render() . $createNewRelationText . '
                 </a>
             </span>';
         } else {
index f4d334b..23d9ef9 100644 (file)
@@ -585,7 +585,7 @@ class PageLayoutView extends \TYPO3\CMS\Recordlist\RecordList\AbstractDatabaseRe
 
                     $link = '<a href="' . htmlspecialchars($url) . '" title="'
                         . htmlspecialchars($this->getLanguageService()->getLL('newContentElement')) . '" class="btn btn-default btn-sm">'
-                        . $this->iconFactory->getIcon('actions-add-placeholder', Icon::SIZE_SMALL)->render()
+                        . $this->iconFactory->getIcon('actions-add', Icon::SIZE_SMALL)->render()
                         . ' '
                         . htmlspecialchars($this->getLanguageService()->getLL('content')) . '</a>';
                 }
@@ -699,7 +699,7 @@ class PageLayoutView extends \TYPO3\CMS\Recordlist\RecordList\AbstractDatabaseRe
                                 $singleElementHTML .= '
                                                                <a href="' . htmlspecialchars($url) . '" title="'
                                     . htmlspecialchars($this->getLanguageService()->getLL('newContentElement')) . '" class="btn btn-default btn-sm">'
-                                    . $this->iconFactory->getIcon('actions-document-new', Icon::SIZE_SMALL)->render()
+                                    . $this->iconFactory->getIcon('actions-add', Icon::SIZE_SMALL)->render()
                                     . ' '
                                     . htmlspecialchars($this->getLanguageService()->getLL('content')) . '</a>
                                                        ';
@@ -1086,7 +1086,7 @@ class PageLayoutView extends \TYPO3\CMS\Recordlist\RecordList\AbstractDatabaseRe
             $url = BackendUtility::getModuleUrl('record_edit', $urlParameters);
             $theData['__cmds__'] = '<a href="' . htmlspecialchars($url) . '" '
                 . 'title="' . htmlspecialchars($this->getLanguageService()->getLL('new')) . '">'
-                . $this->iconFactory->getIcon('actions-document-new', Icon::SIZE_SMALL)->render() . '</a>';
+                . $this->iconFactory->getIcon('actions-add', Icon::SIZE_SMALL)->render() . '</a>';
         }
         $out .= $this->addElement(1, '', $theData, ' class="c-headLine"', 15, '', 'th');
         // Render Items
index 49edc86..43dfd42 100644 (file)
@@ -93,7 +93,7 @@ define(['jquery', 'jquery-ui/droppable'], function ($) {
                // make the drop zones visible
                $(DragDrop.dropZoneIdentifier).each(function () {
                        if (
-                               $(this).parent().find('.icon-actions-document-new').length
+                               $(this).parent().find('.icon-actions-add').length
                        ) {
                                $(this).addClass(DragDrop.validDropZoneClass);
                        } else {
index a4817f3..d433572 100644 (file)
@@ -46,7 +46,7 @@ define(['jquery',
         */
        Paste.activatePasteIcons = function () {
                $('.t3-page-ce-wrapper-new-ce').each(function () {
-                       if (!$(this).find('.icon-actions-document-new').length) {
+                       if (!$(this).find('.icon-actions-add').length) {
                                return true;
                        }
                        $('.t3js-page-lang-column .t3-page-ce > .t3-page-ce').removeClass('t3js-page-ce');
index a7508cd..dbc2360 100644 (file)
@@ -75,7 +75,7 @@ class Inline1nCest
      */
     public function createInline1nInlineElement(Admin $I)
     {
-        $I->click('span[data-identifier="actions-document-new"]', 'div.typo3-newRecordLink');
+        $I->click('span[data-identifier="actions-add"]', 'div.typo3-newRecordLink');
 
         $fieldLabel = 'input_1';
         $testValue = 'Fo Bar';
index 275fb54..99aaf9d 100644 (file)
@@ -621,7 +621,7 @@ class FileListController extends ActionController
                     ]
                 ))
                 ->setTitle($lang->sL('LLL:EXT:lang/Resources/Private/Language/locallang_core.xlf:cm.new'))
-                ->setIcon($iconFactory->getIcon('actions-add-placeholder', Icon::SIZE_SMALL));
+                ->setIcon($iconFactory->getIcon('actions-add', Icon::SIZE_SMALL));
             $buttonBar->addButton($newButton, ButtonBar::BUTTON_POSITION_LEFT, 1);
         }
 
index 1b50c57..eddbc01 100644 (file)
@@ -893,7 +893,7 @@ class AdminPanelView
                 $params = '&sys_language_uid=' . $tsfe->sys_language_uid;
             }
             $link = $newContentWizScriptPath . 'id=' . $id . $params . '&returnUrl=' . rawurlencode($returnUrl);
-            $icon = $this->iconFactory->getIcon('actions-document-new', Icon::SIZE_SMALL)->render();
+            $icon = $this->iconFactory->getIcon('actions-add', Icon::SIZE_SMALL)->render();
             $title = $this->extGetLL('edit_newContentElement');
             $output[] = '<a class="' . $classes . '" href="' . htmlspecialchars($link) . '" title="' . $title . '">';
             $output[] = '  ' . $icon;
index 59d09b9..9c3f66d 100644 (file)
@@ -270,7 +270,7 @@ class DatabaseRecordList extends AbstractDatabaseRecordList
                 $onClick = htmlspecialchars('return jumpExt(' . GeneralUtility::quoteJSvalue(BackendUtility::getModuleUrl('db_new', ['id' => $this->id])) . ');');
                 $buttons['new_record'] = '<a href="#" onclick="' . $onClick . '" title="'
                     . htmlspecialchars($lang->getLL('newRecordGeneral')) . '">'
-                    . $this->iconFactory->getIcon('actions-add-placeholder', Icon::SIZE_SMALL)->render() . '</a>';
+                    . $this->iconFactory->getIcon('actions-add', Icon::SIZE_SMALL)->render() . '</a>';
             }
             // If edit permissions are set, see
             // \TYPO3\CMS\Core\Authentication\BackendUserAuthentication
@@ -388,7 +388,7 @@ class DatabaseRecordList extends AbstractDatabaseRecordList
                     ->setHref('#')
                     ->setOnClick($onClick)
                     ->setTitle($lang->getLL('newRecordGeneral'))
-                    ->setIcon($this->iconFactory->getIcon('actions-add-placeholder', Icon::SIZE_SMALL));
+                    ->setIcon($this->iconFactory->getIcon('actions-add', Icon::SIZE_SMALL));
                 $buttonBar->addButton($newRecordButton, ButtonBar::BUTTON_POSITION_LEFT, 10);
             }
             if (!in_array($this->pageRow['doktype'], $noViewDokTypes)) {
index 2b6e1c7..490bdd1 100644 (file)
@@ -293,7 +293,7 @@ class ActionTask implements \TYPO3\CMS\Taskcenter\TaskInterface
 
             $content .= '<p>' .
                 '<a class="btn btn-default" href="' . $link . '" title="' . $this->getLanguageService()->getLL('new-sys_action') . '">' .
-                $this->iconFactory->getIcon('actions-document-new', Icon::SIZE_SMALL)->render() . ' ' .
+                $this->iconFactory->getIcon('actions-add', Icon::SIZE_SMALL)->render() . ' ' .
                 $this->getLanguageService()->getLL('new-sys_action') .
                 '</a></p>';
         }
index d7b61e8..7b669e0 100644 (file)
@@ -323,7 +323,7 @@ class TypoScriptTemplateModuleController extends BaseScriptClass
                     ->setHref(BackendUtility::getModuleUrl('web_ts', $urlParameters))
                     ->setTitle($lang->sL('LLL:EXT:lang/Resources/Private/Language/locallang_core.xlf:db_new.php.pagetitle'))
                     ->setIcon($this->moduleTemplate->getIconFactory()->getIcon(
-                        'actions-document-new',
+                        'actions-add',
                         Icon::SIZE_SMALL
                     ));
                 $buttonBar->addButton($newButton);