[TASK] Revoke deprecation of makeRedirectUrl() 54/33954/3
authorChristian Kuhn <lolli@schwarzbu.ch>
Mon, 10 Nov 2014 16:00:54 +0000 (17:00 +0100)
committerWouter Wolters <typo3@wouterwolters.nl>
Mon, 10 Nov 2014 17:32:11 +0000 (18:32 +0100)
Method GeneralUtility::makeRedirectUrl() was deprecated with #62794.
The patch intended to deprecate some old mail handling methods, but
makeRedirectUrl() is the general URL shortening feature in the core
that should not be kicked.

Change-Id: Idda2f13b962feda3b8e195e2c331b6d5e25f5498
Resolves: #62831
Related: #62794
Releases: master
Reviewed-on: http://review.typo3.org/33954
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
typo3/sysext/core/Classes/Utility/GeneralUtility.php
typo3/sysext/core/Documentation/Changelog/master/Deprecation-62794-DeprecateOldMailMethodsInGeneralUtility.rst

index c86822c..c230331 100644 (file)
@@ -4768,16 +4768,14 @@ Connection: close
        }
 
        /**
-        * Sub-function for substUrlsInPlainText() above.
+        * Create a shortened "redirect" URL with specified length from an incoming URL
         *
         * @param string $inUrl Input URL
         * @param int $l URL string length limit
         * @param string $index_script_url URL of "index script" - the prefix of the "?RDCT=..." parameter. If not supplied it will default to \TYPO3\CMS\Core\Utility\GeneralUtility::getIndpEnv('TYPO3_REQUEST_DIR').'index.php'
         * @return string Processed URL
-        * @deprecated since TYPO3 CMS 7, will be removed in CMS 8. Use mailer API instead
         */
        static public function makeRedirectUrl($inUrl, $l = 0, $index_script_url = '') {
-               static::logDeprecatedFunction();
                if (strlen($inUrl) > $l) {
                        $md5 = substr(md5($inUrl), 0, 20);
                        $count = $GLOBALS['TYPO3_DB']->exec_SELECTcountRows('*', 'cache_md5params', 'md5hash=' . $GLOBALS['TYPO3_DB']->fullQuoteStr($md5, 'cache_md5params'));
index e3b9964..7f3b469 100644 (file)
@@ -10,7 +10,6 @@ The following methods of the class \TYPO3\CMS\Core\Utility\GeneralUtility are de
  * quoted_printable()
  * encodeHeader()
  * substUrlsInPlainText()
- * makeRedirectUrl()
 
 Impact
 ======
@@ -27,4 +26,4 @@ Migration
 =========
 
 Code that still uses these methods should be refactored to the mail API using
-TYPO3\CMS\Core\Mail\Mailer class.
\ No newline at end of file
+TYPO3\CMS\Core\Mail\Mailer class.