[TASK] Make new content element button in page view speaking 57/37057/4
authorBenjamin Kott <benjamin.kott@outlook.com>
Fri, 20 Feb 2015 18:31:36 +0000 (19:31 +0100)
committerJigal van Hemert <jigal.van.hemert@typo3.org>
Sun, 22 Feb 2015 18:43:31 +0000 (19:43 +0100)
The new content element button is hard to spot for new users
and not self explaining / missleading in the first place.

Unifying the "new record here" button with the corresponding
title from the new record view makes it more clear what kinds
of records will be available to place in a column and at the place
the user has chosen.

Resolves: #65206
Releases: master
Change-Id: Icbe897f943d27771cdbb5e70505d1f47f6adfbdf
Reviewed-on: http://review.typo3.org/37057
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
typo3/sysext/backend/Classes/View/PageLayoutView.php
typo3/sysext/cms/layout/locallang.xlf
typo3/sysext/t3skin/Resources/Private/Styles/TYPO3/structure/_module_web_page.less
typo3/sysext/t3skin/Resources/Private/Styles/TYPO3/visual/_module_web_page.less
typo3/sysext/t3skin/Resources/Public/Css/visual/t3skin.css

index a6dac17..accad40 100644 (file)
@@ -460,8 +460,10 @@ class PageLayoutView extends \TYPO3\CMS\Recordlist\RecordList\AbstractDatabaseRe
                                                <div class="t3-page-ce-dropzone" id="colpos-' . $key . '-' . 'page-' . $id . '-' . uniqid('', TRUE) . '">
                                                        <div class="t3-page-ce-wrapper-new-ce">
                                                                <a href="#" onclick="' . htmlspecialchars($this->newContentElementOnClick($id, $key, $lP))
-                                                                       . '" title="' . $this->getLanguageService()->getLL('newRecordHere', TRUE) . '" class="btn btn-default btn-sm">'
-                                                                       . IconUtility::getSpriteIcon('actions-document-new') . '</a>
+                                                                       . '" title="' . $this->getLanguageService()->getLL('newContentElement', TRUE) . '" class="btn btn-default btn-sm">'
+                                                                       . IconUtility::getSpriteIcon('actions-document-new')
+                                                                       . ' '
+                                                                       . $this->getLanguageService()->getLL('content', TRUE) . '</a>
                                                        </div>
                                                </div>
                                        </div>
@@ -527,8 +529,10 @@ class PageLayoutView extends \TYPO3\CMS\Recordlist\RecordList\AbstractDatabaseRe
                                                                $singleElementHTML .= '
                                                                        <div class="t3-page-ce-wrapper-new-ce">
                                                                                <a href="#" onclick="' . htmlspecialchars($onClick) . '" title="'
-                                                                                       . $this->getLanguageService()->getLL('newRecordHere', TRUE) . '" class="btn btn-default btn-sm">'
-                                                                                       . IconUtility::getSpriteIcon('actions-document-new') . '</a>
+                                                                                       . $this->getLanguageService()->getLL('newContentElement', TRUE) . '" class="btn btn-default btn-sm">'
+                                                                                       . IconUtility::getSpriteIcon('actions-document-new')
+                                                                                       . ' '
+                                                                                       . $this->getLanguageService()->getLL('content', TRUE) . '</a>
                                                                        </div>
                                                                ';
                                                        }
index 392da9f..662d7fc 100644 (file)
@@ -36,7 +36,7 @@
                        <trans-unit id="newAfter" xml:space="preserve">
                                <source>New record after this one</source>
                        </trans-unit>
-                       <trans-unit id="newRecordHere" xml:space="preserve">
+                       <trans-unit id="newRecordHere" xml:space="preserve" deprecated="Unused since CMS 7">
                                <source>Add a new record at this place</source>
                        </trans-unit>
                        <trans-unit id="move_record" xml:space="preserve">
@@ -72,6 +72,9 @@
                        <trans-unit id="newPageContent2" xml:space="preserve">
                                <source>New content</source>
                        </trans-unit>
+                       <trans-unit id="content" xml:space="preserve">
+                               <source>Content</source>
+                       </trans-unit>
                        <trans-unit id="newInColumn" xml:space="preserve">
                                <source>Create new record in top of this column</source>
                        </trans-unit>
index 92d6c99..ca24f7d 100644 (file)
@@ -51,10 +51,6 @@ td.t3-page-lang-column h3 {
        padding: 0 0 5px 0;
 }
 
-.t3-page-ce-wrapper-new-ce {
-       margin: 0 0 0 5px;
-}
-
 .t3-page-ce-droptarget {
        padding: 5px;
 }
index c2939c7..c14b594 100644 (file)
        width: 1px;
 }
 
-.t3-page-ce-wrapper-new-ce {
-       cursor: default;
-       opacity: 1;
-}
-
 .t3-page-ce-droptarget {
        visibility: hidden;
        background-color: orange;
index 17375d7..d81b01c 100644 (file)
@@ -11607,9 +11607,6 @@ td.t3-page-lang-column h3 {
 .t3-page-ce-wrapper {
   padding: 0 0 5px 0;
 }
-.t3-page-ce-wrapper-new-ce {
-  margin: 0 0 0 5px;
-}
 .t3-page-ce-droptarget {
   padding: 5px;
 }
@@ -11960,10 +11957,6 @@ div.t3-upload-queue-progress {
   background-color: #cfcfcf;
   width: 1px;
 }
-.t3-page-ce-wrapper-new-ce {
-  cursor: default;
-  opacity: 1;
-}
 .t3-page-ce-droptarget {
   visibility: hidden;
   background-color: orange;