[BUGFIX] Missing ENABLE_INSTALL_TOOLs permissions let us loop 72/24672/5
authorAlexander Opitz <opitz.alexander@googlemail.com>
Sun, 13 Oct 2013 10:15:40 +0000 (12:15 +0200)
committerWouter Wolters <typo3@wouterwolters.nl>
Thu, 17 Oct 2013 21:01:44 +0000 (23:01 +0200)
If we can't touch ENABLE_INSTALL_TOOL or recreate it as we have not
enough permissions in typo3conf/ we will have an endless loop.

Fixing by not calling createInstallToolEnableFile(), the user must
update the file manually or fix the permissions which are shown as
error in the installer.

Resolves: #52744
Releases: 6.2
Change-Id: Ib3ad316b90f1971dc6b71a35d15a06783f927f7a
Reviewed-on: https://review.typo3.org/24672
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
typo3/sysext/install/Classes/Service/EnableFileService.php

index 42b4a69..94b71af 100644 (file)
@@ -98,8 +98,10 @@ class EnableFileService {
                if (is_file($enableFile)) {
                        $couldTouch = @touch($enableFile);
                        if (!$couldTouch) {
-                               self::removeInstallToolEnableFile();
-                               self::createInstallToolEnableFile();
+                               // If we can't remove the creation method will call us again.
+                               if (self::removeInstallToolEnableFile()) {
+                                       self::createInstallToolEnableFile();
+                               }
                        }
                }
        }