[BUGFIX] EM ConstantsView crashs with dep/faulty types. 98/19698/2
authorAlexander Opitz <opitz.alexander@googlemail.com>
Sat, 6 Apr 2013 18:56:55 +0000 (20:56 +0200)
committerChristian Kuhn <lolli@schwarzbu.ch>
Sat, 6 Apr 2013 19:04:20 +0000 (21:04 +0200)
The types default and input are deprecated. Removing of this let
the ConstantsView crash, as there is no function configuration for them.

We now readd the config in 6.1 as we have no problems with this lines
in the core and we don't know how much extensions exists which fail.

So removing deprecation in 6.1 message.

Resolves: #46996
Related: #44763
Releases: 6.1, 6.0
Change-Id: Ic9696bb61ac9cbe1618381f42c1c9d8a282cd14c
Reviewed-on: https://review.typo3.org/19698
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
typo3/sysext/extensionmanager/Classes/ViewHelpers/Form/TypoScriptConstantsViewHelper.php

index 3533974..e661bc2 100644 (file)
@@ -45,8 +45,8 @@ class TypoScriptConstantsViewHelper extends \TYPO3\CMS\Fluid\Core\ViewHelper\Abs
                'user' => 'renderUserFunction',
                'small' => 'renderSmallTextField',
                'string' => 'renderTextField',
-               'input' => 'renderTextField',   // only for backwards compatibility, will be removed with TYPO3 6.1
-               'default' => 'renderTextField'  // only for backwards compatibility, will be removed with TYPO3 6.1
+               'input' => 'renderTextField',  // only for backwards compatibility, many extensions depend on that
+               'default' => 'renderTextField' // only for backwards compatibility, many extensions depend on that
        );
 
        public $tagName = 'input';
@@ -207,10 +207,6 @@ class TypoScriptConstantsViewHelper extends \TYPO3\CMS\Fluid\Core\ViewHelper\Abs
         * @return string
         */
        protected function renderTextField(\TYPO3\CMS\Extensionmanager\Domain\Model\ConfigurationItem $configuration) {
-               if ($configuration->getType() !== 'string') {
-                       \TYPO3\CMS\Core\Utility\GeneralUtility::deprecationLog('The type "' . $configuration->getType() .
-                               '" is deprecated and will be removed with TYPO3 6.1');
-               }
                $this->tag->setTagName('input');
                $this->tag->addAttribute('type', 'text');
                $this->tag->addAttribute('name', $this->getName($configuration));