[TASK] Remove enm1989/chromedriver dependency 66/57766/6
authorChristian Kuhn <lolli@schwarzbu.ch>
Wed, 1 Aug 2018 20:41:21 +0000 (22:41 +0200)
committerAndreas Wolf <andreas.wolf@typo3.org>
Sun, 2 Sep 2018 14:03:02 +0000 (16:03 +0200)
We don't need chromedriver as dev dependency anymore since
the acceptance tests use selenium via docker nowadays.
Executing ac tests locally will be simplified with another
patch, but using chromedriver is ditched already since
that does not lead to stable tests.

composer remove --dev enm1989/chromedriver

Change-Id: I7af8a1f4ba86ff4058a2726fb74f3d643836f95a
Resolves: #85716
Releases: master
Reviewed-on: https://review.typo3.org/57766
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
composer.json
composer.lock
typo3/sysext/core/Tests/Acceptance/Backend.suite.yml
typo3/sysext/core/composer.json

index 01dd330..a049ad9 100644 (file)
@@ -65,7 +65,6 @@
        },
        "require-dev": {
                "codeception/codeception": "^2.4.5",
-               "enm1989/chromedriver": "~2.30",
                "fiunchinho/phpunit-randomizer": "^4.0",
                "friendsofphp/php-cs-fixer": "^2.12.2",
                "typo3/cms-styleguide": "~9.2.0",
index 1895933..b2a3da5 100644 (file)
@@ -4,7 +4,7 @@
         "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies",
         "This file is @generated automatically"
     ],
-    "content-hash": "4bce6d87628baf0180cac0d3db3fd4c1",
+    "content-hash": "d36aef040550327a079acca32b0db67d",
     "packages": [
         {
             "name": "cogpowered/finediff",
             "time": "2018-04-11T15:42:36+00:00"
         },
         {
-            "name": "enm1989/chromedriver",
-            "version": "2.40",
-            "source": {
-                "type": "git",
-                "url": "https://github.com/ENM1989/chromedriver.git",
-                "reference": "8cfd4c627f77615ae03882c7e6afa2fb97430224"
-            },
-            "dist": {
-                "type": "zip",
-                "url": "https://api.github.com/repos/ENM1989/chromedriver/zipball/8cfd4c627f77615ae03882c7e6afa2fb97430224",
-                "reference": "8cfd4c627f77615ae03882c7e6afa2fb97430224",
-                "shasum": ""
-            },
-            "bin": [
-                "bin/chromedriver"
-            ],
-            "type": "library",
-            "notification-url": "https://packagist.org/downloads/",
-            "license": [
-                "Apache-2.0"
-            ],
-            "authors": [
-                {
-                    "name": "Nico Müller",
-                    "email": "nico.mueller.1989@googlemail.com"
-                }
-            ],
-            "description": "Composer distribution of Chromedriver. Adds a executable to your composer bin directory.",
-            "homepage": "https://github.com/ENM1989/chromedriver",
-            "keywords": [
-                "Chromedriver",
-                "chrome",
-                "selenium",
-                "webdriver"
-            ],
-            "time": "2018-06-17T20:44:35+00:00"
-        },
-        {
             "name": "facebook/webdriver",
             "version": "1.6.0",
             "source": {
index c2c3923..68365b3 100644 (file)
@@ -20,22 +20,3 @@ extensions:
 
 groups:
   AcceptanceTests-Job-*: AcceptanceTests-Job-*
-
-env:
-  headless:
-    modules:
-      config:
-        WebDriver:
-          host: localhost
-          port: 9515
-          url: http://localhost:8000/typo3temp/var/tests/acceptance
-          capabilities:
-            # Disable the "scroll to element before clicking" behavior as this breaks tests
-            # where for example a fixed docbar is used. Selenium scrolls to the element before
-            # clicking it and then complains that it can't click the element because another elemnt
-            # is overlaying it.
-            # You have to ensure that the element is in the viewport by your own before clicking it!
-            # You can simply do that by scrolling to it.
-            elementScrollBehavior: 1
-            chromeOptions:
-              args: ["--headless", "--no-sandbox", "window-size=1280x1024", "--proxy-server='direct://'", "--proxy-bypass-list=*", "--disable-gpu"]
index 4dbc5d5..518dcb9 100644 (file)
@@ -47,7 +47,6 @@
        },
        "require-dev": {
                "codeception/codeception": "^2.4.5",
-               "enm1989/chromedriver": "~2.30",
                "fiunchinho/phpunit-randomizer": "^4.0",
                "friendsofphp/php-cs-fixer": "^2.12.2",
                "typo3/cms-styleguide": "~9.2.0",