[BUGFIX] Remove double escaping in warning in DatabaseRecordList 76/53176/2
authorGeorg Ringer <georg.ringer@gmail.com>
Wed, 7 Jun 2017 05:47:31 +0000 (07:47 +0200)
committerWouter Wolters <typo3@wouterwolters.nl>
Fri, 9 Jun 2017 14:42:24 +0000 (16:42 +0200)
As the flash message's title and text are escaped already, remove the
htmlspecialchars in DatabaseRecordList.

Additionally remove the text "Warning:" from the text as this is already
expressed by the flash message itself.

Resolves: #81494
Releases: master, 8.7
Change-Id: I557dfb6f1422d2194dcdf83bbbc156a99efb290e
Reviewed-on: https://review.typo3.org/53176
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
typo3/sysext/lang/Resources/Private/Language/locallang_mod_web_list.xlf
typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php

index 52922aa..7a2e1da 100644 (file)
                                <source>Missing TCA definition</source>
                        </trans-unit>
                        <trans-unit id="missingTcaColumnsMessage">
-                               <source>Warning: No fields for table "%s" have been found. $TCA['%s']['columns'] does not contain the necessary definitions.</source>
+                               <source>No fields for table "%s" have been found. $TCA['%s']['columns'] does not contain the necessary definitions.</source>
                        </trans-unit>
                        <trans-unit id="noRecordsOnThisPage">
                                <source>There are no records on this page.</source>
index a079a57..c3b52ae 100644 (file)
@@ -606,8 +606,8 @@ class DatabaseRecordList extends AbstractDatabaseRecordList
         $selectFields = array_unique($selectFields);
         $fieldListFields = $this->makeFieldList($table, 1);
         if (empty($fieldListFields) && $GLOBALS['TYPO3_CONF_VARS']['BE']['debug']) {
-            $message = sprintf(htmlspecialchars($lang->sL('LLL:EXT:lang/Resources/Private/Language/locallang_mod_web_list.xlf:missingTcaColumnsMessage')), $table, $table);
-            $messageTitle = htmlspecialchars($lang->sL('LLL:EXT:lang/Resources/Private/Language/locallang_mod_web_list.xlf:missingTcaColumnsMessageTitle'));
+            $message = sprintf($lang->sL('LLL:EXT:lang/Resources/Private/Language/locallang_mod_web_list.xlf:missingTcaColumnsMessage'), $table, $table);
+            $messageTitle = $lang->sL('LLL:EXT:lang/Resources/Private/Language/locallang_mod_web_list.xlf:missingTcaColumnsMessageTitle');
             /** @var FlashMessage $flashMessage */
             $flashMessage = GeneralUtility::makeInstance(
                 FlashMessage::class,